linux-toradex.git/drivers/base/platform.c, branch v2.6.26-rc5

drivers: fix dma_get_required_mask

2008-03-10T23:33:33+00:00

There's a bug in the current implementation of dma_get_required_mask()
where it ands the returned mask with the current device mask.  This
rather defeats the purpose if you're using the call to determine what
your mask should be (since you will at that time have the default
DMA_32BIT_MASK).  This bug results in any driver that uses this function
*always* getting a 32 bit mask, which is wrong.

Fix by removing the and with dev->dma_mask.

Signed-off-by: James Bottomley 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

Driver core: coding style fixes

2008-01-25T06:50:12+00:00

Fix up a number of coding style issues in the drivers/base/ directory
that have annoyed me over the years.  checkpatch.pl is now very happy.

Signed-off-by: Greg Kroah-Hartman

Driver Core: constify the name passed to platform_device_register_simple

2008-01-25T04:40:43+00:00

This name is just passed to platform_device_alloc which has its parameter
declared const.

Signed-off-by: Stephen Rothwell 
Signed-off-by: Greg Kroah-Hartman

Driver core: move the static kobject out of struct driver

2008-01-25T04:40:35+00:00

This patch removes the kobject, and a few other driver-core-only fields
out of struct driver and into the driver core only.  Now drivers can be
safely create on the stack or statically (like they currently are.)

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: remove fields from struct bus_type

2008-01-25T04:40:33+00:00

struct bus_type is static everywhere in the kernel.  This moves the
kobject in the structure out of it, and a bunch of other private only to
the driver core fields are now moved to a private structure.  This lets
us dynamically create the backing kobject properly and gives us the
chance to be able to document to users exactly how to use the struct
bus_type as there are no fields they can improperly access.

Thanks to Kay for the build fixes on this patch.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Driver core: Make platform_device.id an int

2007-10-12T21:51:07+00:00

While platform_device.id is a u32, platform_device_add() handles "-1"
as a special id value. This has potential for confusion and bugs.
Making it an int instead should prevent problems from happening in
the future.

Signed-off-by: Jean Delvare 
Signed-off-by: Greg Kroah-Hartman

Driver core: change add_uevent_var to use a struct

2007-10-12T21:51:01+00:00

This changes the uevent buffer functions to use a struct instead of a
long list of parameters. It does no longer require the caller to do the
proper buffer termination and size accounting, which is currently wrong
in some places. It fixes a known bug where parts of the uevent
environment are overwritten because of wrong index calculations.

Many thanks to Mathieu Desnoyers for finding bugs and improving the
error handling.

Signed-off-by: Kay Sievers 
Cc: Mathieu Desnoyers 
Cc: Cornelia Huck 
Signed-off-by: Greg Kroah-Hartman

platform: prefix MODALIAS with "platform:"

2007-10-12T21:50:59+00:00

Prefix platform modalias strings with "platform:", which
modprobe config to blacklist alias resolving if userspace
configures it.

Send uevents for all platform devices.

Add MODULE_ALIAS's to: pxa2xx_pcmcia, ds1742 and pcspkr to trigger
module autoloading by userspace.

  $ modinfo pcspkr
  alias:          platform:pcspkr
  license:        GPL
  description:    PC Speaker beeper driver
  ...

  $ modprobe -n -v platform:pcspkr
  insmod /lib/modules/2.6.23-rc3-g28e8351a-dirty/kernel/drivers/input/misc/pcspkr.ko

Signed-off-by: Kay Sievers 
Cc: David Brownell 
Cc: Atsushi Nemoto 
Signed-off-by: Greg Kroah-Hartman

drivers/base/platform.c: fix small typo in doc

2007-05-09T06:58:16+00:00

Typo: iwithout -> without.

Signed-off-by: Márton Németh 
Signed-off-by: Adrian Bunk

fix hotplug for legacy platform drivers

2007-05-08T18:15:10+00:00

We've had various reports of some legacy "probe the hardware" style
platform drivers having nasty problems with hotplug support.

The core issue is that those legacy drivers don't fully conform to the
driver model.  They assume a role that should be the responsibility of
infrastructure code: creating device nodes.

The "modprobe" step in hotplugging relies on drivers to have split those
roles into different modules.  The lack of this split causes the problems.
When a driver creates nodes for devices that don't exist (sending a hotplug
event), then exits (aborting one modprobe) before the "modprobe $MODALIAS"
step completes (by failing, since it's in the middle of a modprobe), the
result can be an endless loop of modprobe invocations ...  badness.

This fix uses the newish per-device flag controlling issuance of "add"
events.  (A previous version of this patch used a per-device "driver can
hotplug" flag, which only scrubbed $MODALIAS from the environment rather
than suppressing the entire hotplug event.) It also shrinks that flag to
one bit, saving a word in "struct device".

So the net of this patch is removing some nasty failures with legacy
drivers, while retaining hotplug capability for the majority of platform
drivers.

Signed-off-by: David Brownell 
Cc: Greg KH 
Cc: Andres Salomon 
Cc: Dominik Brodowski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds