linux-toradex.git/drivers/base/platform.c, branch v4.4-rc6

driver-core: platform: Provide helpers for multi-driver modules

2015-10-05T04:02:40+00:00

Some modules register several sub-drivers. Provide a helper that makes
it easy to register and unregister a list of sub-drivers, as well as
unwind properly on error.

Signed-off-by: Thierry Reding 
Signed-off-by: Greg Kroah-Hartman

base/platform: assert that dev_pm_domain callbacks are called unconditionally

2015-10-04T18:42:22+00:00

When a platform driver doesn't provide a .remove callback the function
platform_drv_remove isn't called and so the call to dev_pm_domain_attach
called at probe time isn't paired by dev_pm_domain_detach at remove
time.

To fix this (and similar issues if different callbacks are missing) hook
up the driver callbacks unconditionally and make them aware that the
platform callbacks might be missing.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Greg Kroah-Hartman

drivercore: Fix unregistration path of platform devices

2015-08-25T16:29:57+00:00

The unregister path of platform_device is broken. On registration, it
will register all resources with either a parent already set, or
type==IORESOURCE_{IO,MEM}. However, on unregister it will release
everything with type==IORESOURCE_{IO,MEM}, but ignore the others. There
are also cases where resources don't get registered in the first place,
like with devices created by of_platform_populate()*.

Fix the unregister path to be symmetrical with the register path by
checking the parent pointer instead of the type field to decide which
resources to unregister. This is safe because the upshot of the
registration path algorithm is that registered resources have a parent
pointer, and non-registered resources do not.

* It can be argued that of_platform_populate() should be registering
  it's resources, and they argument has some merit. However, there are
  quite a few platforms that end up broken if we try to do that due to
  overlapping resources in the device tree. Until that is fixed, we need
  to solve the immediate problem.

Cc: Pantelis Antoniou 
Cc: Wolfram Sang 
Cc: Rob Herring 
Cc: Greg Kroah-Hartman 
Cc: Ricardo Ribalda Delgado 
Signed-off-by: Grant Likely 
Tested-by: Ricardo Ribalda Delgado 
Tested-by: Wolfram Sang 
Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring

Revert "base/platform: Only insert MEM and IO resources"

2015-06-10T15:38:29+00:00

This reverts commit 36d4b29260753ad78b1ce4363145332c02519adc as it
breaks working machines.

Cc: Rob Herring 
Cc: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

Revert "base/platform: Continue on insert_resource() error"

2015-06-10T15:38:02+00:00

This reverts commit e50e69d1ac4232af0b6890f16929bf5ceee81538 as it
breaks working machines.

Cc: Rob Herring 
Cc: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

Revert "base/platform: Remove code duplication"

2015-06-10T15:36:50+00:00

This reverts commit 6d9d4b1469b0d9748145e168fc9ec585e1f3f4b0 as it
breaks working machines.

Cc: Rob Herring 
Cc: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

base/platform: Remove code duplication

2015-06-01T01:15:17+00:00

Failure path of platform_device_add was almost the same as
platform_device_del. Refactor same code in a function.

Acked-by: Rob Herring 
Signed-off-by: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

base/platform: Continue on insert_resource() error

2015-06-01T01:15:17+00:00

insert_resource() can fail when the resource added  overlaps
(partially or fully) with another.

Device tree and AMBA devices may contain resources that overlap, so they
could not call platform_device_add (see 02bbde7849e6 ('Revert "of:
use platform_device_add"'))"

On the other hand, device trees are released using
platform_device_unregister(). This function calls platform_device_del(),
which calls release_resource(), that crashes when the resource has not
been added with with insert_resource. This was not an issue when the
device tree could not be modified online, but this is not the case
anymore.

This patch let the flow continue when there is an insert error, after
notifying the user with a dev_err(). r->parent is set to NULL, so
platform_device_del() knows that the resource was not added, and
therefore it should not be released.

Acked-by: Rob Herring 
Signed-off-by: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

base/platform: Only insert MEM and IO resources

2015-06-01T01:15:17+00:00

platform_device_del only checks the type of the resource in order to
call release_resource.

On the other hand, platform_device_add calls insert_resource for any
resource that has a parent.

Make both code branches balanced.

Signed-off-by: Ricardo Ribalda Delgado 
Signed-off-by: Greg Kroah-Hartman

driver-core: platform_driver_probe() must probe synchronously

2015-05-20T07:25:25+00:00

Because platform_driver_probe() checks, after trying to register driver,
if there are any devices that driver successfully bound to, driver's
probe routine must be run synchronously.

Signed-off-by: Dmitry Torokhov 
Signed-off-by: Greg Kroah-Hartman