linux-toradex.git/drivers/base/regmap/regmap-debugfs.c, branch v4.16

regmap: debugfs: document why we don't create the debugfs entries

2017-12-27T10:33:24+00:00

This is a follow-up to commit a5ba91c380b8 ("regmap: debugfs: emit a
debug message when locking is disabled"). I figured that a user may
see this message, grep the code, come to this place and he still won't
know why we actually disabled debugfs.

Add a comment explaining the reason.

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Mark Brown

regmap: debugfs: emit a debug message when locking is disabled

2017-12-21T12:27:25+00:00

We currently silently omit creating the debugfs entries when regmap
locking is disabled. Users may not be aware of the reason for which
regmap files don't show up in debugfs. Add a dev_dbg() message
explaining that.

Signed-off-by: Bartosz Golaszewski 
Signed-off-by: Mark Brown

regmap: Disable debugfs when locking is disabled

2017-12-13T16:22:31+00:00

The recently added support for disabling the regmap internal locking left
debugfs enabled for devices with the locking disabled. This is a problem
since debugfs allows userspace to do things like initiate reads from the
hardware which will use the scratch buffers protected by the regmap locking
so could cause data corruption.

For safety address this by just disabling debugfs for these devices. That
is overly conservative since some of the debugfs files just read internal
data structures but it's much simpler to implmement and less likely to
lead to problems with tooling that works with debugfs.

Reported-by: Lars-Peter Clausen 
Signed-off-by: Mark Brown

regmap: debugfs: Add support for dumping write only device registers

2016-08-09T12:43:33+00:00

Add support for dumping write only device registers in debugfs. This is
useful for audio codecs that have write only registers (like WM8731).
The logic that decides if a value can be printed is moved to
regmap_printable() function to allow for easier future updates.

Signed-off-by: Cristian Birsan 
Signed-off-by: Mark Brown

regmap: debugfs: Use seq_file for the access map

2016-01-05T18:32:22+00:00

Unlike the registers file we don't have any substantial performance
concerns rendering the entire file (it involves no device accesses) so
just use seq_printf() to simplify the code.

Signed-off-by: Mark Brown

regmap: debugfs: simplify regmap_reg_ranges_read_file() slightly

2015-09-30T19:31:16+00:00

By printing the newline character to entry, we can avoid accounting
for it manually in several places.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Mark Brown

regmap: debugfs: use memcpy instead of snprintf

2015-09-30T19:31:16+00:00

Since we know the length of entry and that there's room enough in the
output buffer, using memcpy instead of snprintf is simpler and
cheaper.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Mark Brown

regmap: debugfs: use snprintf return value in regmap_reg_ranges_read_file()

2015-09-30T19:31:15+00:00

Calling strlen() no less than three times on entry is silly. Since
we're formatting into a buffer with plenty of room, there's no chance
of truncation, so snprintf() has actually returned the value we want,
meaning we don't even have to call strlen once.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Mark Brown

regmap: debugfs: Remove scratch buffer for register length calculation

2015-09-19T14:38:27+00:00

Now we no longer use the scratch buffer for register length calculation
there is no need for callers to supply one.

Signed-off-by: Mark Brown

regmap: debugfs: Don't bother actually printing when calculating max length

2015-09-19T14:38:12+00:00

The in kernel snprintf() will conveniently return the actual length of
the printed string even if not given an output beffer at all so just do
that rather than relying on the user to pass in a suitable buffer,
ensuring that we don't need to worry if the buffer was truncated due to
the size of the buffer passed in.

Reported-by: Rasmus Villemoes 
Signed-off-by: Mark Brown 
Cc: stable@vger.kernel.org