linux-toradex.git/drivers/base/regmap/regmap-debugfs.c, branch v4.8-rc6

regmap: debugfs: Use seq_file for the access map

2016-01-05T18:32:22+00:00

Unlike the registers file we don't have any substantial performance
concerns rendering the entire file (it involves no device accesses) so
just use seq_printf() to simplify the code.

Signed-off-by: Mark Brown

regmap: debugfs: simplify regmap_reg_ranges_read_file() slightly

2015-09-30T19:31:16+00:00

By printing the newline character to entry, we can avoid accounting
for it manually in several places.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Mark Brown

regmap: debugfs: use memcpy instead of snprintf

2015-09-30T19:31:16+00:00

Since we know the length of entry and that there's room enough in the
output buffer, using memcpy instead of snprintf is simpler and
cheaper.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Mark Brown

regmap: debugfs: use snprintf return value in regmap_reg_ranges_read_file()

2015-09-30T19:31:15+00:00

Calling strlen() no less than three times on entry is silly. Since
we're formatting into a buffer with plenty of room, there's no chance
of truncation, so snprintf() has actually returned the value we want,
meaning we don't even have to call strlen once.

Signed-off-by: Rasmus Villemoes 
Signed-off-by: Mark Brown

regmap: debugfs: Remove scratch buffer for register length calculation

2015-09-19T14:38:27+00:00

Now we no longer use the scratch buffer for register length calculation
there is no need for callers to supply one.

Signed-off-by: Mark Brown

regmap: debugfs: Don't bother actually printing when calculating max length

2015-09-19T14:38:12+00:00

The in kernel snprintf() will conveniently return the actual length of
the printed string even if not given an output beffer at all so just do
that rather than relying on the user to pass in a suitable buffer,
ensuring that we don't need to worry if the buffer was truncated due to
the size of the buffer passed in.

Reported-by: Rasmus Villemoes 
Signed-off-by: Mark Brown 
Cc: stable@vger.kernel.org

regmap: debugfs: Ensure we don't underflow when printing access masks

2015-09-19T14:38:11+00:00

If a read is attempted which is smaller than the line length then we may
underflow the subtraction we're doing with the unsigned size_t type so
move some of the calculation to be additions on the right hand side
instead in order to avoid this.

Reported-by: Rasmus Villemoes 
Signed-off-by: Mark Brown 
Cc: stable@vger.kernel.org

regmap: debugfs: Fix misuse of IS_ENABLED

2015-08-07T12:31:58+00:00

IS_ENABLED should only be used for CONFIG_* symbols.

I have done a small test:
  #define REGMAP_ALLOW_WRITE_DEBUGFS
  IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 0.

  #define REGMAP_ALLOW_WRITE_DEBUGFS 0
  IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 0.

  #define REGMAP_ALLOW_WRITE_DEBUGFS 1
  IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 1.

  #define REGMAP_ALLOW_WRITE_DEBUGFS 2
  IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 0.

So fix the misuse of IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) and switch to
use #if defined(REGMAP_ALLOW_WRITE_DEBUGFS) instead.

Signed-off-by: Axel Lin 
Signed-off-by: Mark Brown

regmap: debugfs: Allow writes to cache state settings

2015-07-20T17:45:00+00:00

Allow the user to write the cache_only and cache_bypass settings.
This can be useful for debugging.

Since this can lead to the hardware getting out-of-sync with the
cache, at least for the period that the cache state is forced, the
kernel is tainted and the action is recorded in the kernel log.

When disabling cache_only through debugfs a cache sync will be performed.

Signed-off-by: Richard Fitzgerald 
Signed-off-by: Mark Brown

Merge remote-tracking branch 'regmap/fix/debugfs' into regmap-linus

2014-09-29T19:49:40+00:00