linux-toradex.git/drivers/base, branch v2.6.29

mm: get_nid_for_pfn() returns int

2009-03-10T22:55:10+00:00

get_nid_for_pfn() returns int

Presumably the (nid < 0) case has never happened.

We do know that it is happening on one system while creating a symlink for
a memory section so it should also happen on the same system if
unregister_mem_sect_under_nodes() were called to remove the same symlink.

The test was actually added in response to a problem with an earlier
version reported by Yasunori Goto where one or more of the leading pages
of a memory section on the 2nd node of one of his systems was
uninitialized because I believe they coincided with a memory hole.

That earlier version did not ignore uninitialized pages and determined
the nid by considering only the 1st page of each memory section.  This
caused the symlink to the 1st memory section on the 2nd node to be
incorrectly created in /sys/devices/system/node/node0 instead of
/sys/devices/system/node/node1.  The problem was fixed by adding the
test to skip over uninitialized pages.

I suspect we have not seen any reports of the non-removal
of a symlink due to the incorrect declaration of the nid
variable in unregister_mem_sect_under_nodes() because
  - systems where a memory section could have an uninitialized
    range of leading pages are probably rare.
  - memory remove is probably not done very frequently on the
    systems that are capable of demonstrating the problem.
  - lingering symlink(s) that should have been removed may
    have simply gone unnoticed.

[garyhade@us.ibm.com: wrote changelog]
Signed-off-by: Roel Kluin 
Cc: Gary Hade 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

PM: Split up sysdev_[suspend|resume] from device_power_[down|up], fix

2009-02-22T21:09:33+00:00

Impact: module build fix

Fix:

 ERROR: "sysdev_resume" [arch/x86/kernel/apm.ko] undefined!
 ERROR: "sysdev_suspend" [arch/x86/kernel/apm.ko] undefined!

As these APIs are now used by the APM driver, which can be built
as a module.

Also fix a few extra (and inconsistent) newlines in comment blocks
preceding these functions.

Signed-off-by: Ingo Molnar

PM: Split up sysdev_[suspend|resume] from device_power_[down|up]

2009-02-22T18:33:44+00:00

Move the sysdev_suspend/resume from the callee to the callers, with
no real change in semantics, so that we can rework the disabling of
interrupts during suspend/hibernation.

This is based on an earlier patch from Linus.

Signed-off-by: Rafael J. Wysocki 
Signed-off-by: Linus Torvalds

Consolidate driver_probe_done() loops into one place

2009-02-21T22:17:17+00:00

there's a few places that currently loop over driver_probe_done(), and
I'm about to add another one. This patch abstracts it into a helper
to reduce duplication.

Signed-off-by: Arjan van de Ven 
Signed-off-by: Rafael J. Wysocki 
Cc: Len Brown 
Acked-by: Greg KH 
Signed-off-by: Linus Torvalds

driver-core: fix kernel-doc parameter name

2009-01-28T23:55:48+00:00

Fix function parameter name in kernel-doc:

Warning(linux-next-20090120//drivers/base/core.c:1289): No description found for parameter 'dev'
Warning(linux-next-20090120//drivers/base/core.c:1289): Excess function parameter 'root' description in 'root_device_unregister'

Signed-off-by: Randy Dunlap 
Acked-by: Mark McLoughlin 
Signed-off-by: Greg Kroah-Hartman

driver core: Convert '/' to '!' in dev_set_name()

2009-01-21T04:52:08+00:00

Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
dev_set_name()") deleted the code in register_disk() that changed a '/'
to a '!' in the device name when registering a disk, but dev_set_name()
does not perform this conversion.

This leads to amusing problems with disks that have '/' in their names:
for example a failure to boot with the root partition on a cciss device,
even though the kernel says it knows about the root device:

    VFS: Cannot open root device "cciss/c0d0p6" or unknown-block(0,0)
    Please append a correct "root=" boot option; here are the available partitions:
    6800        71652960 cciss/c0d0 driver: cciss
      6802               1 cciss/c0d0p2
      6805         2931831 cciss/c0d0p5
      6806        34354908 cciss/c0d0p6
    6810        71652960 cciss/c0d1 driver: cciss

Fix this by adding code to change '/' to '!' in dev_set_name() to handle
this until dev_set_name() is converted to use kobject_set_name().

Signed-off-by: Roland Dreier 
Acked-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: create a private portion of struct device"

2009-01-09T23:06:12+00:00

This reverts commit 2831fe6f9cc4e16c103504ee09a47a084297c0f3.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: move klist_children into private structure"

2009-01-09T22:55:37+00:00

This reverts commit 11c3b5c3e08f4d855cbef52883c266b9ab9df879.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: move knode_driver into private structure"

2009-01-09T22:44:18+00:00

This reverts commit 93e746db183b3bdbbda67900f79b5835f9cb388f.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: move knode_bus into private structure"

2009-01-09T22:32:46+00:00

This reverts commit b9daa99ee533578e3f88231e7a16784dcb44ec42.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman