linux-toradex.git/drivers/base, branch v2.6.31.10

Driver core: fix driver_register() return value

2009-11-10T00:22:16+00:00

commit 39acbc12affcaa23ef1d887ba3d197baca8e6e47 upstream.

In this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=16dc42e018c2868211b4928f20a957c0c216126c
the check was added for another driver to already claim the same device
on the same bus. But the returned error code was wrong: to modprobe, the
-EEXIST means that _this_ driver is already installed. It therefore
doesn't produce the needed error message when _another_ driver is trying
to register for the same device.  Returning -EBUSY fixes the problem.

Signed-off-by: Stas Sergeev 
Signed-off-by: Greg Kroah-Hartman

Driver core: add new device to bus's list before probing

2009-10-05T16:32:33+00:00

commit 2023c610dc54a4f4130b0494309a9bd668ca3df8 upstream.

This patch (as1271) affects when new devices get linked into their
bus's list of devices.  Currently this happens after probing, and it
doesn't happen at all if probing fails.  Clearly this is wrong,
because at that point quite a few symbolic links have already been
created in sysfs.  We are committed to adding the device, so it should
be linked into the bus's list regardless.

In addition, this needs to happen before the uevent announcing the new
device gets issued.  Otherwise user programs might try to access the
device before it has been added to the bus.

To fix both these problems, the patch moves the call to
klist_add_tail() forward from bus_attach_device() to bus_add_device().
Since bus_attach_device() now does nothing but probe for drivers, it
has been renamed to bus_probe_device().  And lastly, the kerneldoc is
updated.

Signed-off-by: Alan Stern 
CC: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

PM / Driver Core: Kill dev_pm_ops platform warning for now

2009-08-10T21:41:18+00:00

Commit 783ea7d4eeefe895f2731fe73ac951e94418927b
(Driver Core: Rework platform suspend/resume, print warning)
added a warning message printed for platform drivers that use the
legacy PM callbacks rather than struct dev_pm_ops.  Unfortunately,
this resulted in some confusion and made some people try to convert
drivers by replacing the old callbacks with struct dev_pm_ops in
automatic way, which generally is not a good idea.

Remove the platform device runtime dev_pm_ops warning for now,
because it's annoying to users and it's not really necessary right
now.

[rjw: Modified the changelog to be more informative.]

Signed-off-by: Magnus Damm 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Rafael J. Wysocki

driver core: sysdev: do not send KOBJ_ADD uevent if kobject_init_and_add fails

2009-07-28T20:45:22+00:00

If kobject_init_and_add fails, sysdev_register should not send KOBJ_ADD
uevent to userspace.

Signed-off-by: Xiaotian Feng 
Signed-off-by: Greg Kroah-Hartman

driver core: firmware_class:fix memory leak of page pointers array

2009-07-28T20:45:22+00:00

The page pointers array is allocated in fw_realloc_buffer() called by
firmware_data_write(), and should be freed in release function of firmware
device.

Signed-off-by: Ming Lei 
Reported-by: Catalin Marinas 
Acked-by: David Woodhouse 
Signed-off-by: Greg Kroah-Hartman

Firmware: firmware_class, fix lock imbalance

2009-07-12T20:02:10+00:00

Add omitted unlock in firmware_data_read.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

devres: WARN() and return, don't crash on device_del() of uninitialized device

2009-07-12T20:02:09+00:00

I just debugged an obscure crash caused by a device_del() of a all NULL'd
out struct device (in usb-serial) and found that a patch like this one would
have saved me time (in addition to improved chances of a bug report from
users hitting similar driver bugs).

[akpm@linux-foundation.org: cleanup]
Signed-off-by: Benjamin Herrenschmidt 
Cc: Kay Sievers 
Cc: Tejun Heo 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/suspend-2.6

2009-07-08T16:35:22+00:00

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/suspend-2.6:
  PM: Clear -EAGAIN in dpm_prepare
  x86: Fix resume from suspend when CONFIG_CC_STACKPROTECTOR

Free struct device in fw_dev_release()

2009-07-08T16:34:08+00:00

The f_dev in _request_firmware() is allocated via the fw_setup_device()
and fw_register_device() calls and its class set to firmware_class (the
class release function is fw_dev_release).

Commit 6acf70f078ca replaced the kfree(dev) in fw_dev_release() with a
put_device() call but my understanding is that the release function is
called via put_device -> kobject_put -> kref_put -> koject_release etc.
and it should call kfree since it's the last to see this device
structure alive.

Because of that, the _request_firmware() function on its -ENOENT error
path only calls device_unregister(f_dev) which would eventually call
fw_dev_release() but there is no kfree (the subsequent put_device call
would just make the kref negative).

Signed-off-by: Catalin Marinas 
Acked-by: Cornelia Huck 
Acked-by: Ming Lei 
Signed-off-by: Linus Torvalds

PM: Clear -EAGAIN in dpm_prepare

2009-07-08T11:26:05+00:00

When the last device in the dpm list is unregistered directly after its
prepare() callback returned with -EAGAIN, the return code is passed to
the calling function, resulting in a suspend failure. Prevent this by
clearing the return code after -EAGAIN.

Signed-off-by: Sebastian Ott 
Signed-off-by: Rafael J. Wysocki