linux-toradex.git/drivers/block/cpqarray.c, branch v2.6.25-rc2

blk_end_request: changing cpqarray (take 4)

2008-01-28T09:37:00+00:00

This patch converts cpqarray to use blk_end_request interfaces.
Related 'ok' arguments are converted to 'error'.

cpqarray is a little bit different from "normal" drivers.
cpqarray directly calls bio_endio() and disk_stat_add()
when completing request.  But those can be replaced with
__end_that_request_first().
After the replacement, request completion procedures of
those drivers become like the following:
    o end_that_request_first()
    o add_disk_randomness()
    o end_that_request_last()
This can be converted to __blk_end_request() by following
the rule (b) mentioned in the patch subject
"[PATCH 01/30] blk_end_request: add new request completion interface".

Cc: Mike Miller 
Signed-off-by: Kiyoshi Ueda 
Signed-off-by: Jun'ichi Nomura 
Signed-off-by: Jens Axboe

[PATCH] Fix breakage after SG cleanups

2007-10-23T19:02:39+00:00

Commits

  58b053e4ce9d2fc3023645c1b96e537c72aa8d9a ("Update arch/ to use sg helpers")
  45711f1af6eff1a6d010703b4862e0d2b9afd056 ("[SG] Update drivers to use sg helpers")
  fa05f1286be25a8ce915c5dd492aea61126b3f33 ("Update net/ to use sg helpers")

converted many files to use the scatter gather helpers without ensuring
that the necessary headerfile  is included.  This
happened to work for ia64, powerpc, sparc64 and x86 because they
happened to drag in that file via their .

On most of the others this probably broke.

Instead of increasing the header file spider web I choose to include
 directly into the affectes files.

Signed-off-by: Ralf Baechle 
Signed-off-by: Jens Axboe 
Signed-off-by: Linus Torvalds

[SG] Update drivers to use sg helpers

2007-10-22T19:19:53+00:00

Signed-off-by: Jens Axboe

drivers/block/cpqarray,cciss: kill unused var

2007-10-16T07:59:55+00:00

The recent bio work and subsequent fixups created unused variables.

Signed-off-by: Jeff Garzik 
Signed-off-by: Jens Axboe

Drop 'size' argument from bio_endio and bi_end_io

2007-10-10T07:25:57+00:00

As bi_end_io is only called once when the reqeust is complete,
the 'size' argument is now redundant.  Remove it.

Now there is no need for bio_endio to subtract the size completed
from bi_size.  So don't do that either.

While we are at it, change bi_end_io to return void.

Signed-off-by: Neil Brown 
Signed-off-by: Jens Axboe

drivers/block/cpqarray.c: better error handling and kmalloc + memset conversion to k[cz]alloc

2007-08-11T20:34:48+00:00

This patch removes some redundant casts, does the kmalloc + memset to
k[cz]alloc conversion and it changes the error path to use goto (to avoid code
duplication).

 drivers/block/cpqarray.c | 49567 -> 48623 (-944 bytes)
 drivers/block/cpqarray.o | 178820 -> 178288 (-532 bytes)

Signed-off-by: Mariusz Kozlowski 
Acked-by: Mike Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

[BLOCK] Get rid of request_queue_t typedef

2007-07-24T07:28:11+00:00

Some of the code has been gradually transitioned to using the proper
struct request_queue, but there's lots left. So do a full sweet of
the kernel and get rid of this typedef and replace its uses with
the proper type.

Signed-off-by: Jens Axboe

[PATCH] getting rid of all casts of k[cmz]alloc() calls

2006-12-13T17:05:58+00:00

Run this:

	#!/bin/sh
	for f in $(grep -Erl "\([^\)]*\) *k[cmz]alloc" *) ; do
	  echo "De-casting $f..."
	  perl -pi -e "s/ ?= ?\([^\)]*\) *(k[cmz]alloc) *\(/ = \1\(/" $f
	done

And then go through and reinstate those cases where code is casting pointers
to non-pointers.

And then drop a few hunks which conflicted with outstanding work.

Cc: Russell King , Ian Molton 
Cc: Mikael Starvik 
Cc: Yoshinori Sato 
Cc: Roman Zippel 
Cc: Geert Uytterhoeven 
Cc: Ralf Baechle 
Cc: Paul Mackerras 
Cc: Kyle McMartin 
Cc: Benjamin Herrenschmidt 
Cc: Martin Schwidefsky 
Cc: "David S. Miller" 
Cc: Jeff Dike 
Cc: Greg KH 
Cc: Jens Axboe 
Cc: Paul Fulghum 
Cc: Alan Cox 
Cc: Karsten Keil 
Cc: Mauro Carvalho Chehab 
Cc: Jeff Garzik 
Cc: James Bottomley 
Cc: Ian Kent 
Cc: Steven French 
Cc: David Woodhouse 
Cc: Neil Brown 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] cpqarray: fix iostat

2006-11-14T23:08:50+00:00

cpqarray needs to call disk_stat_add() for iostat to work.

Signed-off-by: Jens Axboe 
Signed-off-by: Linus Torvalds

IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

2006-10-05T14:10:12+00:00

Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.

The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around.  On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).

Where appropriate, an arch may override the generic storage facility and do
something different with the variable.  On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.

Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions.  Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller.  A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.

I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.

This will affect all archs.  Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

	struct pt_regs *old_regs = set_irq_regs(regs);

And put the old one back at the end:

	set_irq_regs(old_regs);

Don't pass regs through to generic_handle_irq() or __do_IRQ().

In timer_interrupt(), this sort of change will be necessary:

	-	update_process_times(user_mode(regs));
	-	profile_tick(CPU_PROFILING, regs);
	+	update_process_times(user_mode(get_irq_regs()));
	+	profile_tick(CPU_PROFILING);

I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().

Some notes on the interrupt handling in the drivers:

 (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
     the input_dev struct.

 (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
     something different depending on whether it's been supplied with a regs
     pointer or not.

 (*) Various IRQ handler function pointers have been moved to type
     irq_handler_t.

Signed-Off-By: David Howells 
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)