linux-toradex.git/drivers/block/cpqarray.c, branch v4.4.93

genirq: Remove the deprecated 'IRQF_DISABLED' request_irq() flag entirely

2015-03-05T19:53:06+00:00

The IRQF_DISABLED flag is a NOOP and has been scheduled for removal
since Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove
IRQF_DISABLED from core code").

According to commit e58aa3d2d0cc ("genirq: Run irq handlers with
interrupts disabled"), running IRQ handlers with interrupts
enabled can cause stack overflows when the interrupt line of the
issuing device is still active.

This patch ends the grace period for IRQF_DISABLED (i.e.,
SA_INTERRUPT in older versions of Linux) and removes the
definition and all remaining usages of this flag.

There's still a few non-functional references left in the kernel
source:

  - The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely
    as IRQF_DISABLED is gone now; the usage in older kernel versions
    (including the old SA_INTERRUPT flag) should be discouraged.  The
    trouble of using IRQF_SHARED is a general problem and not specific to
    any driver.

  - I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since
    it has already been removed in linux-next.

  - All remaining references are changelogs that I suggest to keep.

Signed-off-by: Valentin Rothberg 
Cc: Afzal Mohammed 
Cc: Arnd Bergmann 
Cc: Brian Norris 
Cc: Christoph Hellwig 
Cc: Dan Carpenter 
Cc: David Woodhouse 
Cc: Ewan Milne 
Cc: Eyal Perry 
Cc: Felipe Balbi 
Cc: Greg Kroah-Hartman 
Cc: H. Peter Anvin 
Cc: Hannes Reinecke 
Cc: Hongliang Tao 
Cc: Huacai Chen 
Cc: Jiri Kosina 
Cc: Jonathan Corbet 
Cc: Keerthy 
Cc: Laurent Pinchart 
Cc: Linus Torvalds 
Cc: Nishanth Menon 
Cc: Paul Bolle 
Cc: Peter Ujfalusi 
Cc: Peter Zijlstra 
Cc: Quentin Lambert 
Cc: Rajendra Nayak 
Cc: Ralf Baechle 
Cc: Santosh Shilimkar 
Cc: Sricharan R 
Cc: Thomas Gleixner 
Cc: Tony Lindgren 
Cc: Zhou Wang 
Cc: iss_storagedev@hp.com
Cc: linux-mips@linux-mips.org
Cc: linux-mtd@lists.infradead.org
Link: http://lkml.kernel.org/r/1425565425-12604-1-git-send-email-valentinrothberg@gmail.com
Signed-off-by: Ingo Molnar

cpqarray: fix info leak in ida_locked_ioctl()

2013-09-25T00:00:26+00:00

The pciinfo struct has a two byte hole after ->dev_fn so stack
information could be leaked to the user.

This was assigned CVE-2013-2147.

Signed-off-by: Dan Carpenter 
Acked-by: Mike Miller 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

block_device_operations->release() should return void

2013-05-07T06:16:21+00:00

The value passed is 0 in all but "it can never happen" cases (and those
only in a couple of drivers) *and* it would've been lost on the way
out anyway, even if something tried to pass something meaningful.
Just don't bother.

Signed-off-by: Al Viro

procfs: new helper - PDE_DATA(inode)

2013-04-09T18:13:32+00:00

The only part of proc_dir_entry the code outside of fs/proc
really cares about is PDE(inode)->data.  Provide a helper
for that; static inline for now, eventually will be moved
to fs/proc, along with the knowledge of struct proc_dir_entry
layout.

Signed-off-by: Al Viro

Drivers: block: remove __dev* attributes.

2013-01-03T23:57:15+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Mike Miller 
Cc: Chirag Kantharia 
Cc: Geoff Levand 
Cc: Jim Paris 
Cc: Rusty Russell 
Cc: "Michael S. Tsirkin" 
Cc: Grant Likely 
Cc: Matthew Wilcox 
Cc: Keith Busch 
Cc: "David S. Miller" 
Cc: Benjamin Herrenschmidt 
Cc: NeilBrown 
Cc: Jens Axboe 
Cc: Tao Guo 
Signed-off-by: Greg Kroah-Hartman

drivers/block/cpqarray.c: use pci_dev->revision

2011-09-21T08:02:13+00:00

This driver uses PCI_CLASS_REVISION instead of PCI_REVISION_ID, so it
wasn't converted by commit 44c10138fd4bbc4b6 ("PCI: Change all drivers to
use pci_device->revision").

Signed-off-by: Sergei Shtylyov 
Acked-by: Mike Miller 
Cc: Chirag Kantharia 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

block: remove per-queue plugging

2011-03-10T07:52:07+00:00

Code has been converted over to the new explicit on-stack plugging,
and delay users have been converted to use the new API for that.
So lets kill off the old plugging along with aops->sync_page().

Signed-off-by: Jens Axboe

block: autoconvert trivial BKL users to private mutex

2010-10-05T13:01:10+00:00

The block device drivers have all gained new lock_kernel
calls from a recent pushdown, and some of the drivers
were already using the BKL before.

This turns the BKL into a set of per-driver mutexes.
Still need to check whether this is safe to do.

file=$1
name=$2
if grep -q lock_kernel ${file} ; then
    if grep -q 'include.*linux.mutex.h' ${file} ; then
            sed -i '/include.*/d' ${file}
    else
            sed -i 's/include.*.*$/include /g' ${file}
    fi
    sed -i ${file} \
        -e "/^#include.*linux.mutex.h/,$ {
                1,/^\(static\|int\|long\)/ {
                     /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);

} }"  \
    -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
    -e '/[      ]*cycle_kernel_lock();/d'
else
    sed -i -e '/include.*\/d' ${file}  \
                -e '/cycle_kernel_lock()/d'
fi

Signed-off-by: Arnd Bergmann

cpqarray: check put_user() result

2010-08-07T16:53:03+00:00

put_user() may fail, if so return -EFAULT.

Signed-off-by: Kulikov Vasiliy 
Acked-by: Mike Miller 
Signed-off-by: Jens Axboe

drivers/block: use memdup_user

2010-08-07T16:52:31+00:00

Use memdup_user when user data is immediately copied into the
allocated region.  Some checkpatch cleanups in nearby code.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@

-  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+  to = memdup_user(from,size);
   if (
-      to==NULL
+      IS_ERR(to)
                 || ...) {
   <+... when != goto l1;
-  -ENOMEM
+  PTR_ERR(to)
   ...+>
   }
-  if (copy_from_user(to, from, size) != 0) {
-    <+... when != goto l2;
-    -EFAULT
-    ...+>
-  }
// 

Signed-off-by: Julia Lawall 
Cc: Chirag Kantharia 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe