linux-toradex.git/drivers/block/drbd/drbd_bitmap.c, branch v3.18-rc5

drbd: Use consistent names for all the bi_end_io callbacks

2014-09-11T14:41:29+00:00

Now they follow the _endio naming sheme.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe

drbd: track details of bitmap IO

2014-07-10T16:35:15+00:00

Track start and submit time of bitmap operations, and
add pending bitmap IO contexts to a new pending_bitmap_io list.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: drop drbd_md_flush

2014-07-10T16:35:07+00:00

The only user of drbd_md_flush was bm_rw(),
and it is always followed by either a drbd_md_sync(),
or an al_write_transaction(), which, if so configured,
both end up submiting a FLUSH|FUA request anyways.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: cosmetic: change all printk(level, ...) to pr_(...)

2014-07-10T16:35:05+00:00

Cosmetic change only.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: get rid of atomic update on disk bitmap works

2014-07-10T16:34:49+00:00

Just trigger the occasional lazy bitmap write-out during resync
from the central wait_for_work() helper.

Previously, during resync, bitmap pages would be written out separately,
synchronously, one at a time, at least 8 times each (every 512 bytes
worth of bitmap cleared).

Now we trigger "merge friendly" bulk write out of all cleared pages
every two seconds during resync, and once the resync is finished.
Most pages will be written out only once.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: device->ldev is not guaranteed on an D_ATTACHING disk

2014-07-10T13:22:20+00:00

Some parts of the code assumed that get_ldev_if_state(device, D_ATTACHING)
is sufficient to access the ldev member of the device object. That was
wrong. ldev may not be there or might be freed at any time if the device
has a disk state of D_ATTACHING.

bm_rw()
  Documented that drbd_bm_read() is only called from drbd_adm_attach.
  drbd_bm_write() is only called when a reference is held, and it is
  documented that a caller has to hold a reference before calling
  drbd_bm_write()

drbd_bm_write_page()
  Use get_ldev() instead of get_ldev_if_state(device, D_ATTACHING)

drbd_bmio_set_n_write()
  No longer use get_ldev_if_state(device, D_ATTACHING). All callers
  hold a reference to ldev now.

drbd_bmio_clear_n_write()
  All callers where holding a reference of ldev anyways. Remove the
  misleading get_ldev_if_state(device, D_ATTACHING)

drbd_reconsider_max_bio_size()
  Removed the get_ldev_if_state(device, D_ATTACHING). All callers
  now pass a struct drbd_backing_dev* when they have a proper
  reference, or a NULL pointer.
  Before this fix, the receiver could trigger a NULL pointer
  deref when in drbd_reconsider_max_bio_size()

drbd_bump_write_ordering()
  Used get_ldev_if_state(device, D_ATTACHING) with the wrong assumption.
  Remove it, and allow the caller to pass in a struct drbd_backing_dev*
  when the caller knows that accessing this bdev is safe.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: Kill drbd_task_to_thread_name()

2014-02-17T15:50:35+00:00

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Philipp Reisner

drbd: Add explicit device parameter to D_ASSERT

2014-02-17T15:45:04+00:00

The implicit dependency on a variable inside the macro is problematic.

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Philipp Reisner

drbd: Remove the terrible DEV hack

2014-02-17T15:45:01+00:00

DRBD was using dev_err() and similar all over the code; instead of having to
write dev_err(disk_to_dev(device->vdisk), ...) to convert a drbd_device into a
kernel device, a DEV macro was used which implicitly references the device
variable.  This is terrible; introduce separate drbd_err() and similar macros
with an explicit device parameter instead.

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Philipp Reisner

drbd: Introduce "peer_device" object between "device" and "connection"

2014-02-17T15:44:51+00:00

In a setup where a device (aka volume) can replicate to multiple peers and one
connection can be shared between multiple devices, we need separate objects to
represent devices on peer nodes and network connections.

As a first step to introduce multiple connections per device, give each
drbd_device object a single drbd_peer_device object which connects it to a
drbd_connection object.

Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Philipp Reisner