linux-toradex.git/drivers/block/drbd/drbd_main.c, branch v3.9

drbd: convert to idr_alloc()

2013-02-28T03:10:15+00:00

Convert to the much saner new idr interface.

Signed-off-by: Tejun Heo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drbd: Remove obsolete check

2012-12-06T11:09:55+00:00

Smatch complained about it this redundanct check.

The check was introduced in 2006-09-13. On 2007-07-24 the body of the
function was enclosed by get_ldev()/put_ldev() reference counting.
Since then the check is useless and miss leading.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

Merge branch 'drbd-8.4_ed6' into for-3.8-drivers-drbd-8.4_ed6

2012-11-09T13:20:23+00:00

drbd: fix regression: potential NULL pointer dereference

2012-11-09T13:11:42+00:00

recent commit
    drbd: always write bitmap on detach
introduced a bitmap writeout during detach,
which obviously needs some meta data device to write to.

Unfortunately, that same error path may be taken if we fail to attach,
e.g. due to UUID mismatch, after we changed state to D_ATTACHING,
but before the lower level device pointer is even assigned.

We need to test for presence of mdev->ldev.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: always write bitmap on detach

2012-11-09T13:11:41+00:00

If we detach due to local read-error (which sets a bit in the bitmap),
stay Primary, and then re-attach (which re-reads the bitmap from disk),
we potentially lost the "out-of-sync" (or, "bad block") information in
the bitmap.

Always (try to) write out the changed bitmap pages before going diskless.

That way, we don't lose the bit for the bad block,
the next resync will fetch it from the peer, and rewrite
it locally, which may result in block reallocation in some
lower layer (or the hardware), and thereby "heal" the bad blocks.

If the bitmap writeout errors out as well, we will (again: try to)
mark the "we need a full sync" bit in our super block,
if it was a READ error; writes are covered by the activity log already.

If that superblock does not make it to disk either, we are sorry.

Maybe we just lost an entire disk or controller (or iSCSI connection),
and there actually are no bad blocks at all, so we don't need to
re-fetch from the peer, there is no "auto-healing" necessary.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: Call drbd_md_sync() explicitly after a state change on the connection

2012-11-09T13:11:08+00:00

Without this, the meta-data gets updates after 5 seconds by the
md_sync_timer. Better to do it immeditaly after a state change.

If the asender detects a network failure, it may take a bit until
the worker processes the according after-conn-state-change work item.

  The worker might be blocked in sending something, i.e. it
  takes until it gets into its timeout. That is 6 seconds by
  default which is longer than the 5 seconds of the md_sync_timer.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: fix potential list_add corruption

2012-11-09T13:08:21+00:00

If the md_sync_timer triggers a second time,
while the work queued during the first time is still pending,
this could result in list_add() of an already added item,
and corrupt the work item list.

This likely only triggered because of the erroneous
batch-dequeueing of work items fixed with
  drbd: dequeue single work items in wait_for_work()

Still, skip queueing if md_sync_work is already queued.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: Protect accesses to the uuid set with a spinlock

2012-11-09T13:08:04+00:00

There is at least the worker context, the receiver context, the context of
receiving netlink packts.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: disambiguation, s/P_DISCARD_WRITE/P_SUPERSEDED/

2012-11-09T13:05:49+00:00

To avoid confusion with REQ_DISCARD aka TRIM, rename our
"discard concurrent write acks" from P_DISCARD_WRITE to P_SUPERSEDED.

At the same time, rename the drbd request event DISCARD_WRITE
to CONFLICT_RESOLVED. It already triggers both successful completion
or restart of the request, depending on our RQ_POSTPONED flag.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: announce FLUSH/FUA capability to upper layers

2012-11-09T13:05:44+00:00

In 8.4, we may have bios spanning two activity log extents.
Fixup drbd_al_begin_io() and drbd_al_complete_io() to deal with zero sized bios.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg