linux-toradex.git/drivers/block/drbd, branch v3.18.3

drbd: Fix state change in case of connection timeout

2015-01-16T14:59:52+00:00

commit 9581f97a687724ea41cf2e145dda4751161198c1 upstream.

A connection timeout affects all volumes of a resource!
Under the following conditions:

 A resource with multiple volumes
  AND
 ko-count >=1
  AND
 a write request triggers the timeout (ko-count * timeout)

DRBD's internal state gets confused. That in turn may
lead to very miss leading follow up failures. E.g.
"BUG: scheduling while atomic"

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

drbd: merge_bvec_fn: properly remap bvm->bi_bdev

2015-01-16T14:59:52+00:00

commit 3b9d35d744bb5139f9fed57f38c019bb8c7d351c upstream.

This was not noticed for many years. Affects operation if
md raid is used a backing device for DRBD.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

drbd: use RB_DECLARE_CALLBACKS() to define augment callbacks

2014-09-18T15:00:17+00:00

The original code are the same as RB_DECLARE_CALLBACKS().

CC: Michel Lespinasse 
Signed-off-by: Lai Jiangshan 
Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Philipp Reisner 
Signed-off-by: Jens Axboe

drbd: compute the end before rb_insert_augmented()

2014-09-18T15:00:16+00:00

Commit 98683650 "Merge branch 'drbd-8.4_ed6' into
for-3.8-drivers-drbd-8.4_ed6" switches to the new augment API, but the
new API requires that the tree is augmented before rb_insert_augmented()
is called, which is missing.

So we add the augment-code to drbd_insert_interval() when it travels the
tree up to down before rb_insert_augmented().  See the example in
include/linux/interval_tree_generic.h or Documentation/rbtree.txt.

drbd_insert_interval() may cancel the insertion when traveling, in this
case, the just added augment-code does nothing before cancel since the
@this node is already in the subtrees in this case.

CC: Michel Lespinasse 
CC: stable@kernel.org # v3.10+
Signed-off-by: Lai Jiangshan 
Signed-off-by: Andreas Gruenbacher 
Signed-off-by: Philipp Reisner 
Signed-off-by: Jens Axboe

drbd: Add missing newline in resync progress display in /proc/drbd

2014-09-11T14:41:29+00:00

Was broken in 2010 with commit 4b0715f096

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe

drbd: reduce lock contention in drbd_worker

2014-09-11T14:41:29+00:00

The worker may now dequeue work items in batches.
This should reduce lock contention during busy periods.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe

drbd: Improve asender performance

2014-09-11T14:41:29+00:00

Shorten receive path in the asender thread. Reduces CPU utilisation
of asender when receiving packets, and with that increases IOPs.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe

drbd: Get rid of the WORK_PENDING macro

2014-09-11T14:41:29+00:00

This macro doesn't add any value; just use test_bit() instead.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe

drbd: Get rid of the __no_warn and __cond_lock macros

2014-09-11T14:41:29+00:00

These macros can easily be replaced with its definition.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe

drbd: Avoid inconsistent locking warning

2014-09-11T14:41:29+00:00

request_timer_fn() takes resource->req_lock via the device and releases it via
the connection.  Avoid this as it is confusing static code checkers.

Reported-by: "Dan Carpenter" 
Signed-off-by: Andreas Gruenbacher 

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe