linux-toradex.git/drivers/block/drbd, branch v3.9.7

drbd: fix for deadlock when using automatic split-brain-recovery

2013-05-19T18:38:41+00:00

commit 7c689e63a847316c1b2500f86891b0a574ce7e69 upstream.

With an automatic after split-brain recovery policy of
"after-sb-1pri call-pri-lost-after-sb",
when trying to drbd_set_role() to R_SECONDARY,
we run into a deadlock.

This was first recognized and supposedly fixed by
2009-06-10 "Fixed a deadlock when using automatic split brain recovery when both nodes are"
replacing drbd_set_role() with drbd_change_state() in that code-path,
but the first hunk of that patch forgets to remove the drbd_set_role().

We apparently only ever tested the "two primaries" case.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe 
Signed-off-by: Jonghwan Choi 
Signed-off-by: Greg Kroah-Hartman

drbd: fix memory leak

2013-05-19T18:38:41+00:00

commit 94ad0a101415978be04945b2787be1e8e8a874db upstream.

We forgot to free the disk_conf,
so for each attach/detach cycle we leaked 336 bytes.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe 
Signed-off-by: Jonghwan Choi 
Signed-off-by: Greg Kroah-Hartman

drbd: Fix build error when CONFIG_CRYPTO_HMAC is not set

2013-05-19T18:38:41+00:00

commit ef57f9e6bb9278720c8a5278728f252ab85d7ac6 upstream.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg 
Signed-off-by: Jens Axboe 
Signed-off-by: Jonghwan Choi 
Signed-off-by: Greg Kroah-Hartman

drbd: convert to idr_alloc()

2013-02-28T03:10:15+00:00

Convert to the much saner new idr interface.

Signed-off-by: Tejun Heo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drbd: fix potential protocol error and resulting disconnect/reconnect

2013-01-21T21:58:36+00:00

When we notice a disk failure on the receiving side,
we stop sending it new incoming writes.

Depending on exact timing of various events, the same transfer log epoch
could end up containing both replicated (before we noticed the failure)
and local-only requests (after we noticed the failure).

The sanity checks in tl_release(), called when receiving a
P_BARRIER_ACK, check that the ack'ed transfer log epoch matches
the expected epoch, and the number of contained writes matches
the number of ack'ed writes.

In this case, they counted both replicated and local-only writes,
but the peer only acknowledges those it has seen.  We get a mismatch,
resulting in a protocol error and disconnect/reconnect cycle.

Messages logged are
  "BAD! BarrierAck #%u received with n_writes=%u, expected n_writes=%u!\n"

A similar issue can also be triggered when starting a resync while
having a healthy replication link, by invalidating one side, forcing a
full sync, or attaching to a diskless node.

Fix this by closing the current epoch if the state changes in a way
that would cause the replication intent of the next write.

Epochs now contain either only non-replicated,
or only replicated writes.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: update Kconfig to match current dependencies

2012-12-06T12:08:29+00:00

We no longer need the connector.
But we need libcrc32c.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: Fix drbdsetup wait-connect, wait-sync etc... commands

2012-12-06T12:04:34+00:00

This was introduces when moving the code over from the 8.3 codebase
with commit 328e0f125bf41f4f33f684db22015f92cb44fe56

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: close race between drbd_set_role and drbd_connect

2012-12-06T12:00:33+00:00

drbd_set_role(, R_PRIMARY, ) does the state change to Primary,
some more housekeeping, and possibly generates a new UUID set.

All of this holding the "state_mutex".

The connection handshake involves sending of various state information,
including the current data generation UUID set, and two connection
state changes from C_WF_CONNECTION to C_WF_REPORT_PARAMS further to
a number of different outcomes, resync being one of them.

If the connection handshake happens between the state change to Primary
and the generation of the new UUIDs, the resync decision based on the
old UUID set may be confused, depending on circumstances.

Make sure that, before we do the handshake, any promotion to Primary
role will either be complete (including the housekeeping stuff), or can
see, and serialize with, the ongoing handshake, based on the
"STATE_SENT" bit, which is set when we start the handshake, and cleared
only when we leave C_WF_REPORT_PARAMS again.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: respect no-md-barriers setting also when changed online via disk-options

2012-12-06T12:00:04+00:00

We need to propagate the configuration into the flag bits,
or it won't be effective.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg

drbd: Remove obsolete check

2012-12-06T11:09:55+00:00

Smatch complained about it this redundanct check.

The check was introduced in 2006-09-13. On 2007-07-24 the body of the
function was enclosed by get_ldev()/put_ldev() reference counting.
Since then the check is useless and miss leading.

Signed-off-by: Philipp Reisner 
Signed-off-by: Lars Ellenberg