linux-toradex.git/drivers/block/nbd.c, branch v4.14-rc3

nbd: ignore non-nbd ioctl's

2017-09-25T14:56:05+00:00

In testing we noticed that nbd would spew if you ran a fio job against
the raw device itself.  This is because fio calls a block device
specific ioctl, however the block layer will first pass this back to the
driver ioctl handler in case the driver wants to do something special.
Since the device was setup using netlink this caused us to spew every
time fio called this ioctl.  Since we don't have special handling, just
error out for any non-nbd specific ioctl's that come in.  This fixes the
spew.

Signed-off-by: Josef Bacik 
Signed-off-by: Jens Axboe

nbd: make device_attribute const

2017-08-28T21:21:27+00:00

Make this const as is is only passed as an argument to the
function device_create_file and device_remove_file and the corresponding
arguments are of type const.
Done using Coccinelle

Signed-off-by: Bhumika Goyal 
Signed-off-by: Jens Axboe

nbd: change the default nbd partitions

2017-08-17T17:02:59+00:00

There's no reason to have partitions disabled for nbd by default, it costs us
nothing to have it enabled and is just confusing/obnoxious to users who try to
use partitions with nbd.

Signed-off-by: Josef Bacik 
Signed-off-by: Jens Axboe

nbd: allow device creation at a specific index

2017-08-17T17:02:57+00:00

If users really want to use a particular index for their nbd device and it
doesn't already exist there's no reason we can't just create it for them.  Do
this instead of erroring out.

Signed-off-by: Josef Bacik 
Signed-off-by: Jens Axboe

nbd: clear disconnected on reconnect

2017-07-25T19:58:34+00:00

If our device loses its connection for longer than the dead timeout we
will set NBD_DISCONNECTED in order to quickly fail any pending IO's that
flood in after the IO's that were waiting during the dead timer.
However if we re-connect at some point in the future we'll still see
this DISCONNECTED flag set if we then lose our connection again after
that, which means we won't get notifications for our newly lost
connections.  Fix this by just clearing the DISCONNECTED flag on
reconnect in order to make sure everything works as it's supposed to.

Reported-by: Dan Melnic 
Signed-off-by: Josef Bacik 
Signed-off-by: Jens Axboe

nbd: only set sndtimeo if we have a timeout set

2017-07-22T17:12:32+00:00

A user reported that he was getting immediate disconnects with my
sndtimeo patch applied.  This is because by default the OSS nbd client
doesn't set a timeout, so we end up setting the sndtimeo to 0, which of
course means we have send errors a lot.  Instead only set our sndtimeo
if the user specified a timeout, otherwise we'll just wait forever like
we did previously.

Fixes: dc88e34d69d8 ("nbd: set sk->sk_sndtimeo for our sockets")
Reported-by: Adam Borowski 
Signed-off-by: Josef Bacik 
Signed-off-by: Jens Axboe

nbd: take tx_lock before disconnecting

2017-07-22T17:12:31+00:00

We need to take the tx_lock so we don't interleave our disconnect
request between real data going down the wire.

Signed-off-by: Josef Bacik 
Signed-off-by: Jens Axboe

nbd: allow multiple disconnects to be sent

2017-07-22T17:12:29+00:00

There's no reason to limit ourselves to one disconnect message per
socket.  Sometimes networks do strange things, might as well let
sysadmins hit the panic button as much as they want.

Signed-off-by: Josef Bacik 
Signed-off-by: Jens Axboe

nbd: kill unused ret in recv_work

2017-07-13T14:03:30+00:00

No need to return value in queue work, kill ret variable.

Signed-off-by: Kefeng Wang 
Signed-off-by: Jens Axboe

nbd: quiesce request queues to make sure no submissions are inflight

2017-07-06T06:49:05+00:00

Unlike blk_mq_stop_hw_queues, blk_mq_quiesce_queue respects the
submission path rcu grace. quiesce the queue before iterating
on live tags.

Reviewed-by: Ming Lei 
Acked-by: Josef Bacik 
Signed-off-by: Sagi Grimberg