linux-toradex.git/drivers/block/nvme-core.c, branch v3.10.78

NVMe: Add MSI support

2013-05-31T15:45:52+00:00

Some devices only have support for MSI, not MSI-X.  While MSI is more
limited, it still provides better performance than line-based interrupts.

Signed-off-by: Ramachandra Gajula 
Signed-off-by: Matthew Wilcox

NVMe: Use dma_set_mask() correctly

2013-05-28T20:46:46+00:00

In some circumstances setting a 64-bit DMA mask can fail, as explained
in Documentation/DMA-API-HOWTO.txt.  Use the recommended code sequence
to set a 32-bit DMA mask if setting a 64-bit DMA mask fails.

Reported-by: Chayan Biswas 
Signed-off-by: Matthew Wilcox

Return the result from user admin command IOCTL even in case of failure

2013-05-23T17:38:59+00:00

We copy the result to user if the command is completed from the
controller even if it completes with failure (non-zero) status.
A return status of < 0 indicates the command was not completed
by the controller. The user application may expect the error code
in the result field in case of failure.

Signed-off-by: Chayan Biswas 
Signed-off-by: Matthew Wilcox

NVMe: Do not cancel command multiple times

2013-05-17T13:18:38+00:00

Cancelling an already cancelled command does not do anything, so check
the command context before cancelling it, continuing if had already been
cancelled so we do not log the same problem every second if a device
stops responding.

Signed-off-by: Keith Busch 
Signed-off-by: Matthew Wilcox

NVMe: fix error return code in nvme_submit_bio_queue()

2013-05-17T13:13:18+00:00

nvme_submit_flush_data() might overwrite the initialisation of the
return value with 0, so move the -ENOMEM setting close to the usage.

Signed-off-by: Wei Yongjun 
Signed-off-by: Matthew Wilcox

NVMe: check for integer overflow in nvme_map_user_pages()

2013-05-17T13:11:03+00:00

You need to have CAP_SYS_ADMIN to trigger this overflow but it makes the
static checkers complain so we should fix it.  The worry is that
"length" comes from copy_from_user() so we need to check that "length +
offset" can't overflow.

I also changed the min_t() cast to be unsigned instead of signed.  Now
that we cap "length" to INT_MAX it doesn't make a difference, but it's a
little easier for reviewers to know that large values aren't cast to
negative.

Signed-off-by: Dan Carpenter 
Signed-off-by: Matthew Wilcox

NVMe: Use user defined admin ioctl timeout

2013-05-09T20:03:50+00:00

Signed-off-by: Keith Busch 
Signed-off-by: Matthew Wilcox

NVMe: Only clear the enable bit when disabling controller

2013-05-08T13:54:31+00:00

Many of the bits in the Controller Configuration register may only be
modified when the Enable bit is clear.  Clearing them at the same time
as the Enable bit might be OK, but let's play it safe and only touch the
Enable bit.

Signed-off-by: Matthew Wilcox 
Reviewed-by: Keith Busch

NVMe: Wait for device to acknowledge shutdown

2013-05-08T13:53:49+00:00

A recent update to the specification makes it clear that the host
is expected to wait for the device to acknowledge the Enable bit
transitioning to 0 as well as waiting for the device to acknowledge a
transition to 1.

Reported-by: Khosrow Panah 
Signed-off-by: Matthew Wilcox 
Reviewed-by: Keith Busch

NVMe: Schedule timeout for sync commands

2013-05-02T19:36:02+00:00

Schedule a timeout on sync commands in case the command times out and
the device is not being polled for timeouts. This prevents device removal
from hanging forever if the device has stopped responding.

Signed-off-by: Keith Busch 
Signed-off-by: Matthew Wilcox