linux-toradex.git/drivers/block/pktcdvd.c, branch v5.10-rc2

pktcdvd: use blkdev_get_by_dev instead of open coding it

2020-09-23T16:43:19+00:00

Replace bdget + blkdev_get by blkdev_get_by_dev.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

pktcdvd: remove the if 0'ed pkt_start_recovery function

2020-09-23T16:43:19+00:00

Remove code which has been dead since the initial commit.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: replace bd_set_size with bd_set_nr_sectors

2020-09-01T22:49:25+00:00

Replace bd_set_size with a version that takes the number of sectors
instead, as that fits most of the current and future callers much better.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Jens Axboe

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

block: rename generic_make_request to submit_bio_noacct

2020-07-01T13:27:24+00:00

generic_make_request has always been very confusingly misnamed, so rename
it to submit_bio_noacct to make it clear that it is submit_bio minus
accounting and a few checks.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: move ->make_request_fn to struct block_device_operations

2020-07-01T13:27:24+00:00

The make_request_fn is a little weird in that it sits directly in
struct request_queue instead of an operation vector.  Replace it with
a block_device_operations method called submit_bio (which describes much
better what it does).  Also remove the request_queue argument to it, as
the queue can be derived pretty trivially from the bio.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove the request_queue argument from blk_queue_split

2020-07-01T13:27:23+00:00

The queue can be trivially derived from the bio, so pass one less
argument.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

pktcdvd: remove redundant initialization of variable ret

2020-06-11T15:15:48+00:00

The variable ret is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Signed-off-by: Colin Ian King 
Addresses-Coverity: ("Unused value")
Signed-off-by: Jens Axboe

block: simplify queue allocation

2020-03-27T16:23:43+00:00

Current make_request based drivers use either blk_alloc_queue_node or
blk_alloc_queue to allocate a queue, and then set up the make_request_fn
function pointer and a few parameters using the blk_queue_make_request
helper.  Simplify this by passing the make_request pointer to
blk_alloc_queue, and while at it merge the _node variant into the main
helper by always passing a node_id, and remove the superfluous gfp_mask
parameter.  A lower-level __blk_alloc_queue is kept for the blk-mq case.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: move the ->devnode callback to struct block_device_operations

2020-03-27T15:50:05+00:00

There really isn't any good reason to stash a method directly into
struct gendisk.  Move it together with the other block device
operations.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe