linux-toradex.git/drivers/block/rnbd/rnbd-srv-sysfs.c, branch v6.6-rc5

block/rnbd: make all 'class' structures const

2023-06-21T13:45:19+00:00

Now that the driver core allows for struct class to be in read-only
memory, making all 'class' structures to be declared at build time
placing them into read-only memory, instead of having to be dynamically
allocated at load time.

Cc: "Md. Haris Iqbal" 
Cc: Jack Wang 
Cc: Jens Axboe 
Cc: linux-block@vger.kernel.org
Suggested-by: Greg Kroah-Hartman 
Signed-off-by: Ivan Orlov 
Signed-off-by: Greg Kroah-Hartman 
Acked-by: Jack Wang 
Link: https://lore.kernel.org/r/20230620180129.645646-5-gregkh@linuxfoundation.org
Signed-off-by: Jens Axboe

rnbd-srv: replace sess->open_flags with a "bool readonly"

2023-06-12T14:04:04+00:00

Stop passing the fmode_t around and just use a simple bool to track if
an export is read-only.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Hannes Reinecke 
Acked-by: Christian Brauner 
Acked-by: Jack Wang 
Link: https://lore.kernel.org/r/20230608110258.189493-24-hch@lst.de
Signed-off-by: Jens Axboe

block/rnbd: introduce rnbd_access_modes

2023-06-12T01:48:42+00:00

Add one new array (marked with __maybe_unused to prevent gcc warning about
"defined but not used" with W=1), then we can remove rnbd_access_mode_str
and rnbd-common.c accordingly.

Signed-off-by: Guoqing Jiang 
Acked-by: Jack Wang 
Link: https://lore.kernel.org/r/20230524070026.2932-4-guoqing.jiang@linux.dev
Signed-off-by: Jens Axboe

block/rnbd-srv: remove unused header

2023-06-12T01:48:42+00:00

No need to include it since none of macros in limits.h are
used by rnbd-srv.

Acked-by: Jack Wang 
Signed-off-by: Guoqing Jiang 
Link: https://lore.kernel.org/r/20230524070026.2932-3-guoqing.jiang@linux.dev
Signed-off-by: Jens Axboe

driver core: class: remove module * from class_create()

2023-03-17T14:16:33+00:00

The module pointer in class_create() never actually did anything, and it
shouldn't have been requred to be set as a parameter even if it did
something.  So just remove it and fix up all callers of the function in
the kernel tree at the same time.

Cc: "Rafael J. Wysocki" 
Acked-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20230313181843.1207845-4-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

rnbd-srv: remove the name field from struct rnbd_dev

2022-07-14T16:27:56+00:00

Just print the block device name directly using the %pg format specifier.

Signed-off-by: Christoph Hellwig 
Acked-by: Jack Wang 
Reviewed-by: Jan Kara 
Reviewed-by: Chaitanya Kulkarni 
Reviewed-by: Johannes Thumshirn 
Link: https://lore.kernel.org/r/20220713055317.1888500-7-hch@lst.de
Signed-off-by: Jens Axboe

block: remove genhd.h

2022-02-02T14:49:59+00:00

There is no good reason to keep genhd.h separate from the main blkdev.h
header that includes it.  So fold the contents of genhd.h into blkdev.h
and remove genhd.h entirely.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Chaitanya Kulkarni 
Reviewed-by: Martin K. Petersen 
Link: https://lore.kernel.org/r/20220124093913.742411-4-hch@lst.de
Signed-off-by: Jens Axboe

block/rnbd: Use sysfs_emit instead of s*printf function for sysfs show

2021-08-02T19:37:40+00:00

sysfs_emit function was added to be aware of the PAGE_SIZE maximum of
the temporary buffer used for outputting sysfs content, so there is no
possible overruns. So replace the uses of any s*printf functions for
the sysfs show functions with sysfs_emit.

Signed-off-by: Md Haris Iqbal 
Signed-off-by: Jack Wang 
Link: https://lore.kernel.org/r/20210726115950.470543-3-jinpu.wang@ionos.com
Signed-off-by: Jens Axboe

block/rnbd-srv: Remove force_close file after holding a lock

2021-04-20T14:59:04+00:00

We changed the rnbd_srv_sess_dev_force_close to use try-lock
because rnbd_srv_sess_dev_force_close and process_msg_close
can generate a deadlock.

Now rnbd_srv_sess_dev_force_close would do nothing
if it fails to get the lock. So removing the force_close
file should be moved to after the lock. Or the force_close
file is removed but the others are not removed.

Signed-off-by: Gioh Kim 
Signed-off-by: Md Haris Iqbal 
Signed-off-by: Jack Wang 
Link: https://lore.kernel.org/r/20210419073722.15351-11-gi-oh.kim@ionos.com
Signed-off-by: Jens Axboe

block/rnbd: call kobject_put in the failure path

2020-12-04T16:41:10+00:00

Per the comment of kobject_init_and_add, we need to cleanup the memory
by call kobject_put.

Also we need to call kobject_del for the other failure cases if the
kobject_init_and_add doesn't fail.

Signed-off-by: Guoqing Jiang 
Signed-off-by: Jack Wang 
Reviewed-by: Md Haris Iqbal 
Signed-off-by: Jens Axboe