linux-toradex.git/drivers/block/skd_main.c, branch v3.13

drivers: block: Mark the functions as static in skd_main.c

2013-12-19T15:06:49+00:00

Mark functions skd_skmsg_state_to_str() and skd_skreq_state_to_str() as
static in skd_main.c because they are not used outside this file.

This eliminates the following warnings in skd_main.c:
drivers/block/skd_main.c:5272:13: warning: no previous prototype for ‘skd_skmsg_state_to_str’ [-Wmissing-prototypes]
drivers/block/skd_main.c:5284:13: warning: no previous prototype for ‘skd_skreq_state_to_str’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria 
Reviewed-by: Josh Triplett 
Signed-off-by: Jens Axboe

skd: reorder construct/destruct code

2013-11-08T16:10:30+00:00

Reorder placement of skd_construct(), skd_cons_sg_list(), skd_destruct()
and skd_free_sg_list() functions. Then remove no longer needed function
prototypes.

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: cleanup skd_do_inq_page_da()

2013-11-08T16:10:30+00:00

skdev->pdev and skdev->pdev->bus are always different than NULL in
skd_do_inq_page_da() so simplify the code accordingly.

Also cache skdev->pdev value in pdev variable while at it.

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: remove redundant skdev->pdev assignment from skd_pci_probe()

2013-11-08T16:10:30+00:00

skdev->pdev is set to pdev twice in skd_pci_probe(), first time
through skd_construct() call and the second time directly in
the function. Remove the second assignment as it is not needed.

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: use

2013-11-08T16:10:30+00:00

Use  instead of .

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: remove SCSI subsystem specific includes

2013-11-08T16:10:30+00:00

This is not a SCSI host driver so remove SCSI subsystem specific
includes.

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: register block device only if some devices are present

2013-11-08T16:10:30+00:00

Register block device in skd_pci_probe() instead of in skd_init() so it
is registered only if some devices are present (currently it is always
registered when the driver is loaded). Please note that this change
depends on the fact that register_blkdev(0, ...) never returns 0.

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: fix error messages in skd_init()

2013-11-08T16:10:30+00:00

* change priority level from KERN_INFO to KERN_ERR
* add "skd: " prefix
* do minor CodingStyle fixes

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: fix error paths in skd_init()

2013-11-08T16:10:30+00:00

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe

skd: fix unregister_blkdev() placement

2013-11-08T16:10:29+00:00

register_blkdev() is called before pci_register_driver() in skd_init()
so unregister_blkdev() should be called after pci_unregister_driver()
in skd_exit(). Fix it.

Cc: Akhil Bhansali 
Cc: Jeff Moyer 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Kyungmin Park 
Signed-off-by: Jens Axboe