linux-toradex.git/drivers/block/ub.c, branch v2.6.29

USB: change interface to usb_lock_device_for_reset()

2009-01-07T17:59:52+00:00

This patch (as1161) changes the interface to
usb_lock_device_for_reset().  The existing interface is apparently not
very clear, judging from the fact that several of its callers don't
use it correctly.  The new interface always returns 0 for success and
it always requires the caller to unlock the device afterward.

The new routine will not return immediately if it is called while the
driver's probe method is running.  Instead it will wait until the
probe is over and the device has been unlocked.  This shouldn't cause
any problems; I don't know of any cases where drivers call
usb_lock_device_for_reset() during probe.

Signed-off-by: Alan Stern 
Cc: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

ub: stub pre_reset and post_reset to fix oops

2008-11-13T22:45:04+00:00

Due to recent changes to usb_reset_device, the following hang occurs:

events/0      D 0000000000000000     0     6      2
 ffff880037477cc0 0000000000000046 ffff880037477c50 ffffffff80237434
 ffffffff80574c80 00000001000a015c 0000000000000286 ffff8800374757d0
 ffff88002a31c860 ffff880037475a00 0000000036779140 ffff880037475a00
Call Trace:
 [] try_to_del_timer_sync+0x52/0x5b
 [] dma_pool_free+0x1a7/0x1ec
 [] ub_disconnect+0x8e/0x1ad [ub]
 [] autoremove_wake_function+0x0/0x2e
 [] usb_unbind_interface+0x5c/0xb7
 [] __device_release_driver+0x95/0xbd
 [] device_release_driver+0x21/0x2d
 [] usb_driver_release_interface+0x44/0x83
 [] usb_forced_unbind_intf+0x17/0x1d
 [] usb_reset_device+0x7d/0x114
 [] ub_reset_task+0x0/0x293 [ub]
 [] ub_reset_task+0x1c4/0x293 [ub]
 [] flush_to_ldisc+0x0/0x1cd
 [] ub_reset_task+0x0/0x293 [ub]
 [] run_workqueue+0x87/0x114
 [] worker_thread+0xd8/0xe7
 [] autoremove_wake_function+0x0/0x2e
 [] worker_thread+0x0/0xe7
 [] kthread+0x47/0x73
 [] schedule_tail+0x27/0x60
 [] child_rip+0xa/0x11
 [] kthread+0x0/0x73
 [] child_rip+0x0/0x11

This is because usb_reset_device now unbinds, and that calls disconnect,
which in case of ub waits until the reset completes... which deadlocks.
Worse, this deadlocks keventd and this takes whole box down.

I'm going to fix this properly later, but let's unbreak the driver
quickly for non-composite devices at least.

Signed-off-by: Pete Zaitcev 
Cc: Alan Stern 
Signed-off-by: Greg Kroah-Hartman

[PATCH] switch ub

2008-10-21T11:48:05+00:00

Signed-off-by: Al Viro

[PATCH] beginning of methods conversion

2008-10-21T11:47:32+00:00

To keep the size of changesets sane we split the switch by drivers;
to keep the damn thing bisectable we do the following:
	1) rename the affected methods, add ones with correct
prototypes, make (few) callers handle both.  That's this changeset.
	2) for each driver convert to new methods.  *ALL* drivers
are converted in this series.
	3) kill the old (renamed) methods.

Note that it _is_ a flagday; all in-tree drivers are converted and by the
end of this series no trace of old methods remain.  The only reason why
we do that this way is to keep the damn thing bisectable and allow per-driver
debugging if anything goes wrong.

New methods:
	open(bdev, mode)
	release(disk, mode)
	ioctl(bdev, mode, cmd, arg)		/* Called without BKL */
	compat_ioctl(bdev, mode, cmd, arg)
	locked_ioctl(bdev, mode, cmd, arg)	/* Called with BKL, legacy */

Signed-off-by: Al Viro

[PATCH] switch scsi_cmd_ioctl() to passing fmode_t

2008-10-21T11:47:14+00:00

Signed-off-by: Al Viro

[PATCH] eliminate use of ->f_flags in block methods

2008-10-21T11:47:08+00:00

store needed information in f_mode

Signed-off-by: Al Viro

ub: remove sg_stat

2008-10-17T21:40:52+00:00

Remove forgotten code related to sg_stat[].

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

ub: Cosmetics

2008-05-02T17:25:52+00:00

Fix a few comments and printk statements.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

ub: Ignore bad residue

2008-05-02T17:25:52+00:00

I hoped to continue to ignore this problem or use libusual, but these
days it's simpler to work around than to deal with it. Let's attempt to
use bad residue devices and hope that upper level integrity checks catch
any problems (e.g. please use sha1sum on your backups).

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

ub: Tune retries

2008-05-02T17:25:52+00:00

Make ub to fail faster in hopeless cases.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman