linux-toradex.git/drivers/block/virtio_blk.c, branch tegra-12r3

virtio-blk: fix request leak.

2010-10-09T18:42:37+00:00

Must drop reference taken by blk_make_request().

Signed-off-by: Mike Snitzer 
Signed-off-by: Rusty Russell 
Cc: stable@kernel.org # .35.x
Signed-off-by: Linus Torvalds

Merge branch 'for-2.6.36' of git://git.kernel.dk/linux-2.6-block

2010-08-10T22:22:42+00:00

* 'for-2.6.36' of git://git.kernel.dk/linux-2.6-block: (149 commits)
  block: make sure that REQ_* types are seen even with CONFIG_BLOCK=n
  xen-blkfront: fix missing out label
  blkdev: fix blkdev_issue_zeroout return value
  block: update request stacking methods to support discards
  block: fix missing export of blk_types.h
  writeback: fix bad _bh spinlock nesting
  drbd: revert "delay probes", feature is being re-implemented differently
  drbd: Initialize all members of sync_conf to their defaults [Bugz 315]
  drbd: Disable delay probes for the upcomming release
  writeback: cleanup bdi_register
  writeback: add new tracepoints
  writeback: remove unnecessary init_timer call
  writeback: optimize periodic bdi thread wakeups
  writeback: prevent unnecessary bdi threads wakeups
  writeback: move bdi threads exiting logic to the forker thread
  writeback: restructure bdi forker loop a little
  writeback: move last_active to bdi
  writeback: do not remove bdi from bdi_list
  writeback: simplify bdi code a little
  writeback: do not lose wake-ups in bdi threads
  ...

Fixed up pretty trivial conflicts in drivers/block/virtio_blk.c and
drivers/scsi/scsi_error.c as per Jens.

block: push down BKL into .locked_ioctl

2010-08-07T16:25:00+00:00

As a preparation for the removal of the big kernel
lock in the block layer, this removes the BKL
from the common ioctl handling code, moving it
into every single driver still using it.

Signed-off-by: Arnd Bergmann 
Acked-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block: remove q->prepare_flush_fn completely

2010-08-07T16:24:15+00:00

This removes q->prepare_flush_fn completely (changes the
blk_queue_ordered API).

Signed-off-by: FUJITA Tomonori 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

virtio_blk: stop using q->prepare_flush_fn

2010-08-07T16:24:14+00:00

use REQ_FLUSH flag instead.

Signed-off-by: FUJITA Tomonori 
Cc: Rusty Russell 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

virtio_blk: add default case to cmd type switch

2010-08-07T16:22:26+00:00

On compilation, gcc correctly detects that we do not handle
all types:

In function ‘blk_done’:
warning: enumeration value ‘REQ_TYPE_FS’ not handled in switch
warning: enumeration value ‘REQ_TYPE_SENSE’ not handled in switch
warning: enumeration value ‘REQ_TYPE_PM_SUSPEND’ not handled in switch
warning: enumeration value ‘REQ_TYPE_PM_RESUME’ not handled in switch
warning: enumeration value ‘REQ_TYPE_PM_SHUTDOWN’ not handled in switch
warning: enumeration value ‘REQ_TYPE_LINUX_BLOCK’ not handled in switch
warning: enumeration value ‘REQ_TYPE_ATA_TASKFILE’ not handled in switch
warning: enumeration value ‘REQ_TYPE_ATA_PC’ not handled in switch

which is a bit pointless since this is at the end of the request
processessing. Add a default case that just breaks out.

Signed-off-by: Jens Axboe

block: remove wrappers for request type/flags

2010-08-07T16:17:56+00:00

Remove all the trivial wrappers for the cmd_type and cmd_flags fields in
struct requests.  This allows much easier grepping for different request
types instead of unwinding through macros.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

virtio_blk: Remove VBID ioctl

2010-08-05T03:35:31+00:00

With the availablility of a sysfs device attribute for examining disk serial
numbers the ioctl is no longer needed.  The user-space changes for this aren't
upstream yet so we don't have any users to worry about.

Signed-off-by: Ryan Harper 
Signed-off-by: Rusty Russell

virtio_blk: Add 'serial' attribute to virtio-blk devices (v2)

2010-08-05T03:35:30+00:00

Create a new attribute for virtio-blk devices that will fetch the serial number
of the block device.  This attribute can be used by udev to create disk/by-id
symlinks for devices that don't have a UUID (filesystem) associated with them.

ATA_IDENTIFY strings are special in that they can be up to 20 chars long
and aren't required to be nul-terminated.  The buffer is also zero-padded
meaning that if the serial is 19 chars or less that we get a nul-terminated
string.  When copying this value into a string buffer, we must be careful to
copy up to the nul (if it present) and only 20 if it is longer and not to
attempt to nul terminate; this isn't needed.

Changes since v1:
- Added BUILD_BUG_ON() for PAGE_SIZE check
- Removed min() since BUILD_BUG_ON() handles the check
- Replaced serial_sysfs() by copying id directly to buffer

Signed-off-by: Ryan Harper 
Signed-off-by: john cooper 
Signed-off-by: Rusty Russell

virtio_blk: support barriers without FLUSH feature

2010-08-05T03:35:29+00:00

If we want to support barriers with the cache=writethrough mode in qemu
we need to tell the block layer that we only need queue drains to
implement a barrier.  Follow the model set by SCSI and IDE and assume
that there is no volatile write cache if the host doesn't advertize it.
While this might imply working barriers on old qemu versions or other
hypervisors that actually have a volatile write cache this is only a
cosmetic issue - these hypervisors don't guarantee any data integrity
with or without this patch, but with the patch we at least provide
data ordering.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Rusty Russell