linux-toradex.git/drivers/block, branch v2.6.16.23

[PATCH] USB: ub oops in block_uevent

2006-05-20T22:00:28+00:00

In kernel 2.6.16, if a mounted storage device is removed, an oops happens
because ub supplies an interface device (and kobject) to the block layer,
but neglects to pin it. And apparently, the block layer expects its users
to pin device structures.

The code in ub was broken this way for years. But the bug was exposed only
by 2.6.16 when it started to call block_uevent on close, which traverses
device structures (kobjects actually).

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman 
Signed-off-by: Chris Wright

[PATCH] cciss: bug fix for crash when running hpacucli

2006-04-17T20:16:05+00:00

Fix a crash when running hpacucli with multiple logical volumes on a cciss
controller.  We were not properly initializing the disk->queue and causing
a fault.

Thanks to Hasso Tepper for reporting the problem.  Thanks to Steve Cameron
for root causing the problem.  Most of the patch just moves things around.
The fix is a one-liner.

Signed-off-by: Mike Miller 
Signed-off-by: Stephen Cameron 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

[PATCH] cciss: fix use-after-free in cciss_init_one

2006-03-28T06:47:31+00:00

free_hba() sets hba[i] to NULL, the dereference afterwards results in this
crash.  Setting busy_initializing to 0 actually looks unnecessary, but I'm
not entirely sure, which is why I left it in.

cciss: controller appears to be disabled
Unable to handle kernel NULL pointer dereference at virtual address 00000370
 printing eip:
c1114d53
*pde = 00000000
Oops: 0002 [#1]
Modules linked in:
CPU:    0
EIP:    0060:[]    Not tainted VLI
EFLAGS: 00010286   (2.6.16 #1)
EIP is at cciss_init_one+0x4e9/0x4fe
eax: 00000000   ebx: c132cd60   ecx: c13154e4   edx: c27d3c00
esi: 00000000   edi: c2748800   ebp: c2536ee4   esp: c2536eb8
ds: 007b   es: 007b   ss: 0068
Process swapper (pid: 1, threadinfo=c2536000 task=c2535a30)
Stack: <0>00000000 00000000 00000000 c13fdba0 c2536ee8 c13159c0 c2536f38
f7c74740
       c132cd60 c132cd60 ffffffed c2536ef0 c10c1d51 c2748800 c2536f04
c10c1d85
       c132cd60 c2748800 c132cd8c c2536f14 c10c1db8 c2748848 00000000
c2536f28
Call Trace:
 [] show_stack_log_lvl+0xa8/0xb0
 [] show_registers+0x102/0x16a
 [] die+0xc1/0x13c
 [] do_page_fault+0x38a/0x525
 [] error_code+0x4f/0x54
 [] pci_call_probe+0xd/0x10
 [] __pci_device_probe+0x31/0x43
 [] pci_device_probe+0x21/0x34
 [] driver_probe_device+0x44/0x99
 [] __driver_attach+0x39/0x5d
 [] bus_for_each_dev+0x35/0x5a
 [] driver_attach+0x14/0x16
 [] bus_add_driver+0x5c/0x8f
 [] driver_register+0x73/0x78
 [] __pci_register_driver+0x5f/0x71
 [] cciss_init+0x1a/0x1c
 [] do_initcalls+0x4c/0x96
 [] do_basic_setup+0x1c/0x1e
 [] init+0x35/0x118
 [] kernel_thread_helper+0x5/0xb
Code: 04 b5 e0 de 40 c1 8d 50 04 8b 40 34 e8 3f b7 f9 ff 8b 04 b5 e0 de
40 c1 e8 aa f3 ff ff 89 f0 e8 e8 fa ff ff 8b 04 b5 e0 de 40 c1  80
70 03 00 00 00 00 00 00 83 c8 ff 8d 65 f4 5b 5e 5f 5d c3
 <0>Kernel panic - not syncing: Attempted to kill init!

Signed-off-by: Patrick McHardy 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Chris Wright 
Signed-off-by: Greg Kroah-Hartman

[PATCH] dac960: add disk entropy in request completions

2006-03-08T22:15:04+00:00

Signed-off-by: Matt Mackall 
Tested-by: Anders K. Pedersen 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pktcdvd: Only return -EROFS when appropriate

2006-02-21T04:00:11+00:00

When attempting to open the device for writing, only return -EROFS if the disc
appears to be readable but not writable.

Signed-off-by: Peter Osterlund 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pktcdvd: Fix the logic in the pkt_writable_track function

2006-02-21T04:00:10+00:00

Fix the pkt_writable_track() function to make it work correctly for all types
of CD/DVD discs.

Signed-off-by: Peter Osterlund 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pktcdvd: Remove useless printk statements

2006-02-21T04:00:10+00:00

Writing the detected disc type in the kernel log is not useful during normal
use of the driver, so remove the printk statements.

Signed-off-by: Peter Osterlund 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pktcdvd: Rename functions and make their return values sane

2006-02-21T04:00:10+00:00

Boolean functions should return non-zero when they mean "true", otherwise the
calling code looks weird.  (As suggested by Linus.)

Signed-off-by: Peter Osterlund 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pktcdvd: Correctly set rq->cmd_len in pkt_generic_packet()

2006-02-21T04:00:10+00:00

It looks like the code in pkt_generic_packet() worked by luck in the past, but
after commit 186d330e682210100c671355580a8592e4a21692 leaving rq->cmd_len
uninitialized doesn't work any more.

Signed-off-by: Peter Osterlund 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] pktcdvd: Reduce stack usage

2006-02-15T00:09:33+00:00

Reduce stack usage in the pkt_start_write() function.  Even though it's not
currently a real problem, the pages and offsets arrays can be eliminated,
which saves approximately 1000 bytes of stack space.

Signed-off-by: Peter Osterlund 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds