linux-toradex.git/drivers/bluetooth/bpa10x.c, branch v3.4.9

Bluetooth: Remove hci_dev->driver_data

2012-02-13T15:01:37+00:00

The linux device model provides dev_set/get_drvdata so we can use this
to save private driver data.
This also removes several unnecessary casts.

Signed-off-by: David Herrmann 
Acked-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Remove HCI-owner field

2012-02-13T15:01:24+00:00

After unregistering an hci_dev object a bluetooth driver does not have
any callbacks in the hci_dev structure left over. Therefore, there is no
need to keep a reference to the module.

Previously, we needed this to protect the hci-destruct callback.
However, this callback is no longer available so we do not need this
owner field, anymore.  Drivers now call hci_unregister_dev() and they
are done with the object.

Signed-off-by: David Herrmann 
Acked-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: bpa10x: Free private driver data on usb shutdown

2012-02-13T15:01:24+00:00

Instead of waiting for the hci-device to be destroyed we now free the
private driver data on driver shutdown right away. We call
hci_unregister_dev() on driver shutdown, that means, the hci-core will
never ever call our callbacks again except the destruct callback. It
also does not access hdev->driver_data so there is no reason to keep
that alive. We simply set the destruct cb to NULL to avoid getting
called again.

Signed-off-by: David Herrmann 
Acked-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

USB: convert drivers/bluetooth/* to use module_usb_driver()

2011-11-18T17:47:34+00:00

This converts the drivers in drivers/bluetooth/* to use the
module_usb_driver() macro which makes the code smaller and a bit
simpler.

Added bonus is that it removes some unneeded kernel log messages about
drivers loading and/or unloading.

Cc: Marcel Holtmann 
Cc: "Gustavo F. Padovan" 
Signed-off-by: Greg Kroah-Hartman

Bluetooth: Use __packed annotation for drivers

2010-07-21T17:39:13+00:00

Use the __packed annotation instead of the __attribute__((packed)).

Signed-off-by: Gustavo F. Padovan 
Signed-off-by: Marcel Holtmann

Bluetooth: Convert controller hdev->type to hdev->bus

2010-02-27T13:05:38+00:00

The hdev->type is misnamed and should be actually hdev->bus instead. So
convert it now.

Signed-off-by: Marcel Holtmann

Bluetooth: Enable per-module dynamic debug messages

2008-11-30T11:17:28+00:00

With the introduction of CONFIG_DYNAMIC_PRINTK_DEBUG it is possible to
allow debugging without having to recompile the kernel. This patch turns
all BT_DBG() calls into pr_debug() to support dynamic debug messages.

As a side effect all CONFIG_BT_*_DEBUG statements are now removed and
some broken debug entries have been fixed.

Signed-off-by: Marcel Holtmann

Bluetooth: Send HCI Reset command by default on device initialization

2008-11-30T11:17:26+00:00

The Bluetooth subsystem was not using the HCI Reset command when doing
device initialization. The Bluetooth 1.0b specification was ambiguous
on how the device firmware was suppose to handle it. Almost every device
was triggering a transport reset at the same time. In case of USB this
ended up in disconnects from the bus.

All modern Bluetooth dongles handle this perfectly fine and a lot of
them actually require that HCI Reset is sent. If not then they are
either stuck in their HID Proxy mode or their internal structures for
inquiry and paging are not correctly setup.

To handle old and new devices smoothly the Bluetooth subsystem contains
a quirk to force the HCI Reset on initialization. However maintaining
such a quirk becomes more and more complicated. This patch turns the
logic around and lets the old devices disable the HCI Reset command.

The only device where the HCI_QUIRK_NO_RESET is still needed are the
original Digianswer devices and dongles with an early CSR firmware.

CSR reported that they fixed this for version 12 firmware. The last
official release of version 11 firmware is build ID 115. The first
version 12 candidate was build ID 117.

Signed-off-by: Marcel Holtmann

bpa10x: free sk_buff with kfree_skb

2008-10-31T07:40:19+00:00

Inspired by Sergio Luis' similar patches, I finally found
a case which is trivial enough that spatch won't choke
on it.

Signed-off-by: Ilpo Järvinen 
Acked-by: Marcel Holtmann 
Signed-off-by: David S. Miller

[Bluetooth] Fix double frees on error paths of btusb and bpa10x drivers

2008-10-06T10:22:51+00:00

The transfer buffer of an URB will be automatically freed when using
the URB_FREE_BUFFER transfer_flag. So the extra calls to kfree() will
cause a double free.

Reported-by: Justin Mattock 
Signed-off-by: Rabin Vincent 
Signed-off-by: Marcel Holtmann