linux-toradex.git/drivers/bluetooth/btmrvl_sdio.c, branch v4.14 Linux kernel for Apalis and Colibri modules Bluetooth: Style fix - align block comments 2017-07-22T06:39:39+00:00 Derek Robson robsonde@gmail.com 2017-07-22T01:47:07+00:00 d98422cb6619408f1779457fefc5da983fc6bc3b Fixed alignment of all block comments. Found using checkpatch Signed-off-by: Derek Robson <robsonde@gmail.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
Fixed alignment of all block comments.
Found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Bluetooth: btmrvl: remove unnecessary wakeup interrupt number sanity check 2017-04-12T20:02:40+00:00 Xinming Hu huxm@marvell.com 2017-03-31T06:32:32+00:00 c8ba804437d6311f61e4ca77a1cf43ce6a17bd21 Sanity check of interrupt number in interrupt handler is unnecessary and confusion, remove it. Reported-by: Guenter Roeck <groeck@chromium.org> Signed-off-by: Xinming Hu <huxm@marvell.com> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
Sanity check of interrupt number in interrupt handler is unnecessary and
confusion, remove it.

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Xinming Hu <huxm@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Bluetooth: btmrvl: disable platform wakeup interrupt in suspend failure path 2017-04-12T20:02:40+00:00 Xinming Hu huxm@marvell.com 2017-03-31T06:32:31+00:00 6eb7bd66830c1e1919aa4006d7eb288873b0f806 Host sleep handshake with device might been fail, disable platform wakeup interrupt in this case. Reported-by: Guenter Roeck <groeck@chromium.org> Signed-off-by: Xinming Hu <huxm@marvell.com> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
Host sleep handshake with device might been fail, disable platform wakeup
interrupt in this case.

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Xinming Hu <huxm@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Bluetooth: btmrvl: cleanup code in return from btmrvl_sdio_suspend() 2017-04-12T20:02:39+00:00 prasanna karthik prasannakarthik@outlook.com 2017-03-28T19:44:00+00:00 f1554b7b2c27cedee6c772dab954629987690110 Else is not generally useful after a break or return Signed-off-by: Prasanna Karthik <pkarthik@outlook.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
Else is not generally useful after a break or return

Signed-off-by: Prasanna Karthik <pkarthik@outlook.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Bluetooth: btmrvl: wake system up when receives a wake irq 2017-04-12T20:02:38+00:00 Jeffy Chen jeffy.chen@rock-chips.com 2017-02-24T06:24:30+00:00 17e41ea6db92226df1acbe18e48b36bf59780d32 Currrently we are disabling this wake irq after receiving it. If this happens before we finish suspend and the pm event check is disabled, the system will continue suspending, and this irq would not work again. We may need to abort system suspend to avoid that. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
Currrently we are disabling this wake irq after receiving it. If this
happens before we finish suspend and the pm event check is disabled,
the system will continue suspending, and this irq would not work again.

We may need to abort system suspend to avoid that.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Bluetooth: btmrvl: fix spelling mistake: "unregester" -> "unregister" 2017-04-12T20:02:35+00:00 Colin Ian King colin.king@canonical.com 2017-03-21T12:20:28+00:00 9232259913022c1ab96f7bf2b87598b89b942f1f trivial fix to spelling mistake in debug message Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
trivial fix to spelling mistake in debug message

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
btmrvl: fix spelling mistake: "actived" -> "activated" 2017-02-18T23:26:37+00:00 Colin Ian King colin.king@canonical.com 2017-02-18T22:52:55+00:00 8f91566f99fab8f7a0d2728a1e3defb13675837a trivial fix to spelling mistake in error message Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
trivial fix to spelling mistake in error message

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
btmrvl: use dt's irqflags for wakeup pin 2017-02-16T16:25:20+00:00 Jeffy Chen jeffy.chen@rock-chips.com 2017-01-23T04:18:53+00:00 ffb955dba61dd823c3d52a083b6c8d0dcfda0efe Use irqflags parsed from dt. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Reviewed-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
Use irqflags parsed from dt.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
btmrvl: set irq_bt to -1 when failed to parse it 2017-02-16T16:25:20+00:00 Jeffy Chen jeffy.chen@rock-chips.com 2017-01-23T04:18:52+00:00 fd1a88da81d60a27960174bd9cda312c712961d1 The irq_of_parse_and_map will return 0 as a invalid irq. Set irq_bt to -1 in this case, so that the btmrvl resume/suspend code would not try to enable/disable it. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Reviewed-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
The irq_of_parse_and_map will return 0 as a invalid irq.

Set irq_bt to -1 in this case, so that the btmrvl resume/suspend code
would not try to enable/disable it.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
btmrvl: avoid double-disable_irq() race 2017-02-16T16:25:19+00:00 Jeffy Chen jeffy.chen@rock-chips.com 2017-01-23T04:18:51+00:00 9af02d86e11dc409e5c3de46e81c0a492ba58905 It's much the same as what we did for mwifiex in: b9da4d2 mwifiex: avoid double-disable_irq() race "We have a race where the wakeup IRQ might be in flight while we're calling mwifiex_disable_wake() from resume(). This can leave us disabling the IRQ twice. Let's disable the IRQ and enable it in case if we have double-disabled it." Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> Reviewed-by: Brian Norris <briannorris@chromium.org> Signed-off-by: Marcel Holtmann <marcel@holtmann.org> 
It's much the same as what we did for mwifiex in:
b9da4d2 mwifiex: avoid double-disable_irq() race

"We have a race where the wakeup IRQ might be in flight while we're
calling mwifiex_disable_wake() from resume(). This can leave us
disabling the IRQ twice.

Let's disable the IRQ and enable it in case if we have double-disabled
it."

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>