linux-toradex.git/drivers/bluetooth/btwilink.c, branch v4.9.41

Bluetooth: btwilink: Fix probe return value

2016-10-20T08:14:49+00:00

Probe functions should return 0 on success. This driver's probe
returns the value returned by hci_register_dev(), which is the hci
index. This works for systems with only one hci device (id = 0) but
for systems where the btwilink device ends up with an id larger than
0, things will start to fall apart.

Make the probe function return 0 on success.

Signed-off-by: Jacob Siverskog 
Signed-off-by: Marcel Holtmann

Bluetooth: btwilink: Save the packet type before sending

2016-09-22T20:18:59+00:00

Running with KASAN produces some messages:

BUG: KASAN: use-after-free in ti_st_send_frame+0x9c/0x16c at addr
ffffffc064868fe8
Read of size 1 by task kworker/u17:1/1266



Hardware name: HiKey Development Board (DT)
Workqueue: hci0 hci_cmd_work
Call trace:
[] dump_backtrace+0x0/0x178
[] show_stack+0x20/0x28
[] dump_stack+0xa8/0xe0
[] print_trailer+0x110/0x174
[] object_err+0x4c/0x5c
[] kasan_report_error+0x254/0x54c
[] kasan_report+0x64/0x70
[] __asan_load1+0x4c/0x54
[] ti_st_send_frame+0x9c/0x16c
[] hci_send_frame+0xb4/0x118
[] hci_cmd_work+0xcc/0x154
[] process_one_work+0x26c/0x7a4
[] worker_thread+0x9c/0x73c
[] kthread+0x138/0x154
[] ret_from_fork+0x10/0x40

The packet is being accessed for statistics after it has been freed.
Save the packet type before sending for statistics afterwards.

Signed-off-by: Laura Abbott 
Signed-off-by: Marcel Holtmann

drivers: misc: ti-st: Use int instead of fuzzy char for callback status

2016-07-17T17:59:26+00:00

On mips and parisc:

    drivers/bluetooth/btwilink.c: In function 'ti_st_open':
    drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit constant conversion [-Woverflow]
       hst->reg_status = -EINPROGRESS;

    drivers/nfc/nfcwilink.c: In function 'nfcwilink_open':
    drivers/nfc/nfcwilink.c:396:31: warning: overflow in implicit constant conversion [-Woverflow]
      drv->st_register_cb_status = -EINPROGRESS;

There are actually two issues:
  1. Whether "char" is signed or unsigned depends on the architecture.
     As the completion callback data is used to pass a (negative) error
     code, it should always be signed.
  2. EINPROGRESS is 150 on mips, 245 on parisc.
     Hence -EINPROGRESS doesn't fit in a signed 8-bit number.

Change the callback status from "char" to "int" to fix these.

Signed-off-by: Geert Uytterhoeven 
Acked-by: Mauro Carvalho Chehab 
Acked-by: Samuel Ortiz 
Signed-off-by: Marcel Holtmann

Bluetooth: Use new hci_skb_pkt_* wrappers for drivers

2015-11-19T16:50:27+00:00

The new hci_skb_pkt_* wrappers are mainly intented for drivers to
require less knowledge about bt_cb(sbk) handling. So after converting
the core packet handling, convert all drivers.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Move handling of HCI_RUNNING flag into core

2015-10-05T07:30:25+00:00

Setting and clearing of HCI_RUNNING flag in each and every driver is
just duplicating the same code all over the place. So instead of having
the driver do it in their hdev->open and hdev->close callbacks, set it
globally in the core transport handling.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Move HCI_RUNNING check into hci_send_frame

2015-10-05T07:30:10+00:00

In all callbacks for hdev->send the status of HCI_RUNNING is checked. So
instead of repeating that code in every driver, move the check into the
hci_send_frame function before calling hdev->send.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: btwilink: remove DEBUG define

2015-05-13T21:00:51+00:00

Remove the DEBUG define as the debug code; so can remove mass debug info
from log buffer when using dmesg.

Signed-off-by: Leo Yan 
Signed-off-by: Marcel Holtmann

bluetooth: drop owner assignment from platform_drivers

2014-10-20T14:20:19+00:00

A platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang

Bluetooth: Add hdev parameter to hdev->send driver callback

2013-10-11T13:28:03+00:00

Instead of masking hdev inside the skb->dev parameter, hand it
directly to the driver as a parameter to hdev->send. This makes
the driver interface more clear and simpler.

This patch fixes all drivers to accept and handle the new parameter
of hdev->send callback. Special care has been taken for bpa10x
and btusb drivers that require having skb->dev set to hdev for
the URB transmit complete handlers.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Provide hdev parameter to hci_recv_frame() driver callback

2013-10-11T07:45:34+00:00

To avoid casting skb->dev into hdev, just let the drivers provide
the hdev directly when calling hci_recv_frame() function.

This patch also fixes up all drivers to provide the hdev.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg