linux-toradex.git/drivers/bluetooth/hci_h5.c, branch v3.14.36

Bluetooth: Fix HCI H5 corrupted ack value

2014-10-30T16:38:23+00:00

commit 4807b51895dce8aa650ebebc51fa4a795ed6b8b8 upstream.

In this expression: seq = (seq - 1) % 8
seq (u8) is implicitly converted to an int in the arithmetic operation.
So if seq value is 0, operation is ((0 - 1) % 8) => (-1 % 8) => -1.
The new seq value is 0xff which is an invalid ACK value, we expect 0x07.
It leads to frequent dropped ACK and retransmission.
Fix this by using '&' binary operator instead of '%'.

Signed-off-by: Loic Poulain 
Signed-off-by: Marcel Holtmann 
Signed-off-by: Greg Kroah-Hartman

Bluetooth: Ignore H5 non-link packets in non-active state

2014-07-28T15:05:56+00:00

commit 48439d501e3d9e8634bdc0c418e066870039599d upstream.

When detecting a non-link packet, h5_reset_rx() frees the Rx skb.
Not returning after that will cause the upcoming h5_rx_payload()
call to dereference a now NULL Rx skb and trigger a kernel oops.

Signed-off-by: Loic Poulain 
Signed-off-by: Marcel Holtmann 
Signed-off-by: Greg Kroah-Hartman

Bluetooth: Provide hdev parameter to hci_recv_frame() driver callback

2013-10-11T07:45:34+00:00

To avoid casting skb->dev into hdev, just let the drivers provide
the hdev directly when calling hci_recv_frame() function.

This patch also fixes up all drivers to provide the hdev.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Introduce a flags variable to Three-wire UART state

2012-07-17T17:49:24+00:00

This patch introduces a flags variable to the Three-wire UART state
struct and converts the two existing bools in the struct into flags.

Signed-off-by: Johan Hedberg 
Signed-off-by: Gustavo Padovan

Bluetooth: Improve Three-wire UART configuration handling

2012-07-17T17:49:14+00:00

The configuration request/response messages contain a configuration
field which contains the sliding window size (amount of unacked reliable
packets that can be pending). This patch makes sure that we configure
the correct size (minimum of local and remote values) and use it when
determining whether to send new packets or not.

Signed-off-by: Johan Hedberg 
Signed-off-by: Gustavo Padovan

Bluetooth: Remove unnecessary h5_build_pkt function

2012-07-17T17:48:38+00:00

The implementation of h5_build_packet can be moved into
h5_prepare_pkt since all h5_prepare_pkt does is determine whether the
packet is reliable and then call h5_build_packet.

Signed-off-by: Johan Hedberg 
Signed-off-by: Gustavo Padovan

Bluetooth: Implement proper low-power support for Three-wire UART

2012-07-17T17:48:37+00:00

This patch adds on-demand wakeup request sending (and re-sendind) when
we are in low-power state. When the controller enters this state it will
send a sleep message after which the host is not allowed to send any
other packets until a wakeup request has been sent and the woken message
received as a response to it. The wakeup requests are re-sent
periodically until a woken message is received.

Signed-off-by: Johan Hedberg 
Signed-off-by: Gustavo Padovan

Bluetooth: Add initialization tracking to HCI Three-wire driver

2012-07-17T17:48:35+00:00

This patch adds tracking for the uninitialized, initialized and active
states for Three-wire UART. This is needed so we can handle periodic
sending of the Link Establishment messages before reaching active state
and so that we do not try to do any higher level HCI data transmission
before reaching active state.

Signed-off-by: Johan Hedberg 
Signed-off-by: Gustavo Padovan

Bluetooth: Add initial sleep support to Three-wire UART

2012-07-17T17:48:33+00:00

This patch adds very basic support for the sleep related messages. The
only thing the code does right now is send a wakeup message as soon as
receiving a sleep one, essentially preventing the controller from going
to sleep.

Signed-off-by: Johan Hedberg 
Signed-off-by: Gustavo Padovan

Bluetooth: Improve rx debug logs for Three-wire UART

2012-07-17T17:48:32+00:00

Remove unnecessary debug logs and add some to more centralized places.

Signed-off-by: Johan Hedberg 
Signed-off-by: Gustavo Padovan