linux-toradex.git/drivers/bluetooth/hci_h5.c, branch v4.1.23

Bluetooth: hci_uart: Remove the manual protocol init message

2015-04-07T16:47:10+00:00

The init function for each HCI UART protocol prints the same on success
and failure. This information is so generic, remove it and let the main
HCI UART handling print it instead.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: hci_uart: Add name information to hci_uart_proto struct

2015-04-07T16:47:10+00:00

This adds an extra name field to the hci_uart_proto struct that provides
a simple way of adding a string identifier to the protocol.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: hci_uart: Make struct hci_uart_proto always const

2015-04-07T16:47:10+00:00

The usage of struct hci_uart_proto should always be const. Change the
function headers and individual protocol drivers.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: hci_uart: Use const data pointer for received data

2015-04-07T16:47:09+00:00

The TTY layer provides its data pointers as const, but the HCI UART
callbacks expect them as general data pointers. This is of course
wrong and instead of casting them, just fix the individual drivers
to actually take a const data pointer.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Switch HCI H5 driver to use hci_reset_dev() function

2014-11-02T08:03:51+00:00

Instead of having the driver generate the HCI Hardware Error event
manually, just call hci_reset_dev() to trigger the upper stack reset.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: Use HCI_EV_HARDWARE_ERROR define for event payload

2014-11-02T08:00:53+00:00

When constructing the event payload for the HCI_Hardware_Error event
message, use the HCI_EV_HARDWARE_ERROR define.

In addition rename the variables from hard_err to hw_err to clearly
indicate that this is about the hardware error and not a hard error.

Signed-off-by: Marcel Holtmann 
Signed-off-by: Johan Hedberg

Bluetooth: HCI H5 peer reset detection

2014-10-31T17:54:34+00:00

H5 Specification says:
If a SYNC message is received while in the Active State, it is
assumed that the peer device has reset. The local device should
therefore perform a full reset of the upper stack, and start Link
Establishment again at the Uninitialized State. Upon entering the
Active State, the first packet sent shall have its SEQ and ACK
numbers set to zero.

This patch resets the HCI H5 driver data/state to unitialized and
reports an HCI hardware error event to notify the upper stack that
HCI synchronization has been lost. H5 will be re-synchronized and
upper stack should generate an HCI Reset command.

Signed-off-by: Loic Poulain 
Signed-off-by: Johan Hedberg

Bluetooth: Fix HCI H5 corrupted ack value

2014-08-14T06:49:19+00:00

In this expression: seq = (seq - 1) % 8
seq (u8) is implicitly converted to an int in the arithmetic operation.
So if seq value is 0, operation is ((0 - 1) % 8) => (-1 % 8) => -1.
The new seq value is 0xff which is an invalid ACK value, we expect 0x07.
It leads to frequent dropped ACK and retransmission.
Fix this by using '&' binary operator instead of '%'.

Signed-off-by: Loic Poulain 
Signed-off-by: Marcel Holtmann 
Cc: stable@vger.kernel.org

Bluetooth: Remove redundant calls to h5_reset_rx

2014-07-03T15:42:45+00:00

h5_reset_rx is unconditionally called at the end of
h5_complete_rx_pkt, no need to call it anymore after
that.

Signed-off-by: Loic Poulain 
Signed-off-by: Marcel Holtmann

Bluetooth: Ignore H5 non-link packets in non-active state

2014-06-23T16:22:48+00:00

When detecting a non-link packet, h5_reset_rx() frees the Rx skb.
Not returning after that will cause the upcoming h5_rx_payload()
call to dereference a now NULL Rx skb and trigger a kernel oops.

Signed-off-by: Loic Poulain 
Signed-off-by: Marcel Holtmann 
Cc: stable@vger.kernel.org