linux-toradex.git/drivers/bluetooth/hci_ll.c, branch v5.18-rc6

Bluetooth: Remove kernel-doc style comment block

2022-01-21T20:41:51+00:00

This patch changes the kernel-doc style comment block to common comment
block. These files don't support kernel-doc style so no need to use the
kernel-doc style. Also, they cause the warning when W=1 option is used
as below.

drivers/bluetooth/hci_ll.c:518: warning: Function parameter or member 'lldev' not described in 'download_firmware'
drivers/bluetooth/btmrvl_debugfs.c:29: warning: cannot understand function prototype: 'struct btmrvl_debugfs_data '
drivers/bluetooth/btmrvl_sdio.c:36: warning: expecting prototype for Marvell BT-over-SDIO driver(). Prototype was for VERSION() instead

Signed-off-by: Tedd Ho-Jeong An 
Signed-off-by: Marcel Holtmann

Bluetooth: hci_ll: add a small delay for wl1271 enable bt_en

2020-11-11T09:57:36+00:00

When using the wl1271 Bluetooth function of am335x, it is found that the
Bluetooth module cannot respond in time after Bluetooth is enabled, and
a small delay is needed to work normally, so whether to add a small
mdelay.

Signed-off-by: Xiaolei Wang 
Signed-off-by: Marcel Holtmann

Bluetooth: Use fallthrough pseudo-keyword

2020-07-10T17:09:42+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Marcel Holtmann

Revert "Bluetooth: hci_ll: set operational frequency earlier"

2019-10-16T18:33:16+00:00

As nice as it would be to update firmware faster, that patch broke
at least two different boards, an OMAP4+WL1285 based Motorola Droid
4, as reported by Sebasian Reichel and the Logic PD i.MX6Q +
WL1837MOD.

This reverts commit a2e02f38eff84f199c8e32359eb213f81f270047.

Signed-off-by: Adam Ford 
Acked-by: Sebastian Reichel 
Cc: stable@vger.kernel.org
Signed-off-by: Marcel Holtmann

Bluetooth: Cleanup formatting and coding style

2019-07-06T10:39:04+00:00

Fix some warnings and one error reported by checkpatch.pl:
- lines longer than 80 characters are wrapped
- empty lines inserted to separate variable declarations from the actual
  code
- line break inserted after if (...)

Co-developed-by: Thomas Röthenbacher 
Signed-off-by: Thomas Röthenbacher 
Signed-off-by: Fabian Schindlatz 
Cc: linux-kernel@i4.cs.fau.de
Signed-off-by: Marcel Holtmann

Bluetooth: hci_ll: Refactor download_firmware

2019-07-06T10:30:51+00:00

Extract the new function send_command_from_firmware from
download_firmware, which helps with the readability of the switch
statement. This way the code is less deeply nested and also no longer
exceeds the 80 character limit.

Co-developed-by: Thomas Röthenbacher 
Signed-off-by: Thomas Röthenbacher 
Signed-off-by: Fabian Schindlatz 
Signed-off-by: Marcel Holtmann

Bluetooth: hci_ll: set operational frequency earlier

2019-07-06T10:29:25+00:00

Uploading the firmware needs quite a few seconds if done at 115200 kbps. So set
the operational frequency, usually 3 MHz, before uploading the firmware.

I have successfully tested this with a wl1837mod.

Signed-off-by: Philipp Puschmann 
Signed-off-by: Marcel Holtmann

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333

2019-06-05T15:37:06+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation this program is
  distributed in the hope that it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details you should have received a copy of the gnu general
  public license along with this program if not write to the free
  software foundation inc 59 temple place suite 330 boston ma 02111
  1307 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 136 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Alexios Zavras 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190530000436.384967451@linutronix.de
Signed-off-by: Greg Kroah-Hartman

Bluetooth: hci_serdev: Move serdev_device_close/open into common hci_serdev code

2018-05-30T06:47:42+00:00

Make hci_uart_register_device() and hci_uart_unregister_device() call
serdev_device_close()/open() themselves instead of relying on the various
hci_uart drivers to do this for them.

Besides reducing code complexity, this also ensures correct error checking
of serdev_device_open(), which was missing in a few drivers.

Signed-off-by: Hans de Goede 
Signed-off-by: Marcel Holtmann

Bluetooth: hci_ll: Convert to use h4_recv_buf helper

2018-04-01T12:25:32+00:00

The HCILL or eHCILL protocol from TI is actually an H:4 protocol with a
few extra events and thus can also use the h4_recv_buf helper. Instead
of open coding the same funtionality add the extra events to the packet
description table and use h4_recv_buf.

Signed-off-by: Marcel Holtmann 
Tested-by: Tony Lindgren 
Signed-off-by: Johan Hedberg