linux-toradex.git/drivers/bluetooth, branch tegra-10.7.1

Bluetooth: Prevent ill-timed autosuspend in USB driver

2010-01-06T23:03:43+00:00

commit 652fd781a52ad6e24b908cd8b83d12699754f253 upstream.

The device must be marked busy as it receives data.

Signed-off-by: Oliver Neukum 
Tested-by: Matthew Garrett 
Signed-off-by: Marcel Holtmann 
Signed-off-by: Greg Kroah-Hartman

fix memory leak in fixed btusb_close

2009-11-14T20:57:08+00:00

If the waker is killed before it can replay outstanding URBs, these URBs
won't be freed or will be replayed at the next open.  This patch closes
the window by explicitely discarding outstanding URBs.

Signed-off-by: Oliver Neukum 
Acked-by: Marcel Holtmann 
Signed-off-by: Linus Torvalds

btusb bluetooth driver: wait for 'waker' work too before closing

2009-11-11T21:32:29+00:00

Rafael debugged a resume-time hang (with oopses in workqueue handling)
on his laptop that was due to the 'waker' workqueue entry being
disconnected and then released without the workqueue entry having been
synchronized.

Several people were involved, with Oleg Nesterov doing a debugging patch
showing what workqueue entry was corrupt etc.

This was a regression introduced by commit 7bee549e19 ("Bluetooth: Add
USB autosuspend support to btusb driver") as Rafael points out (not
actually bisected, but it became clear once the bug was found).

Tested-and-reported-by: Rafael J. Wysocki 
Acked-by: Oliver Neukum 
Cc: Oleg Nesterov 
Cc: Tejun Heo 
Cc: Marcel Holtmann 
Signed-off-by: Linus Torvalds

pcmcia: dtl1_cs: fix pcmcia_loop_config logic

2009-09-15T17:17:16+00:00

pcmcia_loop_config returns 0 on success.

[wsa: added '< 0' for better readability]

Signed-off-by: Philipp Zabel 
Acked-by: Marcel Holtmann 
Signed-off-by: Wolfram Sang 
Signed-off-by: Greg Kroah-Hartman

Bluetooth: Add USB autosuspend support to btusb driver

2009-08-24T23:31:24+00:00

This patch adds support of USB autosuspend to the btusb driver.

If the device doesn't support remote wakeup, simple support based on
up/down is provided. If the device supports remote wakeup, additional
support for autosuspend while the interface is up is provided. This is
done by queueing URBs in an anchor structure and waking the device up
from a work queue on sending. Reception triggers remote wakeup.

The last busy facility of the USB autosuspend code is used. To close
a race between autosuspend and transmission, a counter of ongoing
transmissions is maintained.

Add #ifdefs for CONFIG_PM as necessary.

Signed-off-by: Oliver Neukum 
Tested-by: Sarah Sharp 
Signed-off-by: Marcel Holtmann

Bluetooth: Fix false errors from bcsp_pkt_cull function

2009-08-24T20:32:32+00:00

The error message "Removed only %u out of %u pkts" is printed when multiple
to be acked packets are queued.

    if (i++ >= pkts_to_be_removed)
            break;

This will break out of the loop and increase the counter i when
i==pkts_to_be_removed and the loop ends up with i=pkts_to_be_removed+1.

The following line

    if (i != pkts_to_be_removed) {
            BT_ERR("Removed only %u out of %u pkts", i, pkts_to_be_removed);
    }

will then display the false message.

The counter i must not increase on the same statement.

Signed-off-by: Wending Weng 
Signed-off-by: Marcel Holtmann

Bluetooth: Add missing kmalloc NULL tests to Marvell driver

2009-08-22T21:33:22+00:00

Check that the result of kmalloc is not NULL before dereferencing it.
The patch also replaces kmalloc + memset by kzalloc.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression *x;
identifier f;
constant char *C;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
... when != x == NULL
    when != x != NULL
    when != (x || ...)
(
kfree(x)
|
f(...,C,...,x,...)
|
*f(...,x,...)
|
*x->f
)
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Marcel Holtmann

Bluetooth: Fix incorrect alignment in Marvell BT-over-SDIO driver

2009-08-22T21:25:34+00:00

The driver uses "u32" for alignment check and calculation which
works only on 32-bit system. It will crash the 64-bit system.
Replace "u32" with "unsigned long" to fix this issue.

Signed-off-by: Bing Zhao 
Signed-off-by: Marcel Holtmann

Bluetooth: Remove Enter/Leave debug statements from Marvell driver

2009-08-22T21:25:34+00:00

The Marvell Bluetooth driver is full of Enter/Leave debug statements and
all of them are really pointless and only clutter the code. Seems to be
some left-overs when they ported the driver from Windows. For the Linux
driver lets remove these.

Signed-off-by: Marcel Holtmann

Bluetooth: Fix last few compiler warning within Marvell core driver

2009-08-22T21:25:34+00:00

After fixing the driver to use skb_put properly for their HCI commands
only a few compiler warnings are left. Add proper casting for them.

Signed-off-by: Marcel Holtmann