linux-toradex.git/drivers/cdrom, branch v3.10.78

drivers/cdrom/cdrom.c: use kzalloc() for failing hardware

2013-07-13T18:42:26+00:00

commit 542db01579fbb7ea7d1f7bb9ddcef1559df660b2 upstream.

In drivers/cdrom/cdrom.c mmc_ioctl_cdrom_read_data() allocates a memory
area with kmalloc in line 2885.

  2885         cgc->buffer = kmalloc(blocksize, GFP_KERNEL);
  2886         if (cgc->buffer == NULL)
  2887                 return -ENOMEM;

In line 2908 we can find the copy_to_user function:

  2908         if (!ret && copy_to_user(arg, cgc->buffer, blocksize))

The cgc->buffer is never cleaned and initialized before this function.
If ret = 0 with the previous basic block, it's possible to display some
memory bytes in kernel space from userspace.

When we read a block from the disk it normally fills the ->buffer but if
the drive is malfunctioning there is a chance that it would only be
partially filled.  The result is an leak information to userspace.

Signed-off-by: Dan Carpenter 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Cc: Jonathan Salwan 
Cc: Luis Henriques 
Signed-off-by: Greg Kroah-Hartman

block_device_operations->release() should return void

2013-05-07T06:16:21+00:00

The value passed is 0 in all but "it can never happen" cases (and those
only in a couple of drivers) *and* it would've been lost on the way
out anyway, even if something tried to pass something meaningful.
Just don't bother.

Signed-off-by: Al Viro

Drivers: misc: remove __dev* attributes.

2013-01-03T23:57:16+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Signed-off-by: Greg Kroah-Hartman

workqueue: deprecate flush[_delayed]_work_sync()

2012-08-20T21:51:24+00:00

flush[_delayed]_work_sync() are now spurious.  Mark them deprecated
and convert all users to flush[_delayed]_work().

If you're cc'd and wondering what's going on: Now all workqueues are
non-reentrant and the regular flushes guarantee that the work item is
not pending or running on any CPU on return, so there's no reason to
use the sync flushes at all and they're going away.

This patch doesn't make any functional difference.

Signed-off-by: Tejun Heo 
Cc: Russell King 
Cc: Paul Mundt 
Cc: Ian Campbell 
Cc: Jens Axboe 
Cc: Mattia Dongili 
Cc: Kent Yoder 
Cc: David Airlie 
Cc: Jiri Kosina 
Cc: Karsten Keil 
Cc: Bryan Wu 
Cc: Benjamin Herrenschmidt 
Cc: Alasdair Kergon 
Cc: Mauro Carvalho Chehab 
Cc: Florian Tobias Schandinat 
Cc: David Woodhouse 
Cc: "David S. Miller" 
Cc: linux-wireless@vger.kernel.org
Cc: Anton Vorontsov 
Cc: Sangbeom Kim 
Cc: "James E.J. Bottomley" 
Cc: Greg Kroah-Hartman 
Cc: Eric Van Hensbergen 
Cc: Takashi Iwai 
Cc: Steven Whitehouse 
Cc: Petr Vandrovec 
Cc: Mark Fasheh 
Cc: Christoph Hellwig 
Cc: Avi Kivity

powerpc: Remove some of the legacy iSeries specific device drivers

2012-03-15T22:28:05+00:00

These drivers are specific to the PowerPC legacy iSeries platform and
their Kconfig is specified in arch/powerpc.  Legacy iSeries is being
removed, so these drivers can no longer be selected.

Cc: Jens Axboe 
Signed-off-by: Stephen Rothwell 
Signed-off-by: Benjamin Herrenschmidt

cdrom: move shared static to cdrom_device_info

2012-02-08T19:03:14+00:00

The keeplocked variable in the cdrom driver is shared across multiple
drives, but set in per-device ioctls.  Move it to the per-device struct,
avoiding that the setting on one drive affects the driver's behavior
when closing another.

[ Impact: limit udev's confusion to one drive when a CD burning program
  unlocks the CD door at the end of burning. ]

Signed-off-by: Paolo Bonzini 
Signed-off-by: Jens Axboe

cdrom: use copy_to_user() without the underscores

2012-02-06T09:20:45+00:00

"nframes" comes from the user and "nframes * CD_FRAMESIZE_RAW" can wrap
on 32 bit systems.  That would have been ok if we used the same wrapped
value for the copy, but we use a shifted value.  We should just use the
checked version of copy_to_user() because it's not going to make a
difference to the speed.

Cc: stable@vger.kernel.com
Signed-off-by: Dan Carpenter 
Signed-off-by: Jens Axboe

block: add and use scsi_blk_cmd_ioctl

2012-01-14T23:07:24+00:00

Introduce a wrapper around scsi_cmd_ioctl that takes a block device.

The function will then be enhanced to detect partition block devices
and, in that case, subject the ioctls to whitelisting.

Cc: linux-scsi@vger.kernel.org
Cc: Jens Axboe 
Cc: James Bottomley 
Signed-off-by: Paolo Bonzini 
Signed-off-by: Linus Torvalds

module_param: make bool parameters really bool (drivers & misc)

2012-01-12T23:02:20+00:00

module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

Acked-by: Mauro Carvalho Chehab 
Signed-off-by: Rusty Russell

fs: move code out of buffer.c

2012-01-04T03:54:07+00:00

Move invalidate_bdev, block_sync_page into fs/block_dev.c.  Export
kill_bdev as well, so brd doesn't have to open code it.  Reduce
buffer_head.h requirement accordingly.

Removed a rather large comment from invalidate_bdev, as it looked a bit
obsolete to bother moving.  The small comment replacing it says enough.

Signed-off-by: Nick Piggin 
Cc: Al Viro 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Al Viro