linux-toradex.git/drivers/char/ip2/ip2main.c, branch tegra-10.9.7

tty: rewrite the ldisc locking

2009-06-11T15:51:01+00:00

There are several pretty much unfixable races in the old ldisc code, especially
with respect to pty behaviour and also to hangup. It's easier to rewrite the
code than simply try and patch it up.

This patch
- splits the ldisc from the tty (so we will be able to refcount it more cleanly
  later)
- introduces a mutex lock for ldisc changing on an active device
- fixes the complete mess that hangup caused
- implements hopefully correct setldisc/close/hangup locking

There are still some problems around pty pairs that have always been there but
at least it is now possible to understand the code and fix further problems.

This fixes the following known bugs
- hang up can leak ldisc references
- hang up may not call open/close on ldisc in a matched way
- pty/tty pairs can deadlock during an ldisc change
- reading the ldisc proc files can cause every ldisc to be loaded

and probably a few other of the mysterious ldisc race reports.

I'm sure it also adds the odd new one.

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

proc tty: switch ip2 to ->proc_fops

2009-04-01T15:59:08+00:00

Signed-off-by: Alexey Dobriyan 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

device create: char: convert device_create_drvdata to device_create

2008-10-16T16:24:42+00:00

Now that device_create() has been audited, rename things back to the
original call to be sane.

Signed-off-by: Greg Kroah-Hartman

tty: kref the tty driver object

2008-10-13T16:51:42+00:00

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

ip2: avoid add_timer with pending timer

2008-10-13T16:51:39+00:00

add_timer() is not supposed to be called when the timer is pending.
ip2 driver attempts to avoid that condition by setting and resetting
a flag (TimerOn) in timer function. But there is some gap between
add_timer() and setting TimerOn.

This patch fix this problem by using mod_timer() and remove TimerOn
which has been unnecessary by this change.

Signed-off-by: Akinobu Mita 
Signed-off-by: Jiri Slaby 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

ip2: init/deinit cleanup

2008-10-13T16:51:39+00:00

Cleanup of module_init/exit:
- mostly whitespace
- remove empty functions
- replace c++ comments
- remove useless prints (module loaded, unloaded)
- mark the calls as __exit and __init
- use break; and return; to save some indent levels after it
- note resource leakage

It's still mess, but now it's readable.

Signed-off-by: Jiri Slaby 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

ip2: fix sparse warnings

2008-10-13T16:51:39+00:00

Signed-off-by: Jiri Slaby 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

ip2: cleanup globals

2008-10-13T16:51:39+00:00

- do not init .bss zeroed data to zero again (by memset or
  explicit assignment)
- use char [] instead of char * for string constants

Signed-off-by: Jiri Slaby 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

Char: merge ip2main and ip2base

2008-10-13T16:51:39+00:00

It's pretty useless to have one setup() function separated along with
module_init() which only calls a function from ip2main anyway. Get rid
of ip2base.

Remove also checks of always-true now.

Signed-off-by: Jiri Slaby 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

ip2: push BKL down for the firmware interface

2008-07-25T17:53:43+00:00

(The tty side is already done)

Signed-off-by: Alan Cox 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds