linux-toradex.git/drivers/char/ipmi/ipmi_devintf.c, branch v6.3-rc3 Linux kernel for Apalis and Colibri modules ipmi:devintf: Return a proper error when recv buffer too small 2021-10-05T11:54:16+00:00 Corey Minyard cminyard@mvista.com 2021-09-30T21:12:55+00:00 17a4262799fa7449e8fe06fe6d930ab7f5f32528 The right error message wasn't being set in one location, and it would return success on a failure. Signed-off-by: Corey Minyard <cminyard@mvista.com> 
The right error message wasn't being set in one location, and it would
return success on a failure.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
char: ipmi: remove unneeded break 2020-10-27T21:08:22+00:00 Tom Rix trix@redhat.com 2020-10-19T19:48:05+00:00 0df7b988d9df24d1ea120fde69b3e9cbd2555597 A break is not needed if it is preceded by a return Signed-off-by: Tom Rix <trix@redhat.com> Message-Id: <20201019194805.14996-1-trix@redhat.com> Signed-off-by: Corey Minyard <cminyard@mvista.com> 
A break is not needed if it is preceded by a return

Signed-off-by: Tom Rix <trix@redhat.com>
Message-Id: <20201019194805.14996-1-trix@redhat.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi: Remove file from ipmi_file_private 2019-04-17T18:14:25+00:00 Corey Minyard cminyard@mvista.com 2019-04-13T01:46:34+00:00 8fac128ce9a12908b5089ee5e3be435b42e59cac It's not used by anything, so just get rid of it. Reported-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Corey Minyard <cminyard@mvista.com> 
It's not used by anything, so just get rid of it.

Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi: Fix return value when a message is truncated 2019-02-10T01:48:42+00:00 Corey Minyard cminyard@mvista.com 2018-11-16T15:55:47+00:00 95ac0daa0ca98ad8ac23769021144f8bf04cf406 The user can ask the message to be returned even if it didn't supply enough memory for the data, and it will return an error but still fills in as much data as possible. However, the return value wasn't being set to an error, it was being overwritten. Create a second return value for that case. Signed-off-by: Corey Minyard <cminyard@mvista.com> 
The user can ask the message to be returned even if it didn't supply
enough memory for the data, and it will return an error but still
fills in as much data as possible.   However, the return value
wasn't being set to an error, it was being overwritten.  Create a
second return value for that case.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi: Convert printk(KERN_<level> to pr_<level>( 2018-09-18T21:15:33+00:00 Joe Perches joe@perches.com 2018-05-09T15:15:49+00:00 f993cdd99a5fc554bc79e1ce70a9f5335e386649 Use the more common logging style. Miscellanea: o Convert old style continuation printks without KERN_CONT to pr_cont o Coalesce formats o Realign arguments o Remove unnecessary casts Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Corey Minyard <cminyard@mvista.com> 
Use the more common logging style.

Miscellanea:

o Convert old style continuation printks without KERN_CONT to pr_cont
o Coalesce formats
o Realign arguments
o Remove unnecessary casts

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi_devintf: Add an error return on invalid ioctls 2018-04-18T15:23:04+00:00 Corey Minyard cminyard@mvista.com 2018-04-06T21:30:36+00:00 e56710d26eba07abca34c39c50e02e854436000a Signed-off-by: Corey Minyard <cminyard@mvista.com> 
Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi: Rename ipmi_user_t to struct ipmi_user * 2018-04-18T15:22:55+00:00 Corey Minyard cminyard@mvista.com 2018-04-06T01:50:48+00:00 2911c9886c8d5435a8778ce4888f6e4b8d7c900c Get rid of that non-compliance in the user files. Include files will come later. Signed-off-by: Corey Minyard <cminyard@mvista.com> 
Get rid of that non-compliance in the user files.  Include files
will come later.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi_devintf: Small lock rework 2018-04-18T15:22:53+00:00 Corey Minyard cminyard@mvista.com 2018-04-05T19:40:30+00:00 6aa2dd0092d2762cc12cccf5142313858f4153a4 The mutex didn't really serve any useful purpose, from what I can tell, and it would just get in the way. So remove it. Removing that required a mutex around the default value setting and getting, so just use the receive mutex for that. Also pull the fasync stuff outside of the lock for adding the data to the queue, since it didn't need to be there. Signed-off-by: Corey Minyard <cminyard@mvista.com> 
The mutex didn't really serve any useful purpose, from what I can
tell, and it would just get in the way.  So remove it.

Removing that required a mutex around the default value setting and
getting, so just use the receive mutex for that.

Also pull the fasync stuff outside of the lock for adding the data
to the queue, since it didn't need to be there.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi:devintf: Clean up some coding style issues 2018-04-18T15:22:49+00:00 Corey Minyard cminyard@mvista.com 2018-04-03T23:20:52+00:00 c81c5fc2128e3a596900859f10e294e30bc49b24 Signed-off-by: Corey Minyard <cminyard@mvista.com> 
Signed-off-by: Corey Minyard <cminyard@mvista.com>
ipmi: Add or fix SPDX-License-Identifier in all files 2018-02-27T13:42:51+00:00 Corey Minyard cminyard@mvista.com 2018-02-20T13:30:22+00:00 243ac21035176ac9692c1308a9f3b8f6a4e5d733 And get rid of the license text that is no longer necessary. Signed-off-by: Corey Minyard <cminyard@mvista.com> Cc: Kees Cook <keescook@chromium.org> Cc: Alistair Popple <alistair@popple.id.au> Cc: Jeremy Kerr <jk@ozlabs.org> Cc: Joel Stanley <joel@jms.id.au> Cc: Rocky Craig <rocky.craig@hp.com> 
And get rid of the license text that is no longer necessary.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Alistair Popple <alistair@popple.id.au>
Cc: Jeremy Kerr <jk@ozlabs.org>
Cc: Joel Stanley <joel@jms.id.au>
Cc: Rocky Craig <rocky.craig@hp.com>