linux-toradex.git/drivers/char/ipmi/ipmi_kcs_sm.c, branch v5.18-rc5

ipmi: Clean up some printks

2020-09-15T14:57:45+00:00

Convert to dev_xxx() and fix some verbage.

Signed-off-by: Corey Minyard

ipmi:sm: Print current state when the state is invalid

2020-09-15T14:46:20+00:00

Print current state before returning IPMI_NOT_IN_MY_STATE_ERR so we can
know where this issue is coming from and possibly fix the state machine.

Signed-off-by: Xianting Tian 
Message-Id: <20200915074441.4090-1-tian.xianting@h3c.com>
[Converted printk() to pr_xxx().]
Signed-off-by: Corey Minyard

ipmi: Convert printk(KERN_ to pr_(

2018-09-18T21:15:33+00:00

Use the more common logging style.

Miscellanea:

o Convert old style continuation printks without KERN_CONT to pr_cont
o Coalesce formats
o Realign arguments
o Remove unnecessary casts

Signed-off-by: Joe Perches 
Signed-off-by: Corey Minyard

ipmi: Add or fix SPDX-License-Identifier in all files

2018-02-27T13:42:51+00:00

And get rid of the license text that is no longer necessary.

Signed-off-by: Corey Minyard 
Cc: Kees Cook 
Cc: Alistair Popple 
Cc: Jeremy Kerr 
Cc: Joel Stanley 
Cc: Rocky Craig

ipmi: Make some data const that was only read

2015-09-03T20:02:27+00:00

Several data structures were only used for reading, so make them
const.

Signed-off-by: Corey Minyard

ipmi: Reset the KCS timeout when starting error recovery

2014-04-17T19:23:06+00:00

The OBF timer in KCS was not reset in one situation when error recovery
was started, resulting in an immediate timeout.

Reported-by: Bodo Stroesser 
Signed-off-by: Corey Minyard 
Signed-off-by: Linus Torvalds

ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful

2014-01-25T23:31:58+00:00

Use USEC_PER_SEC instead of 1000000, that making the later bugfix
more clearly.

Signed-off-by: Xie XiuQi 
Signed-off-by: Corey Minyard 
Signed-off-by: Linus Torvalds

ipmi: increase KCS timeouts

2012-03-29T00:14:36+00:00

We currently time out and retry KCS transactions after 1 second of waiting
for IBF or OBF.  This appears to be too short for some hardware.  The IPMI
spec says "All system software wait loops should include error timeouts.
For simplicity, such timeouts are not shown explicitly in the flow
diagrams.  A five-second timeout or greater is recommended".  Change the
timeout to five seconds to satisfy the slow hardware.

Signed-off-by: Matthew Garrett 
Signed-off-by: Corey Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/char/ipmi: Use KCS_IDLE_STATE

2009-12-16T15:20:10+00:00

KCS_IDLE and KCS_IDLE state have the same value, but in this function the
constants ending in _STATE are compared to the state variable.

Signed-off-by: Julia Lawall 
Acked-by: Core Minyard 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

IPMI: Style fixes in the system interface code

2008-04-29T15:06:15+00:00

Lots of style fixes for the IPMI system interface driver.  No functional
changes.  Basically fixes everything reported by checkpatch and fixes the
comment style.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Corey Minyard 
Cc: Rocky Craig 
Cc: Hannes Schulz 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds