linux-toradex.git/drivers/char/ipmi/ipmi_si_hotmod.c, branch v5.18-rc5

ipmi_si: Join string literals back

2021-04-02T17:53:42+00:00

For easy grepping on debug purposes join string literals back in
the messages.

No functional change.

Signed-off-by: Andy Shevchenko 
Message-Id: <20210402174334.13466-11-andriy.shevchenko@linux.intel.com>
Signed-off-by: Corey Minyard

ipmi_si: Drop redundant check before calling put_device()

2021-04-02T17:53:39+00:00

put_device() is NULL aware, drop redundant check before calling it.

Signed-off-by: Andy Shevchenko 
Message-Id: <20210402174334.13466-10-andriy.shevchenko@linux.intel.com>
Signed-off-by: Corey Minyard

ipmi_si: Use strstrip() to remove surrounding spaces

2021-04-02T17:53:36+00:00

Instead of home grown analogue, use strstrip() from the kernel library.

Signed-off-by: Andy Shevchenko 
Message-Id: <20210402174334.13466-9-andriy.shevchenko@linux.intel.com>
Signed-off-by: Corey Minyard

docs: fix references for ipmi.rst file

2020-05-15T17:55:21+00:00

As this file got moved, fix references for it.

Signed-off-by: Mauro Carvalho Chehab 
Link: https://lore.kernel.org/r/b6c1ded590f27198de15b16237509128e55fa810.1588345503.git.mchehab+huawei@kernel.org
Signed-off-by: Jonathan Corbet

ipmi: Add the i2c-addr property for SSIF interfaces

2019-04-24T14:02:53+00:00

This is required for SSIF to work.

There was no way to know if the interface being added was SI
or SSIF from the platform data, but that was required so the
i2c-addr is only added for SSIF interfaces.  So add a field
for that.

Also rework the logic a bit so that ipmi-type is not set
for SSIF interfaces, as it is not necessary for that.

Fixes: 3cd83bac481d ("ipmi: Consolidate the adding of platform devices")
Reported-by: Kamlakant Patel 
Signed-off-by: Corey Minyard 
Cc: stable@vger.kernel.org # 5.1

ipmi_si: Potential array underflow in hotmod_handler()

2019-02-22T20:59:25+00:00

The "ival" variable needs to signed so that we don't read before the
start of the str[] array.  This would only happen the user passed in a
module parameter that was just comprised of space characters.

Fixes: e80444ae4fc3 ("ipmi_si: Switch hotmod to use a platform device")
Signed-off-by: Dan Carpenter 
Message-Id: <20190222195530.GA306@kadam>
Signed-off-by: Corey Minyard

ipmi_si: Consolidate scanning the platform bus

2019-02-22T13:12:41+00:00

The same basic code was in two places.

Signed-off-by: Corey Minyard

ipmi_si: Remove hotmod devices on removal and exit

2019-02-22T13:12:41+00:00

When a hotmod-added device is removed or when the module is removed,
remove the platform devices that was created for it.

Signed-off-by: Corey Minyard

ipmi_si: Switch hotmod to use a platform device

2019-02-22T13:12:41+00:00

Don't force the main code to create one for it.

Signed-off-by: Corey Minyard

ipmi_si: Rename addr_type to addr_space to match what it does

2019-02-22T13:12:41+00:00

Make the naming consistent, and make the values an enum.

Signed-off-by: Corey Minyard