linux-toradex.git/drivers/char/ipmi/ipmi_si_intf.c, branch v4.4.95

ipmi: move timer init to before irq is setup

2015-12-09T19:13:06+00:00

We encountered a panic on boot in ipmi_si on a dell per320 due to an
uninitialized timer as follows.

static int smi_start_processing(void       *send_info,
                                ipmi_smi_t intf)
{
        /* Try to claim any interrupts. */
        if (new_smi->irq_setup)
                new_smi->irq_setup(new_smi);

 --> IRQ arrives here and irq handler tries to modify uninitialized timer

    which triggers BUG_ON(!timer->function) in __mod_timer().

 Call Trace:
   
   [] start_new_msg+0x47/0x80 [ipmi_si]
   [] start_check_enables+0x4e/0x60 [ipmi_si]
   [] smi_event_handler+0x1e8/0x640 [ipmi_si]
   [] ? __rcu_process_callbacks+0x54/0x350
   [] si_irq_handler+0x3c/0x60 [ipmi_si]
   [] handle_IRQ_event+0x60/0x170
   [] handle_edge_irq+0xde/0x180
   [] handle_irq+0x49/0xa0
   [] do_IRQ+0x6c/0xf0
   [] ret_from_intr+0x0/0x11

        /* Set up the timer that drives the interface. */
        setup_timer(&new_smi->si_timer, smi_timeout, (long)new_smi);

The following patch fixes the problem.

To: Openipmi-developer@lists.sourceforge.net
To: Corey Minyard 
CC: linux-kernel@vger.kernel.org

Signed-off-by: Jan Stancek 
Signed-off-by: Tony Camuso 
Signed-off-by: Corey Minyard 
Cc: stable@vger.kernel.org # Applies cleanly to 3.10-, needs small rework before

char: ipmi: Move MODULE_DEVICE_TABLE() to follow struct

2015-11-16T03:08:26+00:00

The policy for drivers is to have MODULE_DEVICE_TABLE() just after the
struct used in it. For clarity.

Suggested-by: Corey Minyard 
Signed-off-by: Luis de Bethencourt 
Signed-off-by: Corey Minyard

ipmi: Stop the timer immediately if idle

2015-11-16T03:08:26+00:00

The IPMI driver would let the final timeout just happen, but it could
easily just stop the timer.  If the timer stop fails that's ok, that
should be rare.

Signed-off-by: Corey Minyard

ipmi: Start the timer and thread on internal msgs

2015-11-16T03:08:26+00:00

The timer and thread were not being started for internal messages,
so in interrupt mode if something hung the timer would never go
off and clean things up.  Factor out the internal message sending
and start the timer for those messages, too.

Signed-off-by: Corey Minyard 
Tested-by: Gouji, Masayuki 
Cc: stable@vger.kernel.org

ipmi: add of_device_id in MODULE_DEVICE_TABLE

2015-09-03T20:02:31+00:00

Fix autoloading ipmi modules when using device tree.

Signed-off-by: Brijesh Singh 

Moved this change up into the CONFIG_OF section to account
for changes to the probing code.

Signed-off-by: Corey Minyard

ipmi: Compensate for BMCs that wont set the irq enable bit

2015-09-03T20:02:30+00:00

It appears that some BMCs support interrupts but don't support setting
the irq enable bits.  The interrupts are just always on.  Sigh.
Add code to compensate.

The new code was very similar to another functions, so this also
factors out the common code into other functions.

Signed-off-by: Corey Minyard 
Tested-by: Henrik Korkuc

ipmi: Don't flush messages in sender() in run-to-completion mode

2015-09-03T20:02:28+00:00

When flushing queued messages in run-to-completion mode,
smi_event_handler() is recursively called.

flush_messages()
 smi_event_handler()
  handle_transaction_done()
   deliver_recv_msg()
    ipmi_smi_msg_received()
     smi_recv_tasklet()
      sender()
       flush_messages()
        smi_event_handler()
         ...

The depth of the recursive call depends on the number of queued
messages, so it can cause a stack overflow if many messages have
been queued.

To solve this problem, this patch removes flush_messages()
from sender()@ipmi_si_intf.c.  Instead, add flush_messages() to
caller side of sender() if needed.  Additionally, to implement this,
add new handler flush_messages to struct ipmi_smi_handlers.

Signed-off-by: Hidehiro Kawai 

Fixed up a comment and some spacing issues.

Signed-off-by: Corey Minyard

ipmi: Factor out message flushing procedure

2015-09-03T20:02:28+00:00

Factor out message flushing procedure which is used in run-to-completion
mode.  This patch doesn't change the logic.

Signed-off-by: Hidehiro Kawai 
Signed-off-by: Corey Minyard

ipmi: Make some data const that was only read

2015-09-03T20:02:27+00:00

Several data structures were only used for reading, so make them
const.

Signed-off-by: Corey Minyard

ipmi: Delete an unnecessary check before the function call "cleanup_one_si"

2015-09-03T20:02:25+00:00

The cleanup_one_si() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Corey Minyard