linux-toradex.git/drivers/char/ipmi, branch v2.6.27.10 Linux kernel for Apalis and Colibri modules Fix platform drivers that crash on suspend/resume 2008-11-20T22:54:44+00:00 Darrick J. Wong djwong@us.ibm.com 2008-11-12T21:25:00+00:00 095d1c96367e0af6b566c9ec7eeae62f0a57d64e commit fe2d5ffc74a1de6a31e9fd65b65cce72d881edf7 upstream. It turns out that if one registers a struct platform_device, the platform device code expects that platform_device.device->driver points to a struct driver inside a struct platform_driver. This is not the case with the ipmi-si, ipmi-msghandler and ibmaem drivers, which causes the suspend/resume hook functions to jump off into nowhere, causing a crash. Make this assumption hold true for these three drivers. Signed-off-by: Darrick J. Wong <djwong@us.ibm.com> Acked-by: Corey Minyard <cminyard@mvista.com> Cc: Jean Delvare <khali@linux-fr.org> Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
commit fe2d5ffc74a1de6a31e9fd65b65cce72d881edf7 upstream.

It turns out that if one registers a struct platform_device, the
platform device code expects that platform_device.device->driver points
to a struct driver inside a struct platform_driver.

This is not the case with the ipmi-si, ipmi-msghandler and ibmaem
drivers, which causes the suspend/resume hook functions to jump off into
nowhere, causing a crash.  Make this assumption hold true for these
three drivers.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
ipmi: add MODULE_ALIAS to load ipmi_devintf with ipmi_si 2008-11-07T03:05:37+00:00 Scott James Remnant scott@canonical.com 2008-10-30T19:10:04+00:00 2ed0ed09a6bb5dcb4c497908d2873e3c6096f27f commit 6c89161b10f5771ee0b51ada0fce0e8835e72ade upstream The ipmi_devintf module contains the userspace interface for IPMI devices, yet will not be loaded automatically with a system interface handler driver. Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by the ipmi_si driver, so that userspace knows of the recommendation. Signed-off-by: Scott James Remnant <scott@ubuntu.com> Cc: Tim Gardner <tcanonical@tpi.com> Cc: Corey Minyard <minyard@acm.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
commit 6c89161b10f5771ee0b51ada0fce0e8835e72ade upstream

The ipmi_devintf module contains the userspace interface for IPMI devices,
yet will not be loaded automatically with a system interface handler
driver.

Add a MODULE_ALIAS for the "platform:ipmi_si" MODALIAS exported by the
ipmi_si driver, so that userspace knows of the recommendation.

Signed-off-by: Scott James Remnant <scott@ubuntu.com>
Cc: Tim Gardner <tcanonical@tpi.com>
Cc: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/ipmi/ipmi_si_intf.c:default_find_bmc(): fix leak 2008-08-20T22:40:31+00:00 Andrew Morton akpm@linux-foundation.org 2008-08-20T21:09:14+00:00 a09f48551273ee89d4e9ae37474807dc2da1d757 If check_legacy_ioport() returns true, we leak *info. Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11362 Reported-by: Daniel Marjamki <danielm77@spray.se> Cc: Christian Krafft <krafft@de.ibm.com> Cc: Michael Ellerman <michael@ellerman.id.au> Cc: Corey Minyard <minyard@acm.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
If check_legacy_ioport() returns true, we leak *info.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11362

Reported-by: Daniel Marjamki <danielm77@spray.se>
Cc: Christian Krafft <krafft@de.ibm.com>
Cc: Michael Ellerman <michael@ellerman.id.au>
Cc: Corey Minyard <minyard@acm.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
ipmi/powerpc: Use linux/of_{device,platform}.h instead of asm 2008-07-30T05:26:53+00:00 Stephen Rothwell sfr@canb.auug.org.au 2008-05-23T06:22:42+00:00 11c675cef2fbe471dc6103a89b156e65c3630f3a Drivers should not include the asm variants anymore Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> 
Drivers should not include the asm variants anymore

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
device create: char: convert device_create to device_create_drvdata 2008-07-22T04:54:41+00:00 Greg Kroah-Hartman gregkh@suse.de 2008-05-21T19:52:33+00:00 47aa5793f78c274d51711f6a621fa6b02d4e6402 device_create() is race-prone, so use the race-free device_create_drvdata() instead as device_create() is going away. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Merge commit 'v2.6.26' into bkl-removal 2008-07-14T21:29:34+00:00 Jonathan Corbet corbet@lwn.net 2008-07-14T21:29:34+00:00 2fceef397f9880b212a74c418290ce69e7ac00eb 






[PATCH] IPMI: return correct value from ipmi_write
2008-07-11T20:31:05+00:00

Mark Rustad
Rustad@gmail.com

2008-07-10T19:27:11+00:00

3976df9b04c113ab19dc0268e49c6cec6baf28f7

This patch corrects the handling of write operations to the IPMI watchdog
to work as intended by returning the number of characters actually
processed. Without this patch, an "echo V >/dev/watchdog" enables the
watchdog if IPMI is providing the watchdog function.

Signed-off-by: Mark Rustad <MRustad@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>






This patch corrects the handling of write operations to the IPMI watchdog
to work as intended by returning the number of characters actually
processed. Without this patch, an "echo V >/dev/watchdog" enables the
watchdog if IPMI is providing the watchdog function.

Signed-off-by: Mark Rustad <MRustad@gmail.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>








ipmi: fasync BKL pushdown
2008-07-02T21:06:28+00:00

Jonathan Corbet
corbet@lwn.net

2008-06-23T23:00:14+00:00

70b028b7ea94f1b36c61f3ee1c921cc3a87812e6

This driver really needs it to avoid races against open()

Signed-off-by: Jonathan Corbet <corbet@lwn.net>





This driver really needs it to avoid races against open()

Signed-off-by: Jonathan Corbet <corbet@lwn.net>







ipmi-watchdog: BKL pushdown
2008-06-20T20:05:58+00:00

Arnd Bergmann
arnd@arndb.de

2008-05-20T17:16:04+00:00

af96f0103d332be92c42a44accf731da667ecc03

Signed-off-by: Arnd Bergmann <arnd@arndb.de>





Signed-off-by: Arnd Bergmann <arnd@arndb.de>







ipmi: cdev lock_kernel() pushdown
2008-06-20T20:05:47+00:00

Jonathan Corbet
corbet@lwn.net

2008-05-15T16:46:49+00:00

ecc38983f6c83f371fefb5a69a72e358fc7b1218

Signed-off-by: Jonathan Corbet <corbet@lwn.net>





Signed-off-by: Jonathan Corbet <corbet@lwn.net>