linux-toradex.git/drivers/char/isicom.c, branch v2.6.27.3

isicom: restore using hardware break support

2008-07-22T20:03:28+00:00

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

tty: add more tty_port fields

2008-07-21T00:12:38+00:00

Move more bits into the tty_port structure

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

isicom: use tty_port

2008-07-21T00:12:37+00:00

Switch isicom to use a tty_port structure for some fields

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

tty: isicom, enable/disable pci device

2008-07-21T00:12:34+00:00

Don't forget to enable and disable PCI devices.  The device might be
unusable without that.

Signed-off-by: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

isicom: fix buffer allocation

2008-04-30T15:29:47+00:00

Fix the rather strange buffer management on open that turned up while auditing
for BKL dependencies.

Signed-off-by: Alan Cox 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tty: The big operations rework

2008-04-30T15:29:47+00:00

- Operations are now a shared const function block as with most other Linux
  objects

- Introduce wrappers for some optional functions to get consistent behaviour

- Wrap put_char which used to be patched by the tty layer

- Document which functions are needed/optional

- Make put_char report success/fail

- Cache the driver->ops pointer in the tty as tty->ops

- Remove various surplus lock calls we no longer need

- Remove proc_write method as noted by Alexey Dobriyan

- Introduce some missing sanity checks where certain driver/ldisc
  combinations would oops as they didn't check needed methods were present

[akpm@linux-foundation.org: fix fs/compat_ioctl.c build]
[akpm@linux-foundation.org: fix isicom]
[akpm@linux-foundation.org: fix arch/ia64/hp/sim/simserial.c build]
[akpm@linux-foundation.org: fix kgdb]
Signed-off-by: Alan Cox 
Acked-by: Greg Kroah-Hartman 
Cc: Jason Wessel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

isicom: bring into coding style

2008-04-30T15:29:47+00:00

[akpm@linux-foundation.org: fix arm, cleanups]
Signed-off-by: Alan Cox 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tty/serial: lay the foundations for the next set of reworks

2008-04-30T15:29:45+00:00

- Stop drivers calling their own flush method indirectly, it obfuscates code
  and it will change soon anyway

- A few more lock_kernel paths temporarily needed in some driver internal
  waiting code

- Remove private put_char method that does a write call for one char - we
  have that anyway

- Most but not yet all of the termios copy under lock fixing (some has other
  dependencies to follow)

- Note a few locking bugs in drivers found in the process

- Kill remaining [ab]users of TIOCG/SSOFTCAR in the driver, these must go to
  fix the termios locking

Signed-off-by: Alan Cox 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

isicom: prepare for lock_kernel push down

2008-04-30T15:29:39+00:00

Again lock the bits we can't trivially prove are safe without the BKL and
remove the broken TIOCS/GSOFTCAR handler.

Signed-off-by: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/char/isicom.c: correct use of ! and &

2008-03-05T00:35:15+00:00

In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337 ("wmi: (!x & y)
strikes again"), a bug was fixed that involved converting !x & y to !(x
& y).  The code below shows the same pattern, and thus should perhaps be
fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// 
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// 

Signed-off-by: Julia Lawall 
Cc: Jiri Slaby 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds