linux-toradex.git/drivers/char/synclink.c, branch v2.6.34.3 Linux kernel for Apalis and Colibri modules Char: synclink, remove unnecessary checks 2010-03-02T22:43:16+00:00 Jiri Slaby jslaby@suse.cz 2010-01-10T11:30:16+00:00 ca1cce49c2778439d00bbf516f70386f3d3b71e5 Stanse found a potential null dereference in mgsl_put_char and mgsl_write. There is a check for tty being NULL, but it is dereferenced earlier. Actually, tty cannot be NULL in .write and .put_char, so remove the tests. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Stanse found a potential null dereference in mgsl_put_char and
mgsl_write. There is a check for tty being NULL, but it is
dereferenced earlier.

Actually, tty cannot be NULL in .write and .put_char, so remove
the tests.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
hdlc: convert to netdev_tx_t 2009-09-01T08:13:31+00:00 Stephen Hemminger shemminger@vyatta.com 2009-08-31T19:50:48+00:00 4c5d502d8b2db8947c44dc44bdc67dbe55cce2b9 Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net> 
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
headers: smp_lock.h redux 2009-07-12T19:22:34+00:00 Alexey Dobriyan adobriyan@gmail.com 2009-07-11T18:08:37+00:00 405f55712dfe464b3240d7816cc4fe4174831be2 * Remove smp_lock.h from files which don't need it (including some headers!) * Add smp_lock.h to files which do need it * Make smp_lock.h include conditional in hardirq.h It's needed only for one kernel_locked() usage which is under CONFIG_PREEMPT This will make hardirq.h inclusion cheaper for every PREEMPT=n config (which includes allmodconfig/allyesconfig, BTW) Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
* Remove smp_lock.h from files which don't need it (including some headers!)
* Add smp_lock.h to files which do need it
* Make smp_lock.h include conditional in hardirq.h
  It's needed only for one kernel_locked() usage which is under CONFIG_PREEMPT

  This will make hardirq.h inclusion cheaper for every PREEMPT=n config
  (which includes allmodconfig/allyesconfig, BTW)

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
tty: Add carrier processing on close to the tty_port core 2009-06-11T15:50:56+00:00 Alan Cox alan@lxorguk.ukuu.org.uk 2009-06-11T11:24:17+00:00 fcc8ac1825d3d0fb81f73bc1a80ebc863168bb56 Some drivers implement this internally, others miss it out. Push the behaviour into the core code as that way everyone will do it consistently. Update the dtr rts method to raise or lower depending upon flags. Having a single method in this style fits most of the implementations more cleanly than two funtions. We need this in place before we tackle the USB side Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Some drivers implement this internally, others miss it out. Push the
behaviour into the core code as that way everyone will do it consistently.

Update the dtr rts method to raise or lower depending upon flags. Having a
single method in this style fits most of the implementations more cleanly than
two funtions.

We need this in place before we tackle the USB side

Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
proc tty: switch synclink to ->proc_fops 2009-04-01T15:59:09+00:00 Alexey Dobriyan adobriyan@gmail.com 2009-03-31T22:19:18+00:00 d337829bd841974045846ec8b428f4199453159e Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
WAN: Convert generic HDLC drivers to netdev_ops. 2009-01-21T22:03:37+00:00 Krzysztof Hałasa khc@pm.waw.pl 2009-01-08T21:52:11+00:00 991990a12de42281f81b4e3a6471586d2d0caf6a Also remove unneeded last_rx update from Synclink drivers. Synclink part mostly by Stephen Hemminger. Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl> Signed-off-by: David S. Miller <davem@davemloft.net> 
Also remove unneeded last_rx update from Synclink drivers.
Synclink part mostly by Stephen Hemminger.

Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
tty: Remove some pointless casts 2009-01-02T18:19:40+00:00 Alan Cox alan@redhat.com 2009-01-02T13:47:26+00:00 c9f19e96a2f33cd56c2bd19f87a0c4982d011c2b disc_data and driver_data are void * Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
disc_data and driver_data are void *

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
tty: Introduce some close helpers for ports 2009-01-02T18:19:40+00:00 Alan Cox alan@redhat.com 2009-01-02T13:46:50+00:00 a6614999e800cf3a134ce93ea46ef837e3c0e76e Again this is a lot of common code we can unify Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Again this is a lot of common code we can unify

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
tty: Introduce a tty_port generic block_til_ready 2009-01-02T18:19:39+00:00 Alan Cox alan@redhat.com 2009-01-02T13:46:10+00:00 36c621d82b956ff6ff72273f848af53e6c581aba Start sucking more commonality out of the drivers into a single piece of core code. Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Start sucking more commonality out of the drivers into a single piece of
core code.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
tty: Pull the dtr raise into tty port 2009-01-02T18:19:38+00:00 Alan Cox alan@redhat.com 2009-01-02T13:45:19+00:00 5d951fb458f847e5485b5251597fbf326000bb3b This moves another per device special out of what should be shared open wait paths into private methods Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
This moves another per device special out of what should be shared open
wait paths into private methods

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>