linux-toradex.git/drivers/char/tlclk.c, branch v6.3

drivers: char: tlclk.c: Avoid data race between init and interrupt handler

2020-04-23T14:55:24+00:00

After registering character device the file operation callbacks can be
called. The open callback registers interrupt handler.
Therefore interrupt handler can execute in parallel with rest of the init
function. To avoid such data race initialize telclk_interrupt variable
and struct alarm_events before registering character device.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Madhuparna Bhowmik 
Link: https://lore.kernel.org/r/20200417153451.1551-1-madhuparnabhowmik10@gmail.com
Signed-off-by: Greg Kroah-Hartman

tlclk: clean an indentation issue, remove extraneous tabs

2018-11-11T20:58:27+00:00

Trivial fix to clean up an indentation issue, remove tabs

Signed-off-by: Colin Ian King 
Signed-off-by: Greg Kroah-Hartman

timer: Remove last user of TIMER_INITIALIZER

2017-10-05T13:01:18+00:00

Drops the last user of TIMER_INITIALIZER and adapts timer.h to use the
internal version.

Signed-off-by: Kees Cook 
Signed-off-by: Thomas Gleixner 
Cc: linux-mips@linux-mips.org
Cc: Petr Mladek 
Cc: Benjamin Herrenschmidt 
Cc: Lai Jiangshan 
Cc: Sebastian Reichel 
Cc: Kalle Valo 
Cc: Paul Mackerras 
Cc: Pavel Machek 
Cc: linux1394-devel@lists.sourceforge.net
Cc: Chris Metcalf 
Cc: linux-s390@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: Mark Gross 
Cc: Wim Van Sebroeck 
Cc: Michael Ellerman 
Cc: Ursula Braun 
Cc: Geert Uytterhoeven 
Cc: Viresh Kumar 
Cc: Harish Patil 
Cc: Stephen Boyd 
Cc: Michael Reed 
Cc: Manish Chopra 
Cc: Len Brown 
Cc: Arnd Bergmann 
Cc: linux-pm@vger.kernel.org
Cc: Heiko Carstens 
Cc: Tejun Heo 
Cc: Julian Wiedmann 
Cc: John Stultz 
Cc: "James E.J. Bottomley" 
Cc: linux-watchdog@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: "Martin K. Petersen" 
Cc: Greg Kroah-Hartman 
Cc: "Rafael J. Wysocki" 
Cc: Oleg Nesterov 
Cc: Ralf Baechle 
Cc: Stefan Richter 
Cc: Guenter Roeck 
Cc: netdev@vger.kernel.org
Cc: Martin Schwidefsky 
Cc: Andrew Morton 
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Sudip Mukherjee 
Link: https://lkml.kernel.org/r/1507159627-127660-8-git-send-email-keescook@chromium.org

char: tlclk: constify attribute_group structures.

2017-08-28T15:15:16+00:00

attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by  work with
const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav 
Signed-off-by: Greg Kroah-Hartman

Replace with globally

2016-12-24T19:46:01+00:00

This was entirely automated, using the script by Al:

  PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*'
  sed -i -e "s!$PATT!#include !" \
        $(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h)

to do the replacement at the end of the merge window.

Requested-by: Al Viro 
Signed-off-by: Linus Torvalds

tlclk: remove deprecated IRQF_DISABLED

2013-10-16T19:36:10+00:00

This patch proposes to remove the use of the IRQF_DISABLED flag

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker 
Acked-by: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman

drivers/char/tlclk.c: fix error return code

2012-08-16T17:09:15+00:00

Convert a 0 error return code to a negative one, as returned elsewhere in the
function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@@
identifier ret;
expression e,e1,e2,e3,e4,x;
@@

(
if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
|
ret = 0
)
... when != ret = e1
*x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
... when != x = e2
    when != ret = e3
*if (x == NULL || ...)
{
  ... when != ret = e4
*  return ret;
}
// 

Signed-off-by: Julia Lawall 
Acked-by: Mark Gross 
Cc: Arnd Bergmann 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

char: Fix typo in tlclk.c

2012-02-09T16:49:51+00:00

Correct spelling "telclk_interrup" to "telclk_interrupt" in
drivers/char/tlclk.c

Signed-off-by: Masanari Iida 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl

2010-10-22T17:52:56+00:00

* 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl:
  vfs: make no_llseek the default
  vfs: don't use BKL in default_llseek
  llseek: automatically add .llseek fop
  libfs: use generic_file_llseek for simple_attr
  mac80211: disallow seeks in minstrel debug code
  lirc: make chardev nonseekable
  viotape: use noop_llseek
  raw: use explicit llseek file operations
  ibmasmfs: use generic_file_llseek
  spufs: use llseek in all file operations
  arm/omap: use generic_file_llseek in iommu_debug
  lkdtm: use generic_file_llseek in debugfs
  net/wireless: use generic_file_llseek in debugfs
  drm: use noop_llseek

tlclk: remove big kernel lock

2010-10-19T09:29:54+00:00

This driver already has a global mutex, so let's just
use that in the open function instead of the BKL.
It may not even be needed there, but this patch should
have the smallest impact.

Signed-off-by: Arnd Bergmann 
Cc: Mark Gross