linux-toradex.git/drivers/char/tpm/tpm-dev-common.c, branch v5.12

tpm: Remove tpm_dev_wq_lock

2021-02-16T08:40:27+00:00

Never used since it was added.

Fixes: 9e1b74a63f776 ("tpm: add support for nonblocking operation")
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Thomas Gleixner 
Cc: linux-integrity@vger.kernel.org
Cc: Jason Gunthorpe 
Cc: Philip Tricca 
Cc: Tadeusz Struk 
Cc: Jarkko Sakkinen 
Signed-off-by: Jarkko Sakkinen

tpm: Fix TIS locality timeout problems

2020-07-02T14:48:59+00:00

It has been reported that some TIS based TPMs are giving unexpected
errors when using the O_NONBLOCK path of the TPM device. The problem
is that some TPMs don't like it when you get and then relinquish a
locality (as the tpm_try_get_ops()/tpm_put_ops() pair does) without
sending a command.  This currently happens all the time in the
O_NONBLOCK write path. Fix this by moving the tpm_try_get_ops()
further down the code to after the O_NONBLOCK determination is made.
This is safe because the priv->buffer_mutex still protects the priv
state being modified.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206275
Fixes: d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode")
Reported-by: Mario Limonciello 
Tested-by: Alex Guzman 
Cc: stable@vger.kernel.org
Reviewed-by: Jerry Snitselaar 
Signed-off-by: James Bottomley 
Reviewed-by: Jarkko Sakkinen 
Signed-off-by: Jarkko Sakkinen

tpm: Handle negative priv->response_len in tpm_common_read()

2020-01-08T16:11:09+00:00

The priv->response_length can hold the size of an response or an negative
error code, and the tpm_common_read() needs to handle both cases correctly.
Changed the type of response_length to signed and accounted for negative
value in tpm_common_read().

Cc: stable@vger.kernel.org
Fixes: d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode")
Reported-by: Laura Abbott 
Signed-off-by: Tadeusz Struk 
Reviewed-by: Jarkko Sakkinen 
Signed-off-by: Jarkko Sakkinen

tpm: fix invalid locking in NONBLOCKING mode

2019-12-17T10:20:04+00:00

When an application sends TPM commands in NONBLOCKING mode
the driver holds chip->tpm_mutex returning from write(),
which triggers: "WARNING: lock held when returning to user space".
To fix this issue the driver needs to release the mutex before
returning and acquire it again in tpm_dev_async_work() before
sending the command.

Cc: stable@vger.kernel.org
Fixes: 9e1b74a63f776 (tpm: add support for nonblocking operation)
Reported-by: Jeffrin Jose T 
Tested-by: Jeffrin Jose T 
Signed-off-by: Tadeusz Struk 
Reviewed-by: Jarkko Sakkinen 
Signed-off-by: Jarkko Sakkinen

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441

2019-06-05T15:37:17+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation version 2 of the license

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 315 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Armijn Hemel 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190531190115.503150771@linutronix.de
Signed-off-by: Greg Kroah-Hartman

tpm: fix an invalid condition in tpm_common_poll

2019-04-08T22:58:53+00:00

The poll condition should only check response_length,
because reads should only be issued if there is data to read.
The response_read flag only prevents double writes.
The problem was that the write set the response_read to false,
enqued a tpm job, and returned. Then application called poll
which checked the response_read flag and returned EPOLLIN.
Then the application called read, but got nothing.
After all that the async_work kicked in.
Added also mutex_lock around the poll check to prevent
other possible race conditions.

Fixes: 9488585b21bef0df12 ("tpm: add support for partial reads")
Reported-by: Mantas Mikulėnas 
Tested-by: Mantas Mikulėnas 
Signed-off-by: Tadeusz Struk 
Reviewed-by: Jarkko Sakkinen 
Signed-off-by: Jarkko Sakkinen 
Signed-off-by: James Morris

tpm: remove @flags from tpm_transmit()

2019-02-13T07:48:46+00:00

Remove @flags from tpm_transmit() API. It is no longer used for
anything.

Signed-off-by: Jarkko Sakkinen 
Reviewed-by: Stefan Berger 
Tested-by: Stefan Berger 
Reviewed-by: Jerry Snitselaar 
Reviewed-by: James Bottomley 
Tested-by: Alexander Steffen

tpm: remove TPM_TRANSMIT_UNLOCKED flag

2019-02-13T07:48:28+00:00

Added locking as part of tpm_try_get_ops() and tpm_put_ops() as they are
anyway used in most of the call sites except in tpmrm_release() where we
take the locks manually.

Signed-off-by: Jarkko Sakkinen 
Reviewed-by: Stefan Berger 
Tested-by: Stefan Berger 
Reviewed-by: Jerry Snitselaar 
Reviewed-by: James Bottomley 
Tested-by: Alexander Steffen

tpm: remove @space from tpm_transmit()

2019-02-13T07:48:12+00:00

Remove @space from tpm_transmit() API` in order to completely remove the
bound between low-level transmission functionality and TPM spaces. The
only real dependency existing is the amount of data saved before trying
to send a command to the TPM.

It doesn't really matter if we save always a bit more than needed so
this commit changes the amount saved always to be the size of the TPM
header and three handles.

Cc: James Bottomley 
Signed-off-by: Jarkko Sakkinen 
Reviewed-by: Stefan Berger 
Tested-by: Stefan Berger 
Reviewed-by: Jerry Snitselaar 
Reviewed-by: James Bottomley 
Tested-by: Alexander Steffen

tpm: move TPM space code out of tpm_transmit()

2019-02-13T07:48:07+00:00

Prepare and commit TPM space before and after calling tpm_transmit()
instead of doing that inside tpm_transmit(). After this change we can
remove TPM_TRANSMIT_NESTED flag from tpm2_prepare_space() and
tpm2_commit_space() and replace it with TPM_TRANSMIT_UNLOCKED.

Cc: James Bottomley 
Signed-off-by: Jarkko Sakkinen 
Reviewed-by: Stefan Berger 
Tested-by: Stefan Berger 
Reviewed-by: Jerry Snitselaar 
Reviewed-by: James Bottomley 
Tested-by: Alexander Steffen