linux-toradex.git/drivers/char/tpm, branch tegra

TPM: Zero buffer after copying to userspace

2011-09-22T23:46:41+00:00

Since the buffer might contain security related data it might be a good idea to
zero the buffer after we have copied it to userspace.

This got assigned CVE-2011-1162.

Signed-off-by: Rajiv Andrade 
Cc: Stable Kernel 
Signed-off-by: James Morris

TPM: Call tpm_transmit with correct size

2011-09-22T23:46:29+00:00

This patch changes the call of tpm_transmit by supplying the size of the
userspace buffer instead of TPM_BUFSIZE.

This got assigned CVE-2011-1161.

[The first hunk didn't make sense given one could expect
 way less data than TPM_BUFSIZE, so added tpm_transmit boundary
 check over bufsiz instead
 The last parameter of tpm_transmit() reflects the amount
 of data expected from the device, and not the buffer size
 being supplied to it. It isn't ideal to parse it directly,
 so we just set it to the maximum the input buffer can handle
 and let the userspace API to do such job.]

Signed-off-by: Rajiv Andrade 
Cc: Stable Kernel 
Signed-off-by: James Morris

TPM: tpm_nsc: Fix a double free of pdev in cleanup_nsc

2011-09-22T23:46:17+00:00

platform_device_unregister() will release all resources
and remove it from the subsystem, then drop reference count by
calling platform_device_put().

We should not call kfree(pdev) after platform_device_unregister(pdev).

Signed-off-by: Axel Lin 
Signed-off-by: Rajiv Andrade 
Signed-off-by: James Morris

TPM: TCG_ATMEL should depend on HAS_IOPORT

2011-09-22T23:45:57+00:00

On m68k, I get:

drivers/char/tpm/tpm_atmel.h: In function ‘atmel_get_base_addr’:
drivers/char/tpm/tpm_atmel.h:129: error: implicit declaration of function ‘ioport_map’
drivers/char/tpm/tpm_atmel.h:129: warning: return makes pointer from integer without a cast

The code in tpm_atmel.h supports PPC64 (using the device tree and ioremap())
and "anything else" (using ioport_map()). However, ioportmap() is only
available on platforms that set HAS_IOPORT.

Although PC64 seems to have HAS_IOPORT, a "depends on HAS_IOPORT" should work,
but I think it's better to expose the special PPC64 handling explicit using
"depends on PPC64 || HAS_IOPORT".

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Rajiv Andrade 
Signed-off-by: James Morris

tpm_tis: fix build when ACPI is not enabled

2011-08-04T00:25:21+00:00

Fix tpm_tis.c build when CONFIG_ACPI is not enabled by providing a stub
function.  Fixes many build errors/warnings:

  drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
  drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
  drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
  ...

Signed-off-by: Randy Dunlap 
Cc: Leendert van Doorn 
Cc: James Morris 
Cc: Ingo Molnar 
Cc: Stephen Rothwell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

tpm_nsc: Fix bug when loading multiple TPM drivers

2011-07-26T00:34:34+00:00

This patch fixes kernel bugzilla 34572.

https://bugzilla.kernel.org/show_bug.cgi?id=34572

Signed-off-by: Stefan Berger 
Reported-by: Witold Baryluk 
Tested-by: Witold Baryluk 
Signed-off-by: James Morris

tpm: Move tpm_tis_reenable_interrupts out of CONFIG_PNP block

2011-07-22T07:33:24+00:00

This patch moves the tpm_tis_reenable_interrupts function out of the
CONFIG_PNP-surrounded #define block. This solves a compilation error in
case CONFIG_PNP is not defined.

Signed-off-by: Stefan Berger 
Reported-by: Randy Dunlap 
Acked-by: Randy Dunlap 
Signed-off-by: James Morris

tpm: Fix compilation warning when CONFIG_PNP is not defined

2011-07-20T23:29:56+00:00

The is_itpm() function is only accessed from a block surrounded by
#ifdef CONFIG_PNP. Therefore, also surround it with #ifdef CONFIG_PNP
and remove the #else branch causing the warning.

http://lxr.linux.no/#linux+v2.6.39/drivers/char/tpm/tpm_tis.c#L622

v2:
 - fixes a previous typo

Signed-off-by: Stefan Berger 
Reported-by: Randy Dunlap 
Signed-off-by: James Morris

tpm: Fix a typo

2011-07-12T21:53:09+00:00

This patch fixes a typo.

Signed-off-by: Stefan Berger 
Signed-off-by: Rajiv Andrade

tpm_tis: Probing function for Intel iTPM bug

2011-07-12T21:53:09+00:00

This patch introduces a function for automatic probing for the Intel iTPM
STS_DATA_EXPECT flaw.

The patch splits the current tpm_tis_send function into 2 parts where the 1st
part is now called tpm_tis_send_data() and merely sends the data to the TPM.
This function is then used for probing. The new tpm_tis_send function now
first calls tpm_tis_send_data and if that succeeds has the TPM process the
command and waits until the response is there.

The probing for the Intel iTPM is only invoked if the user has not passed
itpm=1 as parameter for the module *or* if such a TPM was detected via ACPI.
Previously it was necessary to pass itpm=1 when also passing force=1 to the
module when doing a 'modprobe'. This function is more general than the ACPI
test function and the function relying on ACPI could probably be removed.

Signed-off-by: Stefan Berger 
Signed-off-by: Rajiv Andrade