linux-toradex.git/drivers/char/virtio_console.c, branch v3.13.8

virtio_console: verify if queue is broken after virtqueue_get_buf()

2013-10-29T00:58:18+00:00

If virtqueue_get_buf() returns with a NULL pointer it should be verified
if the virtqueue is broken, in order to avoid loop calling cpu_relax().

Signed-off-by: Heinz Graalfs 
Signed-off-by: Rusty Russell

virtio: use size-based config accessors.

2013-10-17T00:25:37+00:00

This lets the transport do endian conversion if necessary, and insulates
the drivers from the difference.

Most drivers can use the simple helpers virtio_cread() and virtio_cwrite().

Signed-off-by: Rusty Russell

virtio: pm: use CONFIG_PM_SLEEP instead of CONFIG_PM

2013-09-23T06:15:58+00:00

The freeze and restore functions defined in virtio drivers are used
for suspend and hibernate, so CONFIG_PM_SLEEP is more appropriate than
CONFIG_PM. This patch replace all CONFIG_PM with CONFIG_PM_SLEEP for
virtio drivers that implement freeze and restore callbacks.

Signed-off-by: Aaron Lu 
Reviewed-by: Amit Shah 
Signed-off-by: Rusty Russell

virtio: console: prevent use-after-free of port name in port unplug

2013-08-09T03:32:16+00:00

Remove the debugfs path before freeing port->name, to prevent a possible
use-after-free.

Reported-by: Jason Wang 
Signed-off-by: Amit Shah 
Signed-off-by: Rusty Russell

Merge branch 'master' into virtio-next

2013-08-09T03:30:39+00:00

The next commit gets conflicts because it relies on patches which were
cc:stable and thus had to be merged into Linus' tree before the coming
merge window.  So pull in master now.

Signed-off-by: Rusty Russell

virtio: console: cleanup an error message

2013-07-30T06:24:30+00:00

The PTR_ERR(NULL) here is not useful.

Signed-off-by: Dan Carpenter 
Reviewed-by: Amit Shah 
Signed-off-by: Rusty Russell

virtio: console: fix locking around send_sigio_to_port()

2013-07-29T05:20:49+00:00

send_sigio_to_port() checks the value of guest_connected, which we
always modify under the inbuf_lock; make sure invocations of
send_sigio_to_port() have take the inbuf_lock around the call.

Signed-off-by: Amit Shah 
Signed-off-by: Rusty Russell

virtio: console: add locking in port unplug path

2013-07-29T05:20:48+00:00

Port unplug can race with close() in port_fops_release().
port_fops_release() already takes the necessary locks, ensure
unplug_port() does that too.

Signed-off-by: Amit Shah 
Signed-off-by: Rusty Russell

virtio: console: add locks around buffer removal in port unplug path

2013-07-29T05:20:47+00:00

The removal functions act on the vqs, and the vq operations need to be
locked.

Signed-off-by: Amit Shah 
Signed-off-by: Rusty Russell

virtio: console: return -ENODEV on all read operations after unplug

2013-07-29T05:13:58+00:00

If a port gets unplugged while a user is blocked on read(), -ENODEV is
returned.  However, subsequent read()s returned 0, indicating there's no
host-side connection (but not indicating the device went away).

This also happened when a port was unplugged and the user didn't have
any blocking operation pending.  If the user didn't monitor the SIGIO
signal, they won't have a chance to find out if the port went away.

Fix by returning -ENODEV on all read()s after the port gets unplugged.
write() already behaves this way.

CC: 
Signed-off-by: Amit Shah 
Signed-off-by: Rusty Russell