linux-toradex.git/drivers/clocksource/bcm_kona_timer.c, branch v6.19

clocksource/drivers/bcm_kona: Convert to SPDX identifier

2022-05-18T09:08:59+00:00

The license information clearly states GPL version 2 only. The extra text
which excludes warranties is a transcript of the corresponding GPLv2 clause
11, which is explicitely referenced for details.

So the SPDX identifier covers it completely.

Signed-off-by: Thomas Gleixner 
Cc: Daniel Lezcano 
Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Cc: Broadcom Kernel Team 
Cc: linux-spdx@vger.kernel.org
Acked-by: Florian Fainelli 
Link: https://lore.kernel.org/r/20220510171254.404209482@linutronix.de
Signed-off-by: Daniel Lezcano

clocksource: Replace setup_irq() by request_irq()

2020-02-27T11:15:24+00:00

request_irq() is preferred over setup_irq(). The early boot setup_irq()
invocations happen either via 'init_IRQ()' or 'time_init()', while
memory allocators are ready by 'mm_init()'.

Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.

Hence replace setup_irq() by request_irq().

Seldom remove_irq() usage has been observed coupled with setup_irq(),
wherever that has been found, it too has been replaced by free_irq().

A build error that was reported by kbuild test robot 
in the previous version of the patch also has been fixed.

[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos

Signed-off-by: afzal mohammed 
Signed-off-by: Daniel Lezcano 
Link: https://lore.kernel.org/r/91961c77c1cf93d41523f5e1ac52043f32f97077.1582799709.git.afzal.mohd.ma@gmail.com

clocksource/drivers: Rename CLOCKSOURCE_OF_DECLARE to TIMER_OF_DECLARE

2017-06-14T09:58:45+00:00

The CLOCKSOURCE_OF_DECLARE macro is used widely for the timers to declare the
clocksource at early stage. However, this macro is also used to initialize
the clockevent if any, or the clockevent only.

It was originally suggested to declare another macro to initialize a
clockevent, so in order to separate the two entities even they belong to the
same IP. This was not accepted because of the impact on the DT where splitting
a clocksource/clockevent definition does not make sense as it is a Linux
concept not a hardware description.

On the other side, the clocksource has not interrupt declared while the
clockevent has, so it is easy from the driver to know if the description is
for a clockevent or a clocksource, IOW it could be implemented at the driver
level.

So instead of dealing with a named clocksource macro, let's use a more generic
one: TIMER_OF_DECLARE.

The patch has not functional changes.

Signed-off-by: Daniel Lezcano 
Acked-by: Heiko Stuebner 
Acked-by: Neil Armstrong 
Acked-by: Arnd Bergmann 
Acked-by: Matthias Brugger 
Reviewed-by: Linus Walleij

clocksource: Add missing line break to error messages

2017-04-07T14:23:04+00:00

Printing with pr_* functions requires adding line break manually.

Signed-off-by: Rafał Miłecki 
Acked-by: Thierry Reding 
Signed-off-by: Daniel Lezcano

clocksource/drivers/kona: Fix get_counter() error handling

2016-08-17T11:08:31+00:00

I could not figure out why, but GCC cannot prove that the
kona_timer_init() function always initializes its two outputs,
and we get a warning for the use of the 'lsw' variable later,
which is obviously correct.

  drivers/clocksource/bcm_kona_timer.c: In function 'kona_timer_init':
  drivers/clocksource/bcm_kona_timer.c:119:13: error: 'lsw' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Slightly reordering the loop makes the warning disappear, after
it becomes more obvious to the compiler that the loop is
always entered on the first iteration.

As pointed out by Ray Jui, there is a related problem in the
way we deal with the loop running into the limit, as we just
keep going there with an invalid counter data, so instead we
now propagate a -ETIMEDOUT result to the caller.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Daniel Lezcano 
Acked-by: Ray Jui 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: bcm-kernel-feedback-list@broadcom.com
Link: http://lkml.kernel.org/r/1471429296-9053-2-git-send-email-daniel.lezcano@linaro.org
Link: https://patchwork.kernel.org/patch/9174261/
Signed-off-by: Ingo Molnar

clocksource/drivers/bcm_kona: Remove useless header

2016-06-28T08:22:03+00:00

The driver includes the  header but it is pointless.

Remove it.

Signed-off-by: Daniel Lezcano

clocksources: Switch back to the clksrc table

2016-06-28T08:19:35+00:00

All the clocksource drivers's init function are now converted to return
an error code. CLOCKSOURCE_OF_DECLARE is no longer used as well as the
clksrc-of table.

Let's convert back the names:
 - CLOCKSOURCE_OF_DECLARE_RET => CLOCKSOURCE_OF_DECLARE
 - clksrc-of-ret              => clksrc-of

Signed-off-by: Daniel Lezcano 

For exynos_mct and samsung_pwm_timer:
Acked-by: Krzysztof Kozlowski 

For arch/arc:
Acked-by: Vineet Gupta 

For mediatek driver:
Acked-by: Matthias Brugger 

For the Rockchip-part
Acked-by: Heiko Stuebner 

For STi :
Acked-by: Patrice Chotard 

For the mps2-timer.c and versatile.c changes:
Acked-by: Liviu Dudau 

For the OXNAS part :
Acked-by: Neil Armstrong 

For LPC32xx driver:
Acked-by: Sylvain Lemieux 

For Broadcom Kona timer change:
Acked-by: Ray Jui 

For Sun4i and Sun5i:
Acked-by: Chen-Yu Tsai 

For Meson6:
Acked-by: Carlo Caione 

For Keystone:
Acked-by: Santosh Shilimkar 

For NPS:
Acked-by: Noam Camus 

For bcm2835:
Acked-by: Eric Anholt

clocksource/drivers/bcm_kona: Convert init function to return error

2016-06-28T08:19:21+00:00

The init functions do not return any error. They behave as the following:

  - panic, thus leading to a kernel crash while another timer may work and
       make the system boot up correctly

  or

  - print an error and let the caller unaware if the state of the system

Change that by converting the init functions to return an error conforming
to the CLOCKSOURCE_OF_RET prototype.

Proper error handling (rollback, errno value) will be changed later case
by case, thus this change just return back an error or success in the init
function.

Signed-off-by: Daniel Lezcano 
Acked-by: Ray Jui

clockevents/drivers/bcm_kona: Migrate to new 'set-state' interface

2015-08-06T10:16:42+00:00

Migrate bcm_kona driver to the new 'set-state' interface provided by
the clockevents core, the earlier 'set-mode' interface is marked
obsolete now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

Oneshot callback isn't required as it was empty.

Acked-by: Ray Jui 
Cc: Florian Fainelli 
Cc: Ray Jui 
Cc: Scott Branden 
Cc: bcm-kernel-feedback-list@broadcom.com
Signed-off-by: Viresh Kumar 
Signed-off-by: Daniel Lezcano

clocksource: kona: fix __iomem annotation

2015-01-05T13:43:36+00:00

It makes no sense to hide the __iomem annotation from the function
that uses it, especially since it causes a sparse warning:

drivers/clocksource/bcm_kona_timer.c:118:38: warning: incorrect type in argument 1 (different address spaces)
drivers/clocksource/bcm_kona_timer.c:118:38:    expected void *timer_base
drivers/clocksource/bcm_kona_timer.c:118:38:    got void [noderef] *static [toplevel] tmr_regs

Signed-off-by: Olof Johansson 
Acked-by: Florian Fainelli 
Signed-off-by: Daniel Lezcano