linux-toradex.git/drivers/connector, branch v2.6.30.2

connector: create connector workqueue only while needed once

2009-02-03T07:22:04+00:00

The netlink connector uses its own workqueue to relay the datas sent
from userspace to the appropriate callback.  If you launch the test
from Documentation/connector and change it a bit to send a high flow
of data, you will see thousands of events coming to the "cqueue"
workqueue by looking at the workqueue tracer.

This flow of events can be sent very quickly. So, to not encumber the
kevent workqueue and delay other jobs, the "cqueue" workqueue should
remain.

But this workqueue is pointless most of the time, it will always be
created (assuming you have built it of course) although only
developpers with specific needs will use it.

So avoid this "most of the time useless task", this patch proposes to
create this workqueue only when needed once.  The first jobs to be
sent to connector callbacks will be sent to kevent while the "cqueue"
thread creation will be scheduled to kevent too.

The following jobs will continue to be scheduled to keventd until the
cqueue workqueue is created, and then the rest of the jobs will
continue to perform as usual, through this dedicated workqueue.

Each time I tested this patch, only the first event was sent to
keventd, the rest has been sent to cqueue which have been created
quickly.

Also, this patch fixes some trailing whitespaces on the connector files.

Signed-off-by: Frederic Weisbecker 
Acked-by: Evgeniy Polyakov 
Signed-off-by: David S. Miller

CRED: Use RCU to access another task's creds and to release a task's own creds

2008-11-13T23:39:19+00:00

Use RCU to access another task's creds and to release a task's own creds.
This means that it will be possible for the credentials of a task to be
replaced without another task (a) requiring a full lock to read them, and (b)
seeing deallocated memory.

Signed-off-by: David Howells 
Acked-by: James Morris 
Acked-by: Serge Hallyn 
Signed-off-by: James Morris

CRED: Separate task security context from task_struct

2008-11-13T23:39:16+00:00

Separate the task security context from task_struct.  At this point, the
security data is temporarily embedded in the task_struct with two pointers
pointing to it.

Note that the Alpha arch is altered as it refers to (E)UID and (E)GID in
entry.S via asm-offsets.

With comment fixes Signed-off-by: Marc Dionne 

Signed-off-by: David Howells 
Acked-by: James Morris 
Acked-by: Serge Hallyn 
Signed-off-by: James Morris

CONNECTOR: add a proc entry to list connectors

2008-06-28T03:03:24+00:00

I got a problem when I wanted to check if the kernel supports process
event connector, and It seems there's no way to do this check.

At best I can check if the kernel supports connector or not, by looking
into /proc/net/netlink, or maybe checking the return value of bind() to
see if it's ENOENT.

So it would be useful to add /proc/net/connector to list all supported
connectors:
 # cat /proc/net/connector
 Name            ID
 connector       4294967295:4294967295
 cn_proc         1:1
 w1              3:1

Changelog:
- fix memory leak: s/seq_release/single_release
- use spin_lock_bh instead of spin_lock_irqsave

Signed-off-by: Li Zefan 
Acked-by: Evgeniy Polyakov 
Signed-off-by: David S. Miller

connector: convert to single-threaded workqueue

2008-03-24T04:51:12+00:00

From: Evgeniy Polyakov 

We don't need one cqueue thread for each CPU.  cqueue is used for
receiving userspace datagrams, which are very rare and thus will
happily live with a single queue.

Signed-off-by: Andrew Morton 
Signed-off-by: David S. Miller

CONNECTOR: make cn_already_initialized static

2008-02-27T02:42:44+00:00

It is used in connector.c only, so make it static.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[NETNS]: Consolidate kernel netlink socket destruction.

2008-01-28T23:08:07+00:00

Create a specific helper for netlink kernel socket disposal. This just
let the code look better and provides a ground for proper disposal
inside a namespace.

Signed-off-by: Denis V. Lunev 
Tested-by: Alexey Dobriyan 
Signed-off-by: David S. Miller

[CONNECTOR]: Cleanup struct cn_callback_entry

2008-01-28T23:00:40+00:00

- 'cb' is a fake struct member. In a previous patch struct cn_callback
was renamed to cn_callback_id, so 'cb' should have been deleted at that
time.

- 'nls' isn't used and is redundant, we can retrieve this data through
cn_callback_entry.pdev->nls.

- 'seq' and 'group' should be u32, as they are declared to be u32 in
other places.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[CONNECTOR]: Cleanup struct cn_queue_dev

2008-01-28T23:00:39+00:00

Struct member netlink_groups is never used, and I don't see how it can
be useful.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller

[CONNECTOR]: clean up {,__}cn_rx_skb()

2008-01-28T23:00:38+00:00

- __cn_rx_skb() does nothing but calls cn_call_callback(), it doesn't
check skb and msg sizes as the comment suggests, but cn_rx_skb() checks
those sizes.

- In cn_rx_skb() Local variable 'len' is not used. 'len' is probably
intended to be passed to skb_pull(), but here skb_pull() is not needed,
instead skb_free() is called.

Signed-off-by: Li Zefan 
Signed-off-by: David S. Miller