linux-toradex.git/drivers/cpufreq/qcom-cpufreq-nvmem.c, branch v6.6-rc1

cpufreq: qcom-nvmem: Convert to platform remove callback returning void

2023-07-20T10:32:13+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König 
Signed-off-by: Yangtao Li 
Signed-off-by: Viresh Kumar

cpufreq: Explicitly include correct DT includes

2023-07-20T10:31:57+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Acked-by: Rafael J. Wysocki 
Signed-off-by: Viresh Kumar

cpufreq: qcom-nvmem: use helper to get SMEM SoC ID

2023-05-27T01:18:57+00:00

Now that SMEM exports a helper to get the SMEM SoC ID lets utilize it.
Currently qcom_cpufreq_get_msm_id() is encoding the returned SMEM SoC ID
into an enum, however there is no reason to do so and we can just match
directly on the SMEM SoC ID as returned by qcom_smem_get_soc_id().

Signed-off-by: Robert Marko 
Acked-by: Viresh Kumar 
Reviewed-by: Konrad Dybcio 
Signed-off-by: Bjorn Andersson 
Link: https://lore.kernel.org/r/20230526204802.3081168-5-robimarko@gmail.com

cpufreq: qcom-nvmem: use SoC ID-s from bindings

2023-05-27T01:18:57+00:00

SMEM SoC ID-s are now stored in DT bindings so lets use those instead of
defining them in the driver again.

Signed-off-by: Robert Marko 
Reviewed-by: Konrad Dybcio 
Reviewed-by: Bjorn Andersson 
Acked-by: Viresh Kumar 
Signed-off-by: Bjorn Andersson 
Link: https://lore.kernel.org/r/20230526204802.3081168-4-robimarko@gmail.com

cpufreq: qcom-nvmem: Switch to use dev_err_probe() helper

2022-10-18T10:52:26+00:00

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang 
Signed-off-by: Viresh Kumar

cpufreq: qcom: remove unused parameter in function definition

2022-10-18T10:52:25+00:00

The speedbin_nvmem parameter is not used for
get_krait_bin_format_{a,b}. Let's remove the parameter to make the code
cleaner.

Signed-off-by: Fabien Parent 
Signed-off-by: Viresh Kumar

cpufreq: qcom: fix writes in read-only memory region

2022-10-18T10:52:25+00:00

This commit fixes a kernel oops because of a write in some read-only memory:

	[    9.068287] Unable to handle kernel write to read-only memory at virtual address ffff800009240ad8
	..snip..
	[    9.138790] Internal error: Oops: 9600004f [#1] PREEMPT SMP
	..snip..
	[    9.269161] Call trace:
	[    9.276271]  __memcpy+0x5c/0x230
	[    9.278531]  snprintf+0x58/0x80
	[    9.282002]  qcom_cpufreq_msm8939_name_version+0xb4/0x190
	[    9.284869]  qcom_cpufreq_probe+0xc8/0x39c
	..snip..

The following line defines a pointer that point to a char buffer stored
in read-only memory:

	char *pvs_name = "speedXX-pvsXX-vXX";

This pointer is meant to hold a template "speedXX-pvsXX-vXX" where the
XX values get overridden by the qcom_cpufreq_krait_name_version function. Since
the template is actually stored in read-only memory, when the function
executes the following call we get an oops:

	snprintf(*pvs_name, sizeof("speedXX-pvsXX-vXX"), "speed%d-pvs%d-v%d",
		 speed, pvs, pvs_ver);

To fix this issue, we instead store the template name onto the stack by
using the following syntax:

	char pvs_name_buffer[] = "speedXX-pvsXX-vXX";

Because the `pvs_name` needs to be able to be assigned to NULL, the
template buffer is stored in the pvs_name_buffer and not under the
pvs_name variable.

Cc: v5.7+  # v5.7+
Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based socs")
Signed-off-by: Fabien Parent 
Signed-off-by: Viresh Kumar

cpufreq: qcom: fix memory leak in error path

2022-10-18T10:52:25+00:00

If for some reason the speedbin length is incorrect, then there is a
memory leak in the error path because we never free the speedbin buffer.
This commit fixes the error path to always free the speedbin buffer.

Cc: v5.7+  # v5.7+
Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based socs")
Signed-off-by: Fabien Parent 
Signed-off-by: Viresh Kumar

cpufreq: qcom-nvmem: Migrate to dev_pm_opp_set_config()

2022-07-08T05:57:32+00:00

The OPP core now provides a unified API for setting all configuration
types, i.e. dev_pm_opp_set_config().

Lets start using it.

Signed-off-by: Viresh Kumar

cpufreq: qcom-cpufreq-nvmem: fix reading of PVS Valid fuse

2022-02-09T07:50:03+00:00

The fuse consists of 64 bits, with this statement we're supposed to get
the upper 32 bits but it actually read out of bounds and got 0 instead
of the desired value which lead to the "PVS bin not set." codepath being
run resetting our pvs value.

Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based socs")
Signed-off-by: Luca Weiss 
Signed-off-by: Viresh Kumar