linux-toradex.git/drivers/crypto/atmel-aes.c, branch v4.17

crypto: atmel-aes - fix the keys zeroing on errors

2018-03-02T16:03:40+00:00

The Atmel AES driver uses memzero_explicit on the keys on error, but the
variable zeroed isn't the right one because of a typo. Fix this by using
the right variable.

Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support to authenc(hmac(shaX), Y(aes)) modes")
Signed-off-by: Antoine Tenart 
Reviewed-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel - Delete error messages for a failed memory allocation in six functions

2018-02-22T14:17:00+00:00

Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Reviewed-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel - remove empty functions

2017-11-06T06:45:05+00:00

Pointer members of an object with static storage duration, if not
explicitly initialized, will be initialized to a NULL pointer.
The crypto API checks if these pointers are not NULL before using them,
therefore we can safely remove these empty functions.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel-aes - Reset the controller before each use

2017-11-03T14:11:26+00:00

When using the rfc4543(gcm(aes))) mode, the registers of the hardware
engine are not empty after use. If the engine is not reset before its
next use, the following results will be invalid.

Always reset the hardware engine.

Signed-off-by: Romain Izard 
Signed-off-by: Herbert Xu

crypto: atmel-aes - properly set IV after {en,de}crypt

2017-11-03T14:11:26+00:00

Certain cipher modes like CTS expect the IV (req->info) of
ablkcipher_request (or equivalently req->iv of skcipher_request) to
contain the last ciphertext block when the {en,de}crypt operation is done.

Fix this issue for the Atmel AES hardware engine. The tcrypt test
case for cts(cbc(aes)) is now correctly passed.

In the case of in-place decryption, copy the ciphertext in an
intermediate buffer before decryption.

Signed-off-by: Romain Izard 
Signed-off-by: Herbert Xu

crypto: atmel - remove useless irq init

2017-11-03T14:11:24+00:00

irq would be set to -1 and then unused, if we failed to get IORESOURCE_MEM.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel - return appropriate error code

2017-11-03T14:11:23+00:00

Return -ENODEV when dma_request_slave_channel_compat() fails.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel - Use GCM IV size constant

2017-09-22T09:43:12+00:00

This patch replace GCM IV size value by their constant name.

Signed-off-by: Corentin Labbe 
Signed-off-by: Herbert Xu

crypto: atmel-authenc - add support to authenc(hmac(shaX), Y(aes)) modes

2017-02-03T10:16:14+00:00

This patchs allows to combine the AES and SHA hardware accelerators on
some Atmel SoCs. Doing so, AES blocks are only written to/read from the
AES hardware. Those blocks are also transferred from the AES to the SHA
accelerator internally, without additionnal accesses to the system busses.

Hence, the AES and SHA accelerators work in parallel to process all the
data blocks, instead of serializing the process by (de)crypting those
blocks first then authenticating them after like the generic
crypto/authenc.c driver does.

Of course, both the AES and SHA hardware accelerators need to be available
before we can start to process the data blocks. Hence we use their crypto
request queue to synchronize both drivers.

Signed-off-by: Cyrille Pitchen 
Signed-off-by: Herbert Xu

crypto: atmel-aes - fix atmel_aes_handle_queue()

2017-02-03T10:16:14+00:00

This patch fixes the value returned by atmel_aes_handle_queue(), which
could have been wrong previously when the crypto request was started
synchronously but became asynchronous during the ctx->start() call.

Signed-off-by: Cyrille Pitchen 
Signed-off-by: Herbert Xu