linux-toradex.git/drivers/crypto/atmel-aes.c, branch v5.16-rc5

crypto: atmel-aes - use swap()

2021-07-30T02:58:37+00:00

Use swap() instead of implementing it in order to make code more clean.

Signed-off-by: Salah Triki 
Reviewed-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel-aes - Allocate aes dev at tfm init time

2021-07-30T02:58:35+00:00

Allocate the atmel_aes_dev data at tfm init time, and not for
each crypt request.
There's a single AES IP per SoC, clarify that in the code.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel-aes - Add fallback to XTS software implementation

2021-07-30T02:58:34+00:00

XTS is supported just for input lengths with data units of 128-bit blocks.
Add a fallback to software implementation when the last block is shorter
than 128 bits.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel - Set OFB's blocksize to 1

2021-07-30T02:58:34+00:00

Set cra_blocksize to 1 to indicate OFB is a stream cipher.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel-aes - Add NIST 800-38A's zero length cryptlen constraint

2021-07-30T02:58:33+00:00

NIST 800-38A requires for the ECB, CBC, CFB, OFB and CTR modes that
the plaintext and ciphertext to have a positive integer length.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel-aes - Add XTS input length constraint

2021-07-30T02:58:33+00:00

Input length smaller than block size does not make sense for XTS.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel-aes - Add blocksize constraint for ECB and CBC modes

2021-07-30T02:58:32+00:00

NIST 800-38A requires for the ECB and CBC modes that the total number
of bits in the plaintext to be a multiple of the block cipher.

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: atmel-aes - convert to use be32_add_cpu()

2020-09-25T07:48:12+00:00

Convert cpu_to_be32(be32_to_cpu(E1) + E2) to use be32_add_cpu().

Signed-off-by: Liu Shixin 
Signed-off-by: Herbert Xu

crypto: atmel-{aes,sha,tdes} - Retire crypto_platform_data

2020-01-22T08:21:09+00:00

These drivers no longer need it as they are only probed via DT.
crypto_platform_data was allocated but unused, so remove it.
This is a follow up for:
commit 45a536e3a7e0 ("crypto: atmel-tdes - Retire dma_request_slave_channel_compat()")
commit db28512f48e2 ("crypto: atmel-sha - Retire dma_request_slave_channel_compat()")
commit 62f72cbdcf02 ("crypto: atmel-aes - Retire dma_request_slave_channel_compat()")

Signed-off-by: Tudor Ambarus 
Signed-off-by: Herbert Xu

crypto: remove propagation of CRYPTO_TFM_RES_* flags

2020-01-09T03:30:53+00:00

The CRYPTO_TFM_RES_* flags were apparently meant as a way to make the
->setkey() functions provide more information about errors.  But these
flags weren't actually being used or tested, and in many cases they
weren't being set correctly anyway.  So they've now been removed.

Also, if someone ever actually needs to start better distinguishing
->setkey() errors (which is somewhat unlikely, as this has been unneeded
for a long time), we'd be much better off just defining different return
values, like -EINVAL if the key is invalid for the algorithm vs.
-EKEYREJECTED if the key was rejected by a policy like "no weak keys".
That would be much simpler, less error-prone, and easier to test.

So just remove CRYPTO_TFM_RES_MASK and all the unneeded logic that
propagates these flags around.

Signed-off-by: Eric Biggers 
Signed-off-by: Herbert Xu