linux-toradex.git/drivers/crypto/ccp, branch v5.17-rc4

crypto: ccp - remove unneeded semicolon

2021-12-31T07:10:55+00:00

Eliminate the following coccicheck warning:
./drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Signed-off-by: Herbert Xu

crypto: ccp - Add SEV_INIT_EX support

2021-12-17T05:59:47+00:00

Add new module parameter to allow users to use SEV_INIT_EX instead of
SEV_INIT. This helps users who lock their SPI bus to use the PSP for SEV
functionality. The 'init_ex_path' parameter defaults to NULL which means
the kernel will use SEV_INIT, if a path is specified SEV_INIT_EX will be
used with the data found at the path. On certain PSP commands this
file is written to as the PSP updates the NV memory region. Depending on
file system initialization this file open may fail during module init
but the CCP driver for SEV already has sufficient retries for platform
initialization. During normal operation of PSP system and SEV commands
if the PSP has not been initialized it is at run time. If the file at
'init_ex_path' does not exist the PSP will not be initialized. The user
must create the file prior to use with 32Kb of 0xFFs per spec.

Signed-off-by: David Rientjes 
Co-developed-by: Peter Gonda 
Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Reported-by: kernel test robot 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Add psp_init_on_probe module parameter

2021-12-17T05:59:47+00:00

Add psp_init_on_probe module parameter that allows for skipping the
PSP's SEV platform initialization during module init. User may decouple
module init from PSP init due to use of the INIT_EX support in upcoming
patch which allows for users to save PSP's internal state to file. The
file may be unavailable at module init.

Also moves the PSP ABI version log message to after successful PSP init
instead of module init in case this new parameter is used.

Signed-off-by: Peter Gonda 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Refactor out sev_fw_alloc()

2021-12-17T05:59:47+00:00

Create a helper function sev_fw_alloc() which can be used to allocate
aligned memory regions for use by the PSP firmware. Currently only used
for the SEV-ES TMR region but will be used for the SEV_INIT_EX NV memory
region.

Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Acked-by: David Rientjes 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Move SEV_INIT retry for corrupted data

2021-12-17T05:59:46+00:00

Move the data corrupted retry of SEV_INIT into the
__sev_platform_init_locked() function. This is for upcoming INIT_EX
support as well as helping direct callers of
__sev_platform_init_locked() which currently do not support the
retry.

Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Acked-by: David Rientjes 
Acked-by: Tom Lendacky 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - Add SEV_INIT rc error logging on init

2021-12-17T05:59:46+00:00

Currently only the firmware error code is printed. This is incomplete
and also incorrect as error cases exists where the firmware is never
called and therefore does not set an error code.

Signed-off-by: Peter Gonda 
Reviewed-by: Marc Orr 
Acked-by: David Rientjes 
Acked-by: Tom Lendacky 
Acked-by: Brijesh Singh 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: Paolo Bonzini 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu

crypto: ccp - no need to initialise statics to 0

2021-11-20T04:06:38+00:00

Static variables do not need to be initialized to 0.

Signed-off-by: Jason Wang 
Signed-off-by: Herbert Xu

Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6

2021-11-02T04:24:02+00:00

Pull crypto updates from Herbert Xu:
 "API:

   - Delay boot-up self-test for built-in algorithms

  Algorithms:

   - Remove fallback path on arm64 as SIMD now runs with softirq off

  Drivers:

   - Add Keem Bay OCS ECC Driver"

* 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6: (61 commits)
  crypto: testmgr - fix wrong key length for pkcs1pad
  crypto: pcrypt - Delay write to padata->info
  crypto: ccp - Make use of the helper macro kthread_run()
  crypto: sa2ul - Use the defined variable to clean code
  crypto: s5p-sss - Add error handling in s5p_aes_probe()
  crypto: keembay-ocs-ecc - Add Keem Bay OCS ECC Driver
  dt-bindings: crypto: Add Keem Bay ECC bindings
  crypto: ecc - Export additional helper functions
  crypto: ecc - Move ecc.h to include/crypto/internal
  crypto: engine - Add KPP Support to Crypto Engine
  crypto: api - Do not create test larvals if manager is disabled
  crypto: tcrypt - fix skcipher multi-buffer tests for 1420B blocks
  hwrng: s390 - replace snprintf in show functions with sysfs_emit
  crypto: octeontx2 - set assoclen in aead_do_fallback()
  crypto: ccp - Fix whitespace in sev_cmd_buffer_len()
  hwrng: mtk - Force runtime pm ops for sleep ops
  crypto: testmgr - Only disable migration in crypto_disable_simd_for_test()
  crypto: qat - share adf_enable_pf2vf_comms() from adf_pf2vf_msg.c
  crypto: qat - extract send and wait from adf_vf2pf_request_version()
  crypto: qat - add VF and PF wrappers to common send function
  ...

crypto: ccp - Make use of the helper macro kthread_run()

2021-10-29T13:04:04+00:00

Repalce kthread_create/wake_up_process() with kthread_run()
to simplify the code.

Signed-off-by: Cai Huoqing 
Signed-off-by: Herbert Xu

crypto: ccp - Fix whitespace in sev_cmd_buffer_len()

2021-10-15T10:45:34+00:00

Extra tab in sev_cmd_buffer_len().

Signed-off-by: Peter Gonda 
Cc: Tom Lendacky 
Cc: Brijesh Singh 
Cc: Marc Orr 
Cc: Joerg Roedel 
Cc: Herbert Xu 
Cc: David Rientjes 
Cc: John Allen 
Cc: "David S. Miller" 
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Marc Orr 
Signed-off-by: Herbert Xu