linux-toradex.git/drivers/crypto/img-hash.c, branch v4.19-rc5

crypto: img-hash - remove unnecessary static in img_hash_remove()

2017-08-03T05:47:18+00:00

Remove unnecessary static on local variable hdev. Such variable
is initialized before being used, on every execution path throughout
the function. The static has no benefit and, removing it reduces the
object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   text    data     bss     dec     hex filename
  14842    6464     128   21434    53ba drivers/crypto/img-hash.o

after:
   text    data     bss     dec     hex filename
  14789    6376      64   21229    52ed drivers/crypto/img-hash.o

Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Herbert Xu

crypto: img-hash - Handle return value of clk_prepare_enable

2017-05-23T04:52:03+00:00

Here, Clock enable can failed. So adding an error check for
clk_prepare_enable.

Signed-off-by: Arvind Yadav 
Signed-off-by: Herbert Xu

crypto: img-hash - use dma_data_direction when calling dma_map_sg

2017-01-23T14:50:23+00:00

The fourth argument of dma_map_sg() and dma_unmap_sg() is an item of
dma_data_direction enum. Function img_hash_xmit_dma() wrongly used
DMA_MEM_TO_DEV, which is an item of dma_transfer_direction enum.

Replace DMA_MEM_TO_DEV (which value is 1) with DMA_TO_DEVICE (which
value is fortunately also 1) when calling dma_map_sg() and
dma_unmap_sg().

Signed-off-by: Nicolas Iooss 
Signed-off-by: Herbert Xu

crypto: img-hash - Fix set_reqsize call

2016-08-09T10:47:23+00:00

Properly allocate enough memory to respect the fallback.

Signed-off-by: Will Thomas 
Signed-off-by: Herbert Xu

crypto: img-hash - log a successful probe

2016-08-09T10:47:22+00:00

Currently the probe function only emits an output on success
when debug is specifically enabled. It would be more useful
if this happens by default.

Signed-off-by: James Hartley 
Reviewed-by: Will Thomas 
Signed-off-by: Herbert Xu

crypto: img-hash - Add support for export and import

2016-08-09T10:47:22+00:00

Currently the img-hash accelerator does not probe
successfully due to a change in the checks made during
registration with the crypto framework. This is due to
import and export functions not being defined. Correct
this.

Signed-off-by: James Hartley 
Signed-off-by: Will Thomas 
Signed-off-by: Herbert Xu

crypto: img-hash - Add suspend resume hooks for img hash

2016-08-09T10:47:21+00:00

Current img hash claims sys and periph gate clocks
and this can be gated in system suspend scenarios.

Add support for Device pm ops for img hash to gate
the clocks claimed by img hash.

Signed-off-by: Govindraj Raja 
Reviewed-by: Will Thomas 
Signed-off-by: Herbert Xu

crypto: img-hash - Reconfigure DMA Burst length

2016-08-09T10:47:20+00:00

Burst length of 16 drives the hash accelerator out of spec
and causes stability issues in some cases. Reduce this to
stop data being lost.

Signed-off-by: Will Thomas 
Reviewed-by: James Hartley 
Signed-off-by: Herbert Xu

crypto: img-hash - Fix hash request context

2016-08-09T10:47:20+00:00

Move 0 length buffer to end of structure to stop overwriting
fallback request data. This doesn't cause a bug itself as the
buffer is never used alongside the fallback but should be
changed.

Signed-off-by: Will Thomas 
Reviewed-by: James Hartley 
Signed-off-by: Herbert Xu

crypto: img-hash - Fix null pointer exception

2016-08-09T10:47:19+00:00

Sporadic null pointer exceptions came from here. Fix them.

Signed-off-by: Will Thomas 
Reviewed-by: James Hartley 
Signed-off-by: Herbert Xu