linux-toradex.git/drivers/crypto/inside-secure, branch v4.14-rc5

crypto: inside-secure - fix gcc-4.9 warnings

2017-09-20T09:42:41+00:00

All older compiler versions up to gcc-4.9 produce these
harmless warnings:

drivers/crypto/inside-secure/safexcel_cipher.c:389:9: warning: missing braces around initializer [-Wmissing-braces]
drivers/crypto/inside-secure/safexcel_cipher.c:389:9: warning: (near initialization for ‘result.completion’) [-Wmissing-braces]
drivers/crypto/inside-secure/safexcel_hash.c:422:9: warning: missing braces around initializer [-Wmissing-braces]
drivers/crypto/inside-secure/safexcel_hash.c:422:9: warning: (near initialization for ‘result.completion’) [-Wmissing-braces]

This changes the syntax to something that works on all versions
without warnings.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Arnd Bergmann 
Acked-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - fix an error handling path in safexcel_probe()

2017-08-22T06:54:55+00:00

'ret' is known to be 0 at this point.
If 'safexcel_request_ring_irq()' fails, it returns an error code.
Return this value instead of 0 which means success.

Signed-off-by: Christophe JAILLET 
Signed-off-by: Herbert Xu

crypto: inside-secure - fix the sha state length in hmac_sha1_setkey

2017-08-03T05:36:11+00:00

A check is performed on the ipad/opad in the safexcel_hmac_sha1_setkey
function, but the index used by the loop doing it is wrong. It is
currently the size of the state array while it should be the size of a
sha1 state. This patch fixes it.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Reported-by: Dan Carpenter 
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - fix invalidation check in hmac_sha1_setkey

2017-08-03T05:36:10+00:00

The safexcel_hmac_sha1_setkey function checks if an invalidation command
should be issued, i.e. when the context ipad/opad change. This checks is
done after filling the ipad/opad which and it can't be true. The patch
fixes this by moving the check before the ipad/opad memcpy operations.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - do not parse the dma mask from dt

2017-07-18T09:01:01+00:00

Remove the dma mask parsing from dt as this should not be encoded into
the engine device tree node. Keep the fallback value for now, which
should work for the boards already supported upstream.

Signed-off-by: Antoine Tenart 
Acked-by: Arnd Bergmann 
Signed-off-by: Herbert Xu

crypto: inside-secure - use the base_end pointer in ring rollback

2017-06-20T03:21:48+00:00

A base_end pointer is set and provided. Use it in the ring rollback
function to avoid using build-in defines.

Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - increase the batch size

2017-06-20T03:21:47+00:00

Increase the batch size to the maximum number of requests a ring can
handle at a time (its size). This is possible now that the request
queues are per hw ring. This improves performances.

Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - only dequeue when needed

2017-06-20T03:21:47+00:00

This force the need_dequeue flag to be unset whenever the dequeue
function is called, to avoid calling it when it is not necessary.

Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - get the backlog before dequeueing the request

2017-06-20T03:21:46+00:00

Get the backlog before dequeuing the request otherwise we'll miss the
first request in line.

Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu

crypto: inside-secure - stop requeueing failed requests

2017-06-20T03:21:45+00:00

This update the dequeue function of the inside-secure safexcel driver so
that failed requests aren't requeued when they fail (for whatever
reason, which can be because the hw ring is full).

Signed-off-by: Antoine Tenart 
Signed-off-by: Herbert Xu