linux-toradex.git/drivers/crypto/keembay, branch v5.16-rc5

crypto: keembay-ocs-ecc - Add Keem Bay OCS ECC Driver

2021-10-29T13:04:03+00:00

The Intel Keem Bay SoC can provide hardware acceleration of Elliptic
Curve Cryptography (ECC) by means of its Offload and Crypto Subsystem
(OCS).

Add the Keem Bay OCS ECC driver which leverages such hardware
capabilities to provide hardware-acceleration of ECDH-256 and ECDH-384.

Signed-off-by: Prabhjot Khurana 
Co-developed-by: Daniele Alessandrelli 
Signed-off-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay - Remove redundant dev_err calls

2021-04-16T11:16:32+00:00

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: YueHaibing 
Signed-off-by: Herbert Xu

crypto: keembay - Fix incorrectly named functions/structs

2021-03-26T09:02:35+00:00

Fixes the following W=1 kernel build warning(s):

 drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
 drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead
 drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead
 drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead

Cc: Daniele Alessandrelli 
Cc: Declan Murphy 
Cc: Herbert Xu 
Cc: "David S. Miller" 
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Lee Jones 
Reviewed-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay-ocs-aes - Fix error return code in kmb_ocs_aes_probe()

2021-03-07T04:13:15+00:00

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
Reviewed-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay-ocs-hcu - Fix error return code in kmb_ocs_hcu_probe()

2021-03-07T04:13:15+00:00

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 472b04444cd3 ("crypto: keembay - Add Keem Bay OCS HCU driver")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
Reviewed-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay-ocs-aes - Fix 'q' assignment during CCM B0 generation

2021-02-10T06:55:59+00:00

In ocs_aes_ccm_write_b0(), 'q' (the octet length of the binary
representation of the octet length of the payload) is set to 'iv[0]',
while it should be set to 'iv[0] & 0x7' (i.e., only the last 3
bits of iv[0] should be used), as documented in NIST Special Publication
800-38C:
https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38c.pdf

In practice, this is not an issue, since 'iv[0]' is checked to be in the
range [1-7] by ocs_aes_validate_inputs(), but let's fix the assignment
anyway, in order to make the code more robust.

Signed-off-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay - use 64-bit arithmetic for computing bit_len

2021-01-22T03:58:04+00:00

src_size and aad_size are defined as u32, so the following expressions are
currently being evaluated using 32-bit arithmetic:

bit_len = src_size * 8;
...
bit_len = aad_size * 8;

However, bit_len is used afterwards in a context that expects a valid
64-bit value (the lower and upper 32-bit words of bit_len are extracted
and written to hw).

In order to make sure the correct bit length is generated and the 32-bit
multiplication does not wrap around, cast src_size and aad_size to u64.

Signed-off-by: Ovidiu Panait 
Acked-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay-ocs-hcu - Add dependency on HAS_IOMEM and ARCH_KEEMBAY

2021-01-14T06:43:10+00:00

Add the following additional dependencies for CRYPTO_DEV_KEEMBAY_OCS_HCU:

- HAS_IOMEM to prevent build failures

- ARCH_KEEMBAY to prevent asking the user about this driver when
  configuring a kernel without Intel Keem Bay platform support.

Signed-off-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay-ocs-hcu - Fix a WARN() message

2021-01-14T06:10:30+00:00

The first argument to WARN() is a condition and the messages is the
second argument is the string, so this WARN() will only display the
__func__ part of the message.

Fixes: ae832e329a8d ("crypto: keembay-ocs-hcu - Add HMAC support")
Signed-off-by: Dan Carpenter 
Acked-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu

crypto: keembay-ocs-hcu - Add optional support for sha224

2021-01-02T21:41:37+00:00

Add optional support of sha224 and hmac(sha224).

Co-developed-by: Declan Murphy 
Signed-off-by: Declan Murphy 
Signed-off-by: Daniele Alessandrelli 
Signed-off-by: Herbert Xu