linux-toradex.git/drivers/crypto/qce, branch v5.13-rc3

crypto: qce - Remove totallen and offset in qce_start

2021-03-07T04:13:17+00:00

totallen is used to get the size of the data to be transformed.
This is also available via nbytes or cryptlen in the qce_sha_reqctx
and qce_cipher_ctx. Similarly offset convey nothing for the supported
encryption and authentication transformations and is always 0.
Remove these two redundant parameters in qce_start.

Reviewed-by: Bjorn Andersson 
Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Remover src_tbl from qce_cipher_reqctx

2021-03-07T04:13:17+00:00

src_table is unused and hence remove it from struct qce_cipher_reqctx

Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Set data unit size to message length for AES XTS transformation

2021-03-07T04:13:17+00:00

Set the register REG_ENCR_XTS_DU_SIZE to cryptlen for AES XTS
transformation. Anything else causes the engine to return back
wrong results.

Acked-by: Bjorn Andersson 
Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Improve the conditions for requesting AES fallback cipher

2021-03-07T04:13:16+00:00

The following are the conditions for requesting AES fallback cipher.
	-  AES-192
	- AES-XTS request with len <= 512 byte (Allow messages of length
	  less than 512 bytes for all other AES encryption algorithms other
	  than AES XTS)
	- AES-XTS request with len > QCE_SECTOR_SIZE and is not a multiple
	  of it

Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Set ivsize to 0 for ecb(aes)

2021-03-07T04:13:16+00:00

ECB transformations do not have an IV and hence set the ivsize to 0 for
ecb(aes).

Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Return error for non-blocksize data(ECB/CBC algorithms)

2021-03-07T04:13:16+00:00

ECB/CBC encryption/decryption requires the data to be blocksize aligned.
Crypto engine hangs on non-block sized operations for these algorithms.
Return invalid data if data size is not blocksize aligned for these
algorithms.

Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Return error for zero length messages

2021-03-07T04:13:16+00:00

Crypto engine BAM dma does not support 0 length data. Return unsupported
if zero length messages are passed for transformation.

Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Return unsupported if any three keys are same for DES3 algorithms

2021-03-07T04:13:16+00:00

Return unsupported if any three keys are same for DES3 algorithms
since CE does not support this and the operation causes the engine to
hang.

Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Return unsupported if key1 and key 2 are same for AES XTS algorithm

2021-03-07T04:13:16+00:00

Crypto engine does not support key1 = key2 for AES XTS algorithm; the
operation hangs the engines.  Return -EINVAL in case key1 and key2 are the
same.

Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu

crypto: qce - Hold back a block of data to be transferred as part of final

2021-03-07T04:13:15+00:00

If the available data to transfer is exactly a multiple of block size, save
the last block to be transferred in qce_ahash_final (with the last block
bit set) if this is indeed the end of data stream. If not this saved block
will be transferred as part of next update. If this block is not held back
and if this is indeed the end of data stream, the digest obtained will be
wrong since qce_ahash_final will see that rctx->buflen is 0 and return
doing nothing which in turn means that a digest will not be copied to the
destination result buffer.  qce_ahash_final cannot be made to alter this
behavior and allowed to proceed if rctx->buflen is 0 because the crypto
engine BAM does not allow for zero length transfers.

Reviewed-by: Bjorn Andersson 
Signed-off-by: Thara Gopinath 
Signed-off-by: Herbert Xu